niklas/rclcpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1151 commits 1 branch 0 tags 3.3 MiB
Commit graph

150 commits

Author SHA1 Message Date
Jacob Perron
3dddfd7d93
Reserve vector capacities and use emplace_back for constructing vectors (#1464) (#1489) 
* Reserve vector capacities and use emplace_back for constructing vectors

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Use resize instead of reserve

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Remove push_back

Signed-off-by: Stephen Brawner <brawner@gmail.com>

Co-authored-by: brawner <brawner@gmail.com>
 2020-12-08 14:46:36 -08:00
Jacob Perron
b132a2b0cd
[rclcpp_lifecycle] Change uint8_t iterator variables to size_t (#1461) (#1488) 
* Change uint8_t iterator variables to size_t

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Change to unsigned int

Signed-off-by: Stephen Brawner <brawner@gmail.com>

Co-authored-by: brawner <brawner@gmail.com>
 2020-12-08 12:35:37 -08:00
Stephen Brawner
a4fd8ceece
[foxy] Update QD to QL 1 (#1480) 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-11-30 14:34:24 -08:00
Stephen Brawner
bea9c5a8f6
Benchmark lifecycle features (#1462) (#1471) 
* Benchmark lifecycle features

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Cleanup

Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-11-22 19:30:28 -08:00
Louise Poubel
6820dac315
Bump rclcpp packages to Quality Level 2 (#1445) (#1446) 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
 2020-11-09 18:37:16 -08:00
Dirk Thomas
d04ec4bf80 fix race in test_lifecycle_service_client (#1204) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-11-03 19:35:22 +01:00
brawner
e920175dae Increase test coverage of rclcpp_lifecycle to 96% (#1298) 
* Increase test coverage of rclcpp_lifecycle to 96%

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* test_depend

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* rcutils test_depend

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* More windows warnings

Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-11-03 19:35:22 +01:00
Alejandro Hernández Cordero
ed7a23731a Added missing tests for rclcpp lifecycle (#1240) 
* Added missing test rclcpp lifecycle
 - remove_on_set_parameters_callback
 - notify_graph_change
 - get_service_names_and_types_by_node

Signed-off-by: ahcorde <ahcorde@gmail.com>

* omit the name of the argument in lambda function

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Removed extra line

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-11-03 19:35:22 +01:00
ahcorde
f357033ad7 udpate QD links to foxy 
Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-10-28 09:17:36 +01:00
Alejandro Hernández Cordero
8f2f746b41 Bump to QD to level 3 and fixed links (#1158) 
* Update quality level and links to doc

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed wording and links

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Bump QD to level 3 and fixed links

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added missing dependency rcpputils to rclcpp_components

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added missing dependency rmw to rclcpp_lifecycle

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* changed ci_linux_coverage to nightly_linux_coverage

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-10-28 09:17:36 +01:00
Jacob Perron
cf1be86f5c 2.2.0 2020-10-07 10:50:16 -07:00
brawner
6e6dd9cb1a
[backport foxy] Log error instead of throwing exception in Transition and State reset() mark no except (#1297) (#1378) 
* Log error instead of throwing exception in Transition and State reset(), mark no except (#1297)

* Catch potential exception in destructor and log

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Remove thrown error from reset and mark it no except

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Remove noexcept for ABI compatibility

Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-10-05 15:44:55 -07:00
brawner
b843c75ef8
Remove rmw-dependent unit-test checks (#1293) (#1377) 
* Remove rmw-dependent unit-test checks

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Address feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-10-05 13:38:17 -07:00
Jacob Perron
27e59d930a 2.1.0 2020-08-03 15:03:27 -07:00
Jacob Perron
ce5de8757d
Warn about unused result of add_on_set_parameters_callback (#1238) (#1244) 
If the user doesn't retain a reference to the returned shared pointer there will be zero references and their callback will be unregistered.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2020-08-03 12:10:27 -07:00
Jacob Perron
dc528ad710 2.0.2 2020-07-07 21:07:12 -07:00
Jacob Perron
1745db6dcd 2.0.1 2020-06-23 17:32:15 -07:00
Alejandro Hernández Cordero
1f000b8d97
Fixed doxygen warnings (#1163) (#1191) 
Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-06-23 19:43:41 +02:00
William Woodall
bf70ce15bf
2.0.0 2020-06-01 21:54:47 -07:00
William Woodall
cf92aad139
changelogs 
Signed-off-by: William Woodall <william@osrfoundation.org>
 2020-06-01 21:51:42 -07:00
Ivan Santiago Paunovic
769a9d0439
Add missing virtual destructors (#1149) 
* Add -Wnon-virtual-dtor -Woverloaded-virtual compiler options

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

* Add missing virtual dtors

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

* please linter

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-06-01 19:58:48 -07:00
Chris Lalancette
fdf232b7b8
Add Security Vulnerability Policy pointing to REP-2006. (#1130) 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-05-29 16:49:45 -04:00
Ivan Santiago Paunovic
eff11d61bb
Fix test_lifecycle_node.cpp:check_parameters (#1136) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-05-27 16:59:35 -03:00
Jacob Perron
337984db42 1.1.0 2020-05-26 20:40:26 -07:00
Claire Wang
d13c098feb
Deprecate set_on_parameters_set_callback (#1123) 
* add deprecate statement
* replace tests to use add_on_param fn
* deprecate set_on_pram fn in node_parameters
* deprecate in lifecycle_node and add replacement fn
* update documentation
* add warning suppression to test_node.cpp
* correct namespace in lifecycle_node.cpp
* remove whitespace fix line length in lifecycle_node
* move reset fn to below add_on
* deprecate set_on in test_lifecycle_node
* suppress deprecation warning in node.cpp
* suppress warning in lifecycle_node.cpp

Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
 2020-05-26 19:19:20 -07:00
claireyywang
223aeecb53 reduce line length 
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
 2020-05-26 14:39:11 -07:00
claireyywang
63a48a1998 remove return from void fn 
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
 2020-05-26 13:28:25 -07:00
claireyywang
9de9c466b5 add } 
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
 2020-05-26 12:17:41 -07:00
claireyywang
b3e526ce3c add add_on and remove_on 
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
 2020-05-26 11:47:53 -07:00
Dirk Thomas
0ef9731feb
expose get_service_names_and_types_by_node from rcl in rclcpp (#1131) 
* expose get_service_names_and_types_by_node from rcl in rclcpp

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* fix spelling

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* zero initialize

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* check return value and cleanup

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* use throw_from_rcl_error

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* cleanup error handling

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-05-26 10:26:51 -07:00
Alejandro Hernández Cordero
731558aafb
Added features to rclcpp packages (#1106) 
* Added features to rclcpp packages

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback and improved lifecycle docblock

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added ffedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixing error

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-05-15 16:41:25 +02:00
Alejandro Hernández Cordero
9f04391fbb
[Quality Declaration] Fixed rep links and added more details to dependencies (#1116) 
* Fixed rep links and added more details to dependencies

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed rep link

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-05-13 15:47:05 +02:00
brawner
df3ba3a279
Update QDs to reflect version 1.0 (#1115) 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-05-12 17:55:49 -07:00
Jacob Perron
cb4bdb7b19 1.0.0 2020-05-12 14:05:31 -07:00
Karsten Knese
e24f402238
avoid callback_group deprecation (#1108) 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
 2020-05-08 09:04:38 -07:00
Chris Lalancette
4d1de47df3 0.9.1 2020-05-08 15:40:05 +00:00
Chris Lalancette
5b1877adc4 Changelog. 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-05-08 15:39:57 +00:00
Alejandro Hernández Cordero
e0d0e03078
Added rclcpp lifecycle Doxyfile (#1089) 
* Added rclcpp lifecycle Doxyfile

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed doxyfile

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-05-08 08:48:52 +02:00
Alejandro Hernández Cordero
e2dbc5d5d5
Added Quality declaration: rclcpp, rclpp_action, rclcpp_components andrclcpp_lifecycle (#1100) 
* Added Quality declaration: rclcpp, rclpp_action, rclcpp_components, rclcpp_lifecycle

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-05-01 22:41:22 +02:00
brawner
f69b18203f
Increasing test coverage of rclcpp_lifecycle (#1045) 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-04-30 10:29:45 -07:00
Jacob Perron
1c943d16fc 0.9.0 2020-04-29 22:44:16 -07:00
Dirk Thomas
45f3976453
export targets in a addition to include directories / libraries (#1096) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-04-27 10:30:33 -07:00
William Woodall
df3c2ffa8a
deprecate redundant namespaces (#1083) 
* deprecate redundant namespaces, move classes to own files, rename some classes

Signed-off-by: William Woodall <william@osrfoundation.org>

* fixup

Signed-off-by: William Woodall <william@osrfoundation.org>

* address review comments

Signed-off-by: William Woodall <william@osrfoundation.org>

* fix ups since rebase

Signed-off-by: William Woodall <william@osrfoundation.org>

* avoid deprecation warnings from deprecated functions

Signed-off-by: William Woodall <william@osrfoundation.org>

* more fixes

Signed-off-by: William Woodall <william@osrfoundation.org>

* another fixup, after another rebase

Signed-off-by: William Woodall <william@osrfoundation.org>
 2020-04-23 15:28:45 -07:00
Devin Bonnie
bb91b6c2ef
Integrate topic statistics (#1072) 
* Add SubscriberTopicStatistics class

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Add SubscriberTopicStatistics Test

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Modify constructor to allow a node to create necessary components

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Fix docstring style

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Remove SetPublisherTimer method

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Change naming style to match rclcpp

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address style issues

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Use rclcpp:Time

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Remove unnecessary check for null publisher timer
Move anonymous namespace function to private class method

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Update message dependency

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Initial integration of Subscriber Topic Statistics

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Fix nanoseconds used for Topic Stats

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Add simple publishing test
Minor fixes

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Add test utils header

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Integrate with Topic Statistics options
Fixes after rebasing with master

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Update after rebasing

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address minor review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Move Topic Statistics instantiation to create_subscription

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Fix rebase issue
Fix topic statistics enable flag usage
Address minor formatting

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Move new timer creation method to relevant header

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Add timers interface to topic interface

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Use new create timer method

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
 2020-04-22 16:09:41 -07:00
Prajakta Gokhale
649d72f835
Reflect changes in rclcpp API (#1079) 
* Reflect changes in rclcpp API

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Revert earlier fix made in rclcpp

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
 2020-04-21 14:14:47 -07:00
Jacob Perron
e3949cb5ec
Fix unknown macro errors reported by cppcheck 1.90 (#1000) 
It was complaining about an unknown macro RCLCPP_SMART_PTR_DEFINITIONS.
Passing rclcpp include directories to cppcheck resolves the errors
reported in rclcpp_action and rclcpp_lifecycle.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2020-03-04 09:05:21 -08:00
Alejandro Hernández Cordero
090e1cbec3
[rclcpp lifecycle] removed rmw_implementation from package.xml (#991) 
* rclcpp lifecycle removed rmw_implementation from package.xml

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

* rclcpp lifecycle added rmw depend in package.xml

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
 2020-02-27 08:39:11 +01:00
Barry Xu
2d9c6ea3a7
Implement functions to get publisher and subcription informations like QoS policies from topic name (#960) 
Signed-off-by: Barry Xu <Barry.Xu@sony.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
Co-authored-by: Miaofei Mei <ameision@hotmail.com>
 2020-02-14 17:25:03 -03:00
Steven Macenski
9d5947108b Create node clock calls const (try 2) (#922) 
* create node clock calls const

Signed-off-by: stevemacenski <stevenmacenski@gmail.com>

* two methods for get clock, one const

Signed-off-by: stevemacenski <stevenmacenski@gmail.com>

* changing APIs for NodeClock and NodeClockInterface

Signed-off-by: stevemacenski <stevenmacenski@gmail.com>

* changing RCLCPP_LIFECYCLE_PUBLIC from RCLCPP_PUBLIC for rclcpp lifecycle node get_clock const method

Signed-off-by: stevemacenski <stevenmacenski@gmail.com>
 2019-12-06 14:03:58 -08:00
monidzik
88a342db29 Type conversions fixes (#901) 
* Fix type conversions

Signed-off-by: Monika Idzik <monika.idzik@apex.ai>

* Add static_casts

Signed-off-by: Monika Idzik <monika.idzik@apex.ai>

* Address PR comments

Signed-off-by: Monika Idzik <monika.idzik@apex.ai>

* Remove one time use variable

Signed-off-by: Monika Idzik <monika.idzik@apex.ai>
 2019-11-22 10:23:55 -08:00