There are currently no paths that lead to it, and it has
a bug anyway; if a large enough value is passed into sec,
then we will overflow sec on the multiply. Just remove it
since we can't reach the code anyway.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* expand topic name before invoking count pub/sub
* convenience function for get_namespace()
* uncrustify
* typo
* add get_namespace() test
* add get_namespace() for lifecycle
* add expand_topic_or_service_name()
* use namespace in intra process
(actual change to topic names in next commit)
* catch and report name issues
for node names, namespaces, and topic/service names
* address comment
* comply with unused warnings
* fix flakiness and add test for transitions
* mark flaky test
* duplicate const char * in State constructor
* linters
* correct year in license
* mark flaky test
* initial commit for rclcpp::time::now()
* switch between times
* introduce time class
* add rclcpp/time.hpp to rclcpp/rclcpp.hpp
* throw exceptions on time error
* fix test_time to catch exceptions
* explicit one-parameter constructor
* fix msvc compiler warnings
* address review comments
* cleanup includes
* re-add todo for fixing test once ros-time is there
* add a new Node::get_parameter() with a default value
* update function parameter name (signature)
* update function parameter name (definition)
* rename new function to get_parameter_or
* rename arg "parameter" to "value" and fix get_parameter
* add set_parameter_if_not_set
* add some comments to clarify logic in set_parameters_atomically
* uncrustify
* address comments
* add some docs for get_parameter*
* add /W4 flag for windows
* use uint8 like defined in messages: fix warning C4244
* fix sign size_t comparison
* add only pedantic, not W4, deal with windows another day
* another sign compare warning
* basic doxygen configuration
* fix up documentation
* change default value of PROJECT_NUMBER
* more generalization
* fixup
* fixup
* avoid displaying RCLCPP_PUBLIC on all functions
* main page
* isolate chrono literals in literals.hpp
* rclcpp.hpp: remove 'using namespace rclcpp::literals'
The examples have been migrated to the new namespace.
* literals: constexpr, make return types consistent with function body
_ms returned nanoseconds instead of milliseconds.
A few return types where using integral return type
for floating point literals.
* remove literals in favor of std::chrono_literals
* initial state machine implementation
(fix) correctly initialize default state machine
uncrustify
(dev) first high level api interface
src/default_state_machine.c
(fix) correctly initialize arrays in statemachine
(dev) deactivate/activate publisher demo
(dev) initial state machine implementation in rcl
* (dev) demo application for a managed lifecycle node
* add visibility control
* correct install of c-library
* fix compilation on windows
* refactoring of external/internal api
* (dev) generate static functions for c-callback
* (fix) correct typo
* (dev) cleanup for c-statemachine
(dev) cleanup for c-statemachine
* (dev) cpp callback map
* (dev) mv source file into project folders
* (dev) more helper functions for valid transition
* (dev) pimpl implementation for cpp lifecyclemanager
* (dev) register non-default callback functions
* (dev) cleanup lifecycle node to serve as base class
* (dev) new my_node child of lifecyclenode for demo purpose
update
stuff
(cleanup) remove unused comments
(fix) correct dllexport in windows
(fix) correctly install libraries
(fix) uncrustify
(dev) composition over inheritance
(dev) publish notification in state_machine transition
(dev) lifecycle talker + listener demo for notification
(dev) custom transition message generation
(dev) publish transition message on state change
(dev) correctly malloc/free c data structures
(fix) use single thread executor
(dev) use services for get state
(fix) set freed pointer to NULL
(dev) add change state service
(dev) introduce services: get_state and change_state in LM
(dev) asynchronous caller script for service client
(fix) correct dllexport for pimpl
(dev) correct constness
(dev) concatenate function for topic
(fix) uncrustify
prepare new service api
(tmp) refactor stash
(fix) correctly concatenate topics
(fix) correctly initialize Service wo/ copy
(dev) call both service types
extract demo files
(fix) remove debug prints
(dev) change to lifecycle_msgs
(refactor) extract rcl_lifecycle package
(refactor) extract lifecycle demos
(fix) address review comments
(fix) address review comments
(fix) pass shared_ptr by value
(fix) make find_package(rmw) required
(fix) return to shared node handle pointer
(refactor) attach sm to lifecycle node and disable lc_manager
(dev) construct service from existing rcl_service_t
(refactor) extract method for adding a service to a node
(fix) stop mock msgs from being installed
service takes rcl_node_t*
correct typo
add_service has to be public
uncrustify
initial state machine implementation
(fix) correctly initialize default state machine
uncrustify
(dev) first high level api interface
src/default_state_machine.c
(fix) correctly initialize arrays in statemachine
(dev) deactivate/activate publisher demo
(dev) initial state machine implementation in rcl
(dev) demo application for a managed lifecycle node
add visibility control
correct install of c-library
fix compilation on windows
refactoring of external/internal api
(dev) generate static functions for c-callback
(fix) correct typo
(dev) cleanup for c-statemachine
(dev) cleanup for c-statemachine
(dev) cpp callback map
(dev) mv source file into project folders
(dev) more helper functions for valid transition
(dev) pimpl implementation for cpp lifecyclemanager
(dev) register non-default callback functions
(dev) cleanup lifecycle node to serve as base class
(dev) new my_node child of lifecyclenode for demo purpose
update
stuff
(cleanup) remove unused comments
(fix) correct dllexport in windows
(fix) correctly install libraries
(fix) uncrustify
(dev) composition over inheritance
(dev) publish notification in state_machine transition
(dev) lifecycle talker + listener demo for notification
(dev) custom transition message generation
(dev) publish transition message on state change
(dev) correctly malloc/free c data structures
(fix) use single thread executor
(dev) use services for get state
(fix) set freed pointer to NULL
(dev) add change state service
(dev) introduce services: get_state and change_state in LM
(dev) asynchronous caller script for service client
(fix) correct dllexport for pimpl
(dev) correct constness
(dev) concatenate function for topic
(fix) uncrustify
prepare new service api
(tmp) refactor stash
* (dev) construct service from existing rcl_service_t
* service takes rcl_node_t*
* correct typo
* add_service has to be public
* uncrustify
* (fix) correctly concatenate topics
* (fix) correctly initialize Service wo/ copy
* (dev) call both service types
* extract demo files
* (fix) remove debug prints
* (dev) change to lifecycle_msgs
* (refactor) extract rcl_lifecycle package
* (refactor) extract lifecycle demos
* (fix) address review comments
(fix) address review comments
* (fix) make find_package(rmw) required
* (refactor) attach sm to lifecycle node and disable lc_manager
* (fix) adjust code to rcl_test refactor
* (dev) remove unused deps
* (rebase) merge commit
* (bugfix) correct rcl_ret_t error handling
* (fix) depedencies
* (refactor) change to lifecycle_msgs
* (fix) correct find_rcl
* (refactor) comply for new state machine
* visibility control and test api
* (rebase) change to new typesupport
* uncrustify'
* fix visibility control
* (fix) correct whitespace
* (fix) unused variable
* comparison signed and unsigned
* get_state returns complete state
* get_available_states service
* new service msgs
* get available states and transitions api
* (broken) state after rebase, does not compile demos
* fix the way lifecycle node impl is included
* fixed rebase compilation errors
* remove copy&paste comment
* remove empty line
* (test) register custom callbacks
* (dev) return codes
* style
* test for exception handling
* refacotr new state machine
* c++14
* change exception message for windows ci bug
change exception message for windows ci bug
* add the NodeBaseInterface and impl NodeBase
* refactor rclcpp to use NodeBaseInterface
* triggering a guard condition is not const
* remove unnecessary pure virtual destructor
* remove unused private member, style
* create NodeTopics interface, refactor pub/sub
* add convenience functions to fix API breaks
* fix compilation errors from NodeTopics refactor
* move "Event" based exceptions to exceptions.hpp
* add the NodeGraphInterface and related API's
* update node and graph_listener to use NodeGraph API
* initialize node_topics_ and node_graph_ in Node
* remove methods from Node and reorganize the order
the removed methods are really low level and still
available via their respective Node*Interface class
* add the NodeServices API and implementation
* add the NodeParameters API and refactor Node
* mixups
* fixup NodeParameters constructor
* added NodeTimers API and refactor Node
* make new create_publisher and create_subscription free template functions
* fixup
* fixup
* fixup
* fixup share pointer to node in any_executable
* free env value before throwing on Windows
* uncrustify and cpplint
* address constness issues
* do not store the topic name as a std::string in subscription
* fixes to support const char * topic name
* fix incomplete type specification, which fails on Windows
* refactor after rebase from type support changes
* fixup Windows build
* fix template issues on Windows
* uncrustify
* remove the unnecessary callback group argument from the add_publisher func
* remove unnecessary using = directive
* do not store node name in C++
* fix client and service creation in Node constructor
* fix include orders
* (dev) construct service from existing rcl_service_t
* (refactor) extract method for adding a service to a node
* (fix) stop mock msgs from being installed
* service takes rcl_node_t*
* correct typo
* add_service has to be public
* uncrustify
* correctly initialize service_handle
* (fix) address review comments
* (fix) pass shared pointer by value
* (fix) return to shared node handle pointer
* (fix) make find_package(rmw) required
* style
* (revert) leave c++11 flags within CXX flags
* (fix) unused variable warning
* (fix) remove unnecessary if in cmake
