* free valid_transitions for all states
transition_map->states[i].valid_transitions wasn't being release which was
leaking about 800 bytes per instantiation.
See https://github.com/aliasrobotics/RVD/issues/333
Signed-off-by: Víctor Mayoral Vilches <v.mayoralv@gmail.com>
* Fixups.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* reset error message before setting a new one, embed the original one
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* fix max line length
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* Proposola of changes for RMW_Preallocate. Related /ros2/rmw#160
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
* Changed RCL interface
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
* Updates for allocation in serialize methods.
Signed-off-by: Michael Carroll <michael@openrobotics.org>
* Fix tests for new APIs.
Signed-off-by: Michael Carroll <michael@openrobotics.org>
* Using ament_target_dependencies where possible
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
* Modified rcl_add_custom_* to use AMENT_DEPENDENCIES where possible
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
* Added again osrf_testing_tools_cpp::memory_tools library where needed.
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
* Modified with PR comment, and replaced forgotten osrf_testing_tools_cpp including
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
* Set symbol visibility to hidden for rcl
Enabling symbol visibility feature in gcc and clang compilers.
This will hep find symbol export related issues in linux and
potentially reduce compile times.
Discourse topic link:
https://discourse.ros.org/t/set-symbol-visibility-to-hidden-for-rmw-and-rcl-packages/7981
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* Remove WIN specific compiler definition in configure_rcl
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* Rename macro name rcl_set_symbol_visibility_hidden
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* Change macro to args for rcl_set_symbol_visibility_hidden
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* refactor init to not be global
Signed-off-by: William Woodall <william@osrfoundation.org>
* style changes
Signed-off-by: William Woodall <william@osrfoundation.org>
* refactor to hide use of C11 atomics in implementation
Signed-off-by: William Woodall <william@osrfoundation.org>
* fix new action tests
Signed-off-by: William Woodall <william@osrfoundation.org>
* use alternative atomic init for Windows support
* updates after rebase
Signed-off-by: William Woodall <william@osrfoundation.org>
* cleanup rmw_init_options before copying
Signed-off-by: William Woodall <william@osrfoundation.org>
* fix two bugs in new init code
* relax validity checks in a few places to facilitate post shutdown cleanup
Signed-off-by: William Woodall <william@osrfoundation.org>
* fixing tests for new API behavior
Signed-off-by: William Woodall <william@osrfoundation.org>
* to allocator -> to allocate
* acutally call rmw_shutdown() and address review comments
Signed-off-by: William Woodall <william@osrfoundation.org>
* use new error handling API from rcutils
Signed-off-by: William Woodall <william@osrfoundation.org>
* use semicolons after macros
Signed-off-by: William Woodall <william@osrfoundation.org>
* use new error handling API from rcutils
Signed-off-by: William Woodall <william@osrfoundation.org>
* minimize vertical whitespace
Signed-off-by: William Woodall <william@osrfoundation.org>
* use semicolons after macros
Signed-off-by: William Woodall <william@osrfoundation.org>
* Add semicolons to all RCLCPP and RCUTILS macros.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Add semicolons in Windows stdatomic_helper.h
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Invalid memory access for NULL dereference
rcl_lifecycle_get_state may return NULL
transition->goal is checked for NULL but no return
while it's true and this may result the follow-up
NULL dereference
Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
* Avoid crash while NULL returned from rcl_service_get_options()
Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
* tweak error string and null check for current_state
Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
