* include actual size in error message
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* use %u for existing arguments
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* Prints the node name when failing to find security directory
Also quotes directory, node_name and lookup strategy in error message for readability
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
* don't quote lookup strategy
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
* newline -> whitespace
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
* Support parameter YAML string value parsing.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Address peer review comments.
- Improve test coverage using new getter API.
- Unify function return style and improve readability.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Clean up allocations in rcl_yaml_param_parser package tests.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Make rcl_yaml_param_parser depend on rcutils only.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Address peer review comments.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Add graph test for service clients
There were tests for publishers, subscriptions, and services, but not clients.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Add function for getting clients by node
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Update service client graph test
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Fix doc sentence
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Update docs
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
test_rcl_get_publisher_names_and_types_by_node was finalizing
without calling to rcl_names_and_types_fini which was
generating a memory leak.
These lines fix the leak. Complete report in the pull request
Signed-off-by: Víctor Mayoral Vilches <v.mayoralv@gmail.com>
Similar to the warnings when remapping to invalid namespaces, this better communicates failures to the user.
Resolves#449
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Revert "Changes the default 3rd party logger from rcl_logging_noop to rcl_logging_log4cxx (#425)"
This reverts commit ac8ee90740.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Revert "add explicit dependency on rcl_logging_log4cxx (#435)"
This reverts commit 816ce67893.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Add dependency on rcl_logging_noop.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Update action graph tests to account for type namespace
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Enable OpenSplice action graph test
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Exclude some action graph tests with OpenSplice
It appears that getting graph information from finalized nodes succeeds with OpenSplice, unlike the other RMW implementations.
Since we do not have tests covering this case in rcl, it's not clear if this is a bug or expected behaviour.
In the meantime, I've disabled testing this specific case for OpenSplice.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* const bool
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* implement rcl_wait and rcl_take for rcl_event_t
Signed-off-by: Miaofei <miaofei@amazon.com>
* address feedback regarding formatting issues
Signed-off-by: Miaofei <miaofei@amazon.com>
* Remove dependency on sleep in test_events
Signed-off-by: Ross Desmond <44277324+ross-desmond@users.noreply.github.com>
* update total max wait time for setting up publisher and subscriber to 10 seconds
Signed-off-by: Miaofei <miaofei@amazon.com>
* Fix test_events for rmw_connext
Signed-off-by: Ross Desmond <44277324+ross-desmond@users.noreply.github.com>
* Refactor out timed loop from tests to function
Signed-off-by: Miaofei <miaofei@amazon.com>
* address additional feedback from pull request
Signed-off-by: Miaofei <miaofei@amazon.com>
* update comment regarding difference between connext and opensplice
Signed-off-by: Miaofei <miaofei@amazon.com>
* fix uncrustify issues
Signed-off-by: Miaofei <miaofei@amazon.com>
* update test_events for compatibility with API changes
Signed-off-by: Miaofei <miaofei@amazon.com>
* temporarily disable test_events for macOS
Signed-off-by: Miaofei <miaofei@amazon.com>
* Add return code to CancelGoal service response
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Add case for terminated goals
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Check for ERROR_NONE instead of 0
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Proposola of changes for RMW_Preallocate. Related /ros2/rmw#160
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
* Changed RCL interface
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
* Updates for allocation in serialize methods.
Signed-off-by: Michael Carroll <michael@openrobotics.org>
* Fix tests for new APIs.
Signed-off-by: Michael Carroll <michael@openrobotics.org>
