Commit graph

692 commits

Author SHA1 Message Date
Jacob Perron
f82eecafdd 1.1.4 2020-06-02 23:40:26 -07:00
Michel Hidalgo
e47042cba4
Ensure rcl_publisher_init() fails safely. (#667)
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
2020-06-01 18:44:48 -03:00
Jacob Perron
06bd93bc87 1.1.3 2020-06-01 10:46:25 -07:00
Chris Lalancette
83364247cd
Add Security Vulnerability Policy pointing to REP-2006. (#661)
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
2020-05-29 16:49:34 -04:00
brawner
9ad198ef2d
Address unused parameter warnings (#666)
Signed-off-by: Stephen Brawner <brawner@gmail.com>
2020-05-29 12:14:58 -07:00
brawner
b786cea348
Increase test coverage of rcl_action (#663)
* Add action_server validity check, and remove dead code

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Increase test coverage of rcl_action

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Reorganizing impl structs into private header

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Addressing PR Feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Addressing memory error and PR feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>

Co-authored-by: Stephen Brawner <stephenbrawner@verbsurgical.com>
2020-05-28 16:02:35 -07:00
Jorge Perez
d4927e274a
Add tests to publisher and init modules of rcl (#657)
* Add tests get_rmw_init_options & get_allocator
* Add tests liveliness, access and loan functions
* Add tests invalid arguments to get funcs
* Add peer review comments
* Fix pointer related issues
* Add test for publisher implementation null
* Add tests for valid argument on access functions
* Add more tests invalid publisher parameter
* Add rcl_reset_error to clear expected errors
* Add two init-fini tests
* Add tests for init functions
* Address peer review feedack
* Add missing fini calls
* Enable fini procedure after scope ends

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
2020-05-28 17:47:17 -03:00
Ivan Santiago Paunovic
21b5396517 1.1.2 2020-05-28 14:13:20 +00:00
Ivan Santiago Paunovic
fad0963cf1 Changelogs
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
2020-05-28 14:12:26 +00:00
Karsten Knese
0de31d0483
transition start and goal states can be null (#662)
* transition start and goal states can be null

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* correct tests

Signed-off-by: Karsten Knese <karsten@openrobotics.org>
2020-05-27 12:03:10 -07:00
Alejandro Hernández Cordero
c212a0dba4
Improved rcl docblock (#659)
* Improved rcl docblock

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
2020-05-27 08:38:44 +02:00
Jacob Perron
75e475819b 1.1.1 2020-05-26 19:30:32 -07:00
brawner
65c2d46ee0
Increase rcl_yaml_param_parser test coverage (#656)
* Cleanup and address issues in parser.c

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

squash! Cleanup and address issues in parser.c

* Increase test coverage of parser

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

* PR Fixup

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

* PR Fixup

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

Co-authored-by: Stephen Brawner <stephenbrawner@verbsurgical.com>
2020-05-26 12:45:36 -07:00
brawner
7146919c3f
Increase rcl_lifecycle test coverage and add more safety checks (#649)
* Increase test coverage and add more safety checks

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* More coverage

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Concatenating error messages

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

* PR Fixup

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

* Forgot a

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

* PR Fixup

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

* Moving var to top

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

Co-authored-by: Stephen Brawner <stephenbrawner@verbsurgical.com>
2020-05-22 14:44:11 -07:00
Ivan Santiago Paunovic
30e0536a1d 1.1.0 2020-05-22 14:46:38 +00:00
Ivan Santiago Paunovic
35944ce9cd Changelogs
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
2020-05-22 14:46:07 +00:00
Ivan Santiago Paunovic
11d3900592
Expose rcl default logging output handler (#660)
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
2020-05-22 09:43:01 -03:00
Jorge Perez
85ef95514d
Remove deprecated functions (#658)
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
2020-05-20 10:06:52 -03:00
Dirk Thomas
9fbf32d87d
warn about unused return value for set_logger_level (#652)
* warn about unused return value for set_logger_level

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* revert change of RCL_UNUSED macro

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
2020-05-15 14:29:46 -07:00
Tully Foote
51886399dd
Mark cyclonedds test_service test as flakey (#648)
This is ticketed at https://github.com/ros2/rmw_cyclonedds/issues/185

Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
2020-05-14 15:07:02 -07:00
Barry Xu
73093590e6
Convert sleep_for into appropriate logic in tests(#631)
Signed-off-by: Barry Xu <Barry.Xu@sony.com>
2020-05-14 10:36:22 -03:00
Tully Foote
6d16465318
Reduce the internal timeouts (#613)
Debugging #611 these timeouts were so long that the overall test timeout was being triggered before these internal timeouts were triggered.

1000 retries at 100ms -> 10 seconds each. I cut it down to 1 second for each to establish the connection.

Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
2020-05-13 14:27:22 -07:00
Jorge Perez
c64ca630f7
Add tests for time.c and timer.c for rcl package (#599)
* Add tests for time.c module
* Add test for function rcl_timer_clock
* Fix linter style issues
* Add test for rcl_timer_call
* Add callback test and improve call test
* Add fixture class to reuse timer init/fini code
* Change error code returned to match function being tested
* Add tests for timer_reset function
* Add tests for exchange_callback function
* Add null parameter test for get guard condition
* Add allocator testing tools auxiliar file
* Add tests for failing ini/fini conditions
* Add test for get_period function
* Add test to get_time_since_last_call
* Remove comment related to variable names
* Fix return value on test case for fini clock
* Address peer review comments
* Fix CLang warning, replacing NULL with false

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
2020-05-13 14:15:36 -03:00
brawner
7f57396fb4
Updated QDs for 1.0 (#647)
Signed-off-by: Stephen Brawner <brawner@gmail.com>
2020-05-12 17:55:21 -07:00
Jacob Perron
d3217513b1 1.0.0 2020-05-12 14:02:12 -07:00
Ivan Santiago Paunovic
87a724d32c
Remove MANUAL_BY_NODE liveliness API (#645)
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
2020-05-12 14:52:19 -03:00
Ivan Santiago Paunovic
3f443e36a1
Make test_two_timers* more reliable (#640)
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
2020-05-11 14:44:15 -04:00
Chris Lalancette
cec60fb831 0.9.1 2020-05-08 15:18:17 +00:00
Chris Lalancette
752a8511f2 Changelog.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
2020-05-08 15:18:05 +00:00
Alejandro Hernández Cordero
0f0424fe7f
Included features (#644)
* Included features

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* fix on rcl_yaml_param_parser doxygen

Signed-off-by: ahcorde <ahcorde@gmail.com>
2020-05-08 08:48:03 +02:00
brawner
728b8b89bd
Quality Declarations for rcl_action, rcl_lifecycle, yaml_parser (#641)
* READMEs and Quality Declarations for rcl_action, rcl_lifecycle, yaml_parser

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>
2020-05-07 09:35:41 +02:00
Jorge Perez
2c655edb39
Current state Quality Declaration (#639)
* initial draft of the quality declaration
* Reformat to match REP-2004 template
* Fix README.md files accordingly for the rcl package
* Fix minor typos
* Fix minor issues according to peer review
* Address peer review comments
* Improve current state Feature documentation

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Co-authored-by: William Woodall <william@osrfoundation.org>
2020-05-05 18:09:38 -03:00
Ingo Lütkebohle
1eee2f2515
Initialize service timestamps to 0 and test. (#642)
Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>
2020-05-05 09:48:27 -03:00
Jacob Perron
47501d17c5 0.9.0 2020-04-29 09:41:48 -07:00
Alejandro Hernández Cordero
7a3599db7d
Added rcl_lifecycle Doxyfile (#633)
* Added rcl lifecycle Doxyfile

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed Doxyfile

Signed-off-by: ahcorde <ahcorde@gmail.com>
2020-04-29 12:23:14 +02:00
Alejandro Hernández Cordero
0d27a03a4f
added rcl yaml param parser doxyfile (#634)
* Added rcl yaml param parser Doxyfile

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed predefined tag

Signed-off-by: ahcorde <ahcorde@gmail.com>
2020-04-29 09:17:30 +02:00
Alejandro Hernández Cordero
9ade5a114d
Fixed rcl_yaml_param_parser package description (#637)
Signed-off-by: ahcorde <ahcorde@gmail.com>
2020-04-28 20:26:02 +02:00
Michel Hidalgo
f5702e41a2
Fix std::string construction. (#636)
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
2020-04-27 17:34:17 -03:00
Dirk Thomas
2f76cdc9e4
export targets in a addition to include directories / libraries (#635)
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
2020-04-27 10:30:30 -07:00
Alejandro Hernández Cordero
e00b4b8d2a
Added documentation to rcl_lifecycle (#622)
* Added documentation to rcl_lifecycle

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Adding more documentation to rcl_lifecycle

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Update rcl_lifecycle/include/rcl_lifecycle/default_state_machine.h

Co-Authored-By: Jorge Perez <jjperez@ekumenlabs.com>

Update rcl_lifecycle/include/rcl_lifecycle/default_state_machine.h

Co-Authored-By: Jorge Perez <jjperez@ekumenlabs.com>

Update rcl_lifecycle/include/rcl_lifecycle/transition_map.h

Co-Authored-By: Jorge Perez <jjperez@ekumenlabs.com>

Update rcl_lifecycle/include/rcl_lifecycle/rcl_lifecycle.h

Co-Authored-By: Jorge Perez <jjperez@ekumenlabs.com>

Update rcl_lifecycle/include/rcl_lifecycle/transition_map.h

Co-Authored-By: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added more feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed uncrustify

Signed-off-by: ahcorde <ahcorde@gmail.com>

Co-authored-by: Jorge Perez <jjperez@ekumenlabs.com>
2020-04-27 19:26:32 +02:00
Jorge Perez
65feb5c725
Add basic functionality tests for validate_enclave_name and subscription (#624)
* Add tests for the test_validate_enclave_name module
* Add test that is failing
* Add test that is failing
* Fix function used for publishing
* Fix function used for publishing
* Fix serialize subscription test
* Fix serialize subscription test
* Add tests for loan msgs and get_options
* Add tests for loan msgs and get_options
* Add support for taking a sequence of messages (#614)
* Add support for taking a sequence of messages
* Fix uncrustify
* Apply suggestions from code review
* Address reviewer feedback.
* Remove vertical whitespace
* Address reviewer feedback
* Remove blank line
* Remove extra character left when rebasing
* Remove test used for debugging
* Remove repeated tests
* Add test for get_options
* Fix uncrustify errors

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
2020-04-24 18:28:34 -03:00
Jorge Perez
015f05e1dc
Save allocator for RCL_CLOCK_UNINITIALIZED clock. (#623)
* Save allocator when setting uninitialized clock
* Add tests for clock types init/fini
* Remove extra calls to set clock allocator
* Remove tests not related to this PR
* Replace test to make it clearer what is tested in the PR

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
2020-04-24 12:50:42 -03:00
Ingo Lütkebohle
f18127a089
Implement service info structure with timestamps. (#627)
* Adapt to using rmw_service_info_t

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Provide backwards compatibility.

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Add service test

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* minimize whitespace

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

Co-authored-by: Karsten Knese <karsten@openrobotics.org>
2020-04-23 21:31:07 -07:00
Michael Carroll
84cac5937b
Add support for taking a sequence of messages (#614)
* Add support for taking a sequence of messages

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Fix uncrustify

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Apply suggestions from code review

Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Address reviewer feedback.

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Remove vertical whitespace

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Address reviewer feedback

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Remove blank line

Signed-off-by: Michael Carroll <michael@openrobotics.org>

Co-authored-by: Jacob Perron <jacob@openrobotics.org>
2020-04-23 19:13:59 -05:00
Ingo Lütkebohle
643f6ec530
Message info with timestamps support in rcl (#619)
* Zero-initialize message_info prior to taking

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Added test for timestamp presence

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* move message_info test to a new test file

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Add conditional timestamp test to normal subscriber test

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Remove dedicated timestamp test

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Use rmw_time_point_value_t instead of rmw_time_t

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Use rcutils for cross-platform compatibility.

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Style fix.

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* More style fix.

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* test fastrtps_dynamic properly; also cmake linter error

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Expect timestamps on cyclonedds as well

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Distinguish received timestamp support.

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>
2020-04-23 14:28:58 -07:00
Dirk Thomas
b343368840
export targets in a addition to include directories / libraries (#632)
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
2020-04-23 14:18:55 -07:00
Ivan Santiago Paunovic
8a0ec5fe95
Don't call rcl_logging_configure/rcl_logging_fini in rcl_init/rcl_shutdown (#579)
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
2020-04-23 17:33:32 -03:00
Dirk Thomas
3d1337d0fc
fix usage to not expose underlying yaml (#630)
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
2020-04-22 15:14:47 -07:00
Dirk Thomas
0a48e6bd7b
export targets in a addition to include directories / libraries (#629)
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
2020-04-22 08:36:38 -07:00
Alejandro Hernández Cordero
4f0406f754
Fixed argument name in rcl_lifecycle.h (#626)
Signed-off-by: ahcorde <ahcorde@gmail.com>
2020-04-22 09:21:03 +02:00