niklas/rcl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
653 commits 1 branch 0 tags 2.4 MiB
Commit graph

653 commits

This branch
This branch
All branches
Author SHA1 Message Date
Alejandro Hernández Cordero
e00b4b8d2a
Added documentation to rcl_lifecycle (#622) 
* Added documentation to rcl_lifecycle

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Adding more documentation to rcl_lifecycle

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Update rcl_lifecycle/include/rcl_lifecycle/default_state_machine.h

Co-Authored-By: Jorge Perez <jjperez@ekumenlabs.com>

Update rcl_lifecycle/include/rcl_lifecycle/default_state_machine.h

Co-Authored-By: Jorge Perez <jjperez@ekumenlabs.com>

Update rcl_lifecycle/include/rcl_lifecycle/transition_map.h

Co-Authored-By: Jorge Perez <jjperez@ekumenlabs.com>

Update rcl_lifecycle/include/rcl_lifecycle/rcl_lifecycle.h

Co-Authored-By: Jorge Perez <jjperez@ekumenlabs.com>

Update rcl_lifecycle/include/rcl_lifecycle/transition_map.h

Co-Authored-By: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added more feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed uncrustify

Signed-off-by: ahcorde <ahcorde@gmail.com>

Co-authored-by: Jorge Perez <jjperez@ekumenlabs.com>
 2020-04-27 19:26:32 +02:00
Jorge Perez
65feb5c725
Add basic functionality tests for validate_enclave_name and subscription (#624) 
* Add tests for the test_validate_enclave_name module
* Add test that is failing
* Add test that is failing
* Fix function used for publishing
* Fix function used for publishing
* Fix serialize subscription test
* Fix serialize subscription test
* Add tests for loan msgs and get_options
* Add tests for loan msgs and get_options
* Add support for taking a sequence of messages (#614)
* Add support for taking a sequence of messages
* Fix uncrustify
* Apply suggestions from code review
* Address reviewer feedback.
* Remove vertical whitespace
* Address reviewer feedback
* Remove blank line
* Remove extra character left when rebasing
* Remove test used for debugging
* Remove repeated tests
* Add test for get_options
* Fix uncrustify errors

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
 2020-04-24 18:28:34 -03:00
Jorge Perez
015f05e1dc
Save allocator for RCL_CLOCK_UNINITIALIZED clock. (#623) 
* Save allocator when setting uninitialized clock
* Add tests for clock types init/fini
* Remove extra calls to set clock allocator
* Remove tests not related to this PR
* Replace test to make it clearer what is tested in the PR

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
 2020-04-24 12:50:42 -03:00
Ingo Lütkebohle
f18127a089
Implement service info structure with timestamps. (#627) 
* Adapt to using rmw_service_info_t

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Provide backwards compatibility.

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Add service test

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* minimize whitespace

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

Co-authored-by: Karsten Knese <karsten@openrobotics.org>
 2020-04-23 21:31:07 -07:00
Michael Carroll
84cac5937b
Add support for taking a sequence of messages (#614) 
* Add support for taking a sequence of messages

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Fix uncrustify

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Apply suggestions from code review

Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Address reviewer feedback.

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Remove vertical whitespace

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Address reviewer feedback

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Remove blank line

Signed-off-by: Michael Carroll <michael@openrobotics.org>

Co-authored-by: Jacob Perron <jacob@openrobotics.org>
 2020-04-23 19:13:59 -05:00
Ingo Lütkebohle
643f6ec530
Message info with timestamps support in rcl (#619) 
* Zero-initialize message_info prior to taking

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Added test for timestamp presence

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* move message_info test to a new test file

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Add conditional timestamp test to normal subscriber test

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Remove dedicated timestamp test

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Use rmw_time_point_value_t instead of rmw_time_t

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Use rcutils for cross-platform compatibility.

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Style fix.

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* More style fix.

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* test fastrtps_dynamic properly; also cmake linter error

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Expect timestamps on cyclonedds as well

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>

* Distinguish received timestamp support.

Signed-off-by: Luetkebohle Ingo (CR/AEX3) <ingo.luetkebohle@de.bosch.com>
 2020-04-23 14:28:58 -07:00
Dirk Thomas
b343368840
export targets in a addition to include directories / libraries (#632) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-04-23 14:18:55 -07:00
Ivan Santiago Paunovic
8a0ec5fe95
Don't call rcl_logging_configure/rcl_logging_fini in rcl_init/rcl_shutdown (#579) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-04-23 17:33:32 -03:00
Dirk Thomas
3d1337d0fc
fix usage to not expose underlying yaml (#630) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-04-22 15:14:47 -07:00
Dirk Thomas
0a48e6bd7b
export targets in a addition to include directories / libraries (#629) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-04-22 08:36:38 -07:00
Alejandro Hernández Cordero
4f0406f754
Fixed argument name in rcl_lifecycle.h (#626) 
Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-04-22 09:21:03 +02:00
Shane Loretz
40f6a63310
Doc rcl_pub/etc_fini() must come before rcl_node_fini() (#625) 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
 2020-04-20 20:34:01 -07:00
Dirk Thomas
0a795cc776
export targets in a addition to include directories / libraries (#621) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-04-20 09:33:04 -07:00
Dirk Thomas
918dd5a4d3
remove usage of undefined CMake variable (#620) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-04-17 12:48:32 -07:00
Ruffin
1a74f8fa5d
Update security environment variables (#617) 
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
Co-authored-by: Mikael Arguedas <mikael.arguedas@gmail.com>
 2020-04-16 13:19:42 -03:00
Jorge Perez
b714f41aca
Add visibility to rcl_timer_get_allocator (#610) 
* Add RCL_PUBLIC to be able of using the function externally
* Add fixture to setup timers before testing them
* Add test for rcl_timer_get_allocator function
* Add minor style changes

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
 2020-04-14 11:10:05 -03:00
y-okumura-isp
3142616db4
Fix test_publisher memory leaks reported by asan (#567) 
* Fix memory leak in test_publisher, test msg not released (#469)

Signed-off-by: y-okumura-isp <y-okumura@isp.co.jp>

* Fix memory leak in test_publisher, not fini publisher (#469)

Signed-off-by: y-okumura-isp <y-okumura@isp.co.jp>
 2020-04-13 13:31:19 -07:00
Mikael Arguedas
ccb4ec7a71
security-context -> enclave (#612) 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
 2020-04-13 10:30:29 -03:00
Dirk Thomas
94b5a1d7d0
rename rosidl_generator_c namespace to rosidl_runtime_c (#616) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-04-10 21:58:19 -07:00
Dirk Thomas
88fd4b0313
rename rosidl_generator_cpp namespace to rosidl_runtime_cpp (#615) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-04-10 15:55:20 -07:00
Ivan Santiago Paunovic
03f53f7098
Fix security directory lookup for '/' security contexts (#609) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-04-10 11:08:46 -03:00
Alejandro Hernández Cordero
08e0c715c5
Changed rosidl_generator_c/cpp to rosidl_runtime_c/cpp (#588) 
* Changed rosidl_generator_c/cpp to rosidl_runtime_c/cpp

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed rcl rcl_runtime_c dependency

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed rcl_action rcl_runtime_c dependency

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed rcl_lifecycle rcl_runtime_c dependency

Signed-off-by: ahcorde <ahcorde@gmail.com>

* keep the originally used dependency type

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-04-10 12:25:26 +02:00
Jacob Perron
730bb0ee4f
Remove deprecated CLI rules (#603) 
* Remove deprecated CLI rules

Resolves #500

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Remove tests for deprecated CLI arguments

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2020-04-09 22:16:17 -07:00
Ivan Santiago Paunovic
6ca6545933
Use keystore root as security root directory, and not contexts folder (#607) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-04-09 13:44:45 -03:00
Mikael Arguedas
4a7ba0232c
remove tinydir_vendor dependency (#608) 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
 2020-04-07 18:10:41 -03:00
Jorge Perez
00aaea7330
Add missing allocator check for NULL (#606) 
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
 2020-04-07 16:50:03 -03:00
Jorge Perez
3eda4b9543
Change naming style for private functions (#597) 
* Add prefix "_" underscore missing in private functions

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>

* Change style for functions internal to module

Removed underscores
Added static keyword

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
 2020-04-03 19:02:34 -03:00
Ivan Santiago Paunovic
72ecb5ff43
Switch to one Participant per Context (#515) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-04-03 10:15:00 -03:00
Jaison Titus
73948da4c5
Support for ON_REQUESTED_INCOMPATIBLE_QOS and ON_OFFERED_INCOMPATIBLE_QOS events (#535) 
Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
Co-authored-by: Miaofei <miaofei@amazon.com>
 2020-03-27 09:25:42 -03:00
Chris Lalancette
c416feb681
Small typo fix. (#604) 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-03-25 13:59:23 -04:00
Miaofei Mei
d45503839e
update docstring with new possible return code (#600) 
Signed-off-by: Miaofei <miaofei@amazon.com>
 2020-03-19 17:15:59 -03:00
Ivan Santiago Paunovic
43a4e65514
Add missing node destruction (#601) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-03-18 14:27:55 -03:00
Dan Rose
00f3acc8d1
Test that nodes are returned with correct multiplicity (#598) 
Signed-off-by: Dan Rose <dan@digilabs.io>
 2020-03-13 15:20:43 -03:00
DongheeYe
069d1f0729
Trigger guard condition when timer is reset (#589) 
Signed-off-by: Donghee Ye <donghee.ye@samsung.com>
 2020-03-13 14:23:49 -03:00
Michel Hidalgo
b463168528
Clock API improvements (#580) 
* Improve rcl clock API documentation.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

* Improve rcl clock API error checking.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

* Address peer review comments.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

* Refine rcl_clock_t API thread-safety documentation.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-03-13 10:05:54 -03:00
y-okumura-isp
85948c7c3c
Rcl issues 469 test arguments (#564) 
* `rcl_arguments_fini` free external_log_config_file (#469)

* Fix memory leak in `parse_key` in parser.c

Signed-off-by: y-okumura-isp <y-okumura@isp.co.jp>
 2020-03-12 10:12:30 -04:00
Dan Rose
4835a947a5
Don't check history depth if RMW_QOS_POLICY_HISTORY_KEEP_ALL (#593) 
Signed-off-by: Dan Rose <dan@digilabs.io>
 2020-03-11 17:20:09 -03:00
y-okumura-isp
ec43777891
Fix alloc-dealloc-mismatch(new->free) in test_info_by_topic (#469) (#569) 
Signed-off-by: y-okumura-isp <y-okumura@isp.co.jp>
 2020-03-09 09:20:34 -07:00
Ivan Santiago Paunovic
40ba55bc17
Use 10sec lifespan in rosout publisher qos (#587) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-03-04 09:31:02 -03:00
Alejandro Hernández Cordero
f8f8b41b7d
[rcl lifecycle] removed rmw_implementation from package.xml (#575) 
* fixed package.xml

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

* removed rosidl_generator_c dependency

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

* rcl lifecycle restoring rosidl_generator_c dependency

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
 2020-03-03 20:28:03 +01:00
Jacob Perron
ca64525029
Document clock types (#578) 
Resolves #552

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2020-03-02 22:20:58 +01:00
Dirk Thomas
74a1e7f228
make rosout publisher transient local with a depth of 1000 (#582) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-02-28 13:38:49 -08:00
Alejandro Hernández Cordero
4dbf20d447
Merge pull request #577 from ros2/ahcorde/package/rcl_action_depend 
[rcl_action] changed build_depend and build_depend_export dependencies to depend
 2020-02-28 18:21:51 +01:00
Miaofei Mei
b6977cc226
Enable TestInfoByTopicFixture unit tests for other rmw_implementations (#583) 
Signed-off-by: Miaofei <miaofei@amazon.com>
 2020-02-27 14:29:23 -03:00
y-okumura-isp
25f39c3a48
Fix memory leak in test_subscription_nominal (#469) (#562) 
Narrow scope of subscription to prevent leak and separate nominal test from init/fini test.

Signed-off-by: y-okumura-isp <y-okumura@isp.co.jp>
 2020-02-24 17:42:49 +01:00
Ivan Santiago Paunovic
2563332dc3
Update rmw_topic_endpoint_info_array usage (#576) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-02-20 14:11:05 -03:00
ahcorde
4cd2df005e changed build_depend and build_depend_export dependencies to depend 
Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-02-18 11:38:01 +01:00
Miaofei Mei
87167e3ce1
add rcl versions of rmw_topic_endpoint_info* types (#558) 
Signed-off-by: Miaofei <miaofei@amazon.com>
 2020-02-14 13:35:57 -08:00
Dennis Potman
c601464fca
Enable test for rcl_get_subscriptions_info_by_topic / rcl_get_publishers_info_by_topic for Cyclone (#572) 
Signed-off-by: Dennis Potman <dennis.potman@adlinktech.com>
 2020-02-10 14:59:21 -03:00
Dennis Potman
41f4fba966
Test_rcl_get_publishers_subscription_info_by_topic: fixed missing initialization and fixed qos checking (#571) 
Signed-off-by: Dennis Potman <dennis.potman@adlinktech.com>
 2020-02-10 11:16:49 -03:00