niklas/rcl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
661 commits 1 branch 0 tags 2.4 MiB
Commit graph

661 commits

This branch
This branch
All branches
Author SHA1 Message Date
Jacob Perron
d86d1c4135 Refactor actions wait set functions to leverage new wait set API 2018-11-20 10:04:49 -08:00
Jacob Perron
87d41f0808 [rcl] Output index in container when adding an entity to a wait set 
This feature is useful when different libraries interact with the same wait set (e.g. rcl_action).
 2018-11-20 10:04:49 -08:00
Steven! Ragnarök
b2177b2281 0.6.0 2018-11-19 06:22:36 -08:00
Michel Hidalgo
e59c14638d
Merge pull request #329 from ros2/hidmic/fix-empty-action-name 
Makes rcl_action_get_*_name() functions check for empty action names.
 2018-11-16 16:11:28 -03:00
Michel Hidalgo
f256da0a86
Merge pull request #319 from ros2/hidmic/action-client-implementation 
Action client implementation
 2018-11-15 13:42:08 -03:00
Michel Hidalgo
276aed1dff [rcl action] Addresses peer review comments (#329) 2018-11-14 19:33:21 -03:00
Michel Hidalgo
d77c9b6965 [rcl action] Makes rcl_action_get_*_name() functions check for empty action names. 2018-11-14 17:27:17 -03:00
Michel Hidalgo
c7e61834b4 [rcl action] Use macros instead of static function for action client impl. 2018-11-14 16:56:05 -03:00
Michel Hidalgo
78168bb52a [rcl action] Removes duplicate typedef in action_client header. 2018-11-14 15:54:32 -03:00
Ruffin
a2546fa0b0
Expand node_secure_root using local_namespace (#300) 
* Expand node_secure_root using local_namespace

* rcutils_normalize_path -> rcutils_to_native_path

* correct comments and docblock

* node_root_norm -> node_root_path

* normalized -> native

* Adding TODOs for function reuse

* Adding Null check node_secure_root

* Adding override for ROS_SECURITY_NODE_DIRECTORY
Addressing https://github.com/ros2/sros2/issues/69

* Change from strcpy to memcpy

Signed-off-by: Ruffin White <roxfoxpox@gmail.org>
 2018-11-13 14:13:24 -08:00
Jacob Perron
8b00791a56
[rcl_action] Add function to check if goal can be transitioned to CANCELING (#325) 
* [rcl_action] Add function for checking if goal can be transitioned to CANCELING

Add unit tests for the new function rcl_action_goal_handle_is_cancelable(), as well as rcl_action_goal_handle_is_active().
 2018-11-13 11:55:28 -08:00
Michel Hidalgo
629403e29d [rcl action] Fixes bad assertion in test_action_client. 2018-11-13 14:12:00 -03:00
Michel Hidalgo
f2afddc910 [rcl action] Cleanup CMake code for test_action_client. 2018-11-13 12:03:05 -03:00
Michel Hidalgo
0c31382165 [rcl action] Addresses peer review comments (#319). 
* Remove redundant null check for given rcl_node_t pointer.
* Always deallocate rcl_action_client_t pimpl on finalization.
* Minor formatting fixes.
 2018-11-13 10:53:04 -03:00
Michel Hidalgo
7efd1a15ae [rcl action] Adds action client tests. 2018-11-12 14:26:42 -03:00
Michel Hidalgo
cca18daad2 [rcl action] Fixes after changes introduced by (#310) 2018-11-12 13:59:50 -03:00
Michel Hidalgo
e2ee3c5475 [rcl action] Wait set support for action clients (restrictive). 2018-11-12 13:59:50 -03:00
Michel Hidalgo
89563623f7 [rcl action] Refactors action client error checking. 2018-11-12 13:59:50 -03:00
Michel Hidalgo
d1c3990f5d Addresses peer review comments (#319) 2018-11-12 13:59:50 -03:00
Michel Hidalgo
16205873ea [rcl action] Action client first implementation. 2018-11-12 13:59:47 -03:00
William Woodall
9351fd89c7
Move stdatomic helper to rcutils (#324) 
* move stdatomic_helper* to rcutils

Signed-off-by: William Woodall <william@osrfoundation.org>

* refactor after moving stdatomic_helper.h to rcutils

Signed-off-by: William Woodall <william@osrfoundation.org>
 2018-11-08 16:15:43 -06:00
Jacob Perron
5d12f54d13
Add subfolder argument to the ROSIDL_GET_SRV_TYPE_SUPPORT macro (#322) 2018-11-08 09:49:21 -08:00
Jacob Perron
e6985c0226 [rcl] Return appropriate error code when there is a bad allocation 2018-11-06 14:15:04 -08:00
Jacob Perron
48c168a5ca [rcl] Remove redundant error checking and set explicit error message with '_is_valid' functions 2018-11-06 14:15:04 -08:00
Jacob Perron
b2578bbbda
[rcl_action] Implement goal handle (#320) 
* Add action goal handle implementation and unit tests
* Add check to goal state machine transition function for index out of bounds
 2018-11-06 10:28:06 -08:00
Jacob Perron
1120b2f6a4 [rcl_action] Remove unnecessary 'target_link_libraries' macro 2018-11-02 12:41:13 -07:00
Jacob Perron
88eaa3a926 [rcl_action] Store allocator used for message initialization in the message struct 
This relieves the user from providing the correct allocator when finalizing messages.
 2018-11-02 12:41:13 -07:00
Jacob Perron
e64fcaf5a8 [rcl_action] Bugfix: check if number of elements to allocate for message is greater than zero 2018-11-02 12:41:13 -07:00
William Woodall
4d8cb487f8
use new error handling API from rcutils (#314) 
* use new error handling API from rcutils

Signed-off-by: William Woodall <william@osrfoundation.org>

* use semicolons after macros

Signed-off-by: William Woodall <william@osrfoundation.org>

* use new error handling API from rcutils

Signed-off-by: William Woodall <william@osrfoundation.org>

* minimize vertical whitespace

Signed-off-by: William Woodall <william@osrfoundation.org>

* use semicolons after macros

Signed-off-by: William Woodall <william@osrfoundation.org>
 2018-11-01 21:08:31 -05:00
Michel Hidalgo
765de78140
Merge pull request #317 from ros2/hidmic/action-names 
Add action services and topics name getters
 2018-11-01 16:43:06 -03:00
Michel Hidalgo
55d83f27d7 [rcl action] Addresses peer review comments (#317) 2018-11-01 10:55:52 -03:00
Michel Hidalgo
8b65abeed5 [rcl action] Add action services and topics name getters 2018-11-01 10:54:36 -03:00
Karsten Knese
77ef88a4f6
delete TRANSITION_SHUTDOWN (#313) 2018-10-31 19:19:45 -07:00
Jacob Perron
f9dfc5ddd1
[rcl_action] Implement init/fini functions for types (#312) 
* Refactored API. Removed init/fini functions for types that do not necessarily need allocation on the heap.
* Added unit tests for implementation.
 2018-10-31 13:36:48 -07:00
Jacob Perron
29e7dbe156
Refactor goal state machine implementation and add unit tests (#311) 
* Fix buggy if-conditions in transition functions.
* Bugfix: incease number of states by one
* Cleanup CMakeLists.txt and package.xml
* Move goal state machine implementation details from header to C file
 2018-10-30 16:15:10 -07:00
Jacob Perron
2c0e35d9d1
[rcl_action] Add missing visibilty control definitions (#315) 2018-10-30 10:39:02 -07:00
Jacob Perron
451bf4a1a4
Add rcl_action package and headers (#307) 
* Create rcl_action package with proposed headers for:
  - Action client
  - Action server
  - Goal handle
  - Goal state machine
  - Types

* Add rcl_action.h and Doxyfile

* Add functions for adding action clients and action servers to a wait set

* Add default QoS profile for status topic and document default options for action clients/servers

* Include all headers in a .c file for testing compilation
 2018-10-26 15:55:13 -07:00
Karsten Knese
5e3d4be720
Lifecycle refactor (#298) 
* no static initialization of states anymore

* make transition labels more descriptive

* introduce labeled keys

* define default transition keys

* fix memory management

* introduce service for transition graph

* export transition keys

* remove keys, transition id unique, label ambiguous

* semicolon for macro call
 2018-10-11 14:03:41 -07:00
Jacob Perron
9d4b1c9912
Minor doc fixes (#305) 2018-10-08 18:50:24 -07:00
Chris Lalancette
3d0e2b7966
Add macro semicolons (#303) 
* Add semicolons to all RCLCPP and RCUTILS macros.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Add semicolons in Windows stdatomic_helper.h

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2018-10-05 17:30:27 -04:00
dhood
f1293b7d3b
[yaml parser] Fix FQN=//node_name when ns is / (#299) 
* Fix FQN=//node_name when ns is /

* Check end of string for ns sep

* Add regression test
 2018-09-21 14:50:48 -07:00
Shane Loretz
0a6d9186e8
Rcl timer with ros time (#286) 
* rcl_wait() on timers with ROS clock

Timers handle time jump callbacks
rcl_wait() wakes when ros time gets a time after timer's next call time

* Set timer impl to NULL after fini
 2018-09-13 09:28:12 -07:00
William Woodall
e5e338a8e0
typo (#297) 2018-09-11 17:39:39 -07:00
Dirk Thomas
a0f83b071a
ensure that timer period is non-negative (#295) 2018-09-06 18:36:28 -07:00
Dirk Thomas
16adb1e4f6
fix calculation of next timer call (#291) 
* fix calculation of next timer call

* fix logic for period zero
 2018-09-06 17:41:51 -07:00
Shane Loretz
e78e400018
Null deallocated jump callbacks (#294) 
* Add failing test for add-remove-add callback

* Fix crash when adding callback after last was removed
 2018-09-06 14:06:45 -07:00
Michael Carroll
f93072b1b8
Include namespaces in get_node_names. (#287) 2018-09-06 08:04:41 -05:00
Dirk Thomas
0e772b237e
fix naming of configure_error transition (#292) 2018-09-05 13:08:30 -07:00
William Woodall
7289d4a00a
Doc fixups (#288) 
* remove vestigial parameter documentation

* fix parameter name typo

* small fixup
 2018-08-31 18:32:27 -07:00
Shane Loretz
955c0c93da
Check if pointers are null before calling memset (#290) 2018-08-31 15:31:53 -07:00