* Fix occasionally missing goal result caused by race condition
Signed-off-by: Kaven Yau <kavenyau@foxmail.com>
* Take action_server_reentrant_mutex_ out of the sending result loop
Signed-off-by: Kaven Yau <kavenyau@foxmail.com>
* add note for explaining the current locking order in server.cpp
Signed-off-by: Kaven Yau <kavenyau@foxmail.com>
Co-authored-by: Kaven Yau <kavenyau@foxmail.com>
Backports #1516 and follow-up fix#1628
Patched to keep ABI compatibility by using static class variables to store the mutex two priorities instances.
Signed-off-by: hsgwa <hasegawa@isp.co.jp>
* Add missing locking to the rclcpp_action::ServerBase. (#1421)
This patch actually does 4 related things:
1. Renames the recursive mutex in the ServerBaseImpl class
to action_server_reentrant_mutex_, which makes it a lot
clearer what it is meant to lock.
2. Adds some additional error checking where checks were missed.
3. Adds a lock to publish_status so that the action_server
structure is protected.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* [backport] Fix action server deadlock (#1285, #1313)
Signed-off-by: Daisuke Sato <daisukes@cmu.edu>
* revert comment
Signed-off-by: Daisuke Sato <daisukes@cmu.edu>
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
* Reserve vector capacities and use emplace_back for constructing vectors
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Use resize instead of reserve
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Remove push_back
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Co-authored-by: brawner <brawner@gmail.com>
* Change uint8_t iterator variables to size_t
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Change to unsigned int
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Co-authored-by: brawner <brawner@gmail.com>
Note that these tests are written without using
performance_test_fixture. Because the parameter server is running in the
same process, any allocations happening in the spin thread for the
server get picked up by the allocation statistics even though those
functions aren't invoked in the tests.
If we can find a way to turn off the memory tracking on a per-thread
basis, we can enable memory tracking. Until then, leaving the memory
statistics enabled could be misleading.
Cherry-picked from f5e35bda86c1d95cf0296bb4f756d3bb63781d97
Signed-off-by: Scott K Logan <logans@cottsay.net>
* Fix NodeOptions copy constructor (#1376)
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
* Remove rosout_qos assignment
Not applicable in Foxy.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
* increase test timeout necessary for Connext
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* revert changes overlapping with another PR
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* Add service and client benchmarks
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Style
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Uncrustify
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Set CMakeLists to only use default rmw for benchmarks
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Add comment
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Refactor test CMakeLists in prep for benchmarks (#1422)
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Address #1423 by moving rosidl_generate_interfaces call (#1424)
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Remove rolling-only tests
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Increase test coverage of rclcpp_lifecycle to 96%
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* PR Fixup
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* test_depend
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* rcutils test_depend
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* More windows warnings
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Increase coverage rclcpp_action to 95%
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* PR fixup
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Address PR Feedback
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Rebase onto #1311
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* rcutils test depend
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Cleaning up
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Clear members for StaticExecutorEntitiesCollector to avoid shared_ptr dependency
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Increase test timeouts of slow running tests with rmw_connext_cpp
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Fix other issues with connext
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Add unit tests for qos and qos_event files
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* PR Feedback
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Address PR Feedback
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Fix windows CI
Signed-off-by: Stephen Brawner <brawner@gmail.com>
