As documented in rcl_action, a return code of RCL_RET_ACTION_CLIENT_TAKE_FAILED does not mean that
an error occurred.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* add mechanism to pass rmw impl specific payloads during pub/sub creation
Signed-off-by: William Woodall <william@osrfoundation.org>
* use class instead of struct
Signed-off-by: William Woodall <william@osrfoundation.org>
* narrow API of rmw payload to just use rmw_*_options_t's
Signed-off-by: William Woodall <william@osrfoundation.org>
* fixup after recent change
Signed-off-by: William Woodall <william@osrfoundation.org>
* make get_actual_qos return a rclcpp::QoS
Signed-off-by: William Woodall <william@osrfoundation.org>
* make simpler following suggestion from review
Signed-off-by: William Woodall <william@osrfoundation.org>
* streamline creation of publishers after removing deprecated API
Signed-off-by: William Woodall <william@osrfoundation.org>
* use deduced template arguments to cleanup create_subscription
Signed-off-by: William Woodall <william@osrfoundation.org>
* add missing file
Signed-off-by: William Woodall <william@osrfoundation.org>
* streamline creation of subscriptions after removing deprecated API
Signed-off-by: William Woodall <william@osrfoundation.org>
* small subscription code cleanup to match publisher's style
Signed-off-by: William Woodall <william@osrfoundation.org>
* some fixes to rclcpp_lifecycle to match rclcpp
Signed-off-by: William Woodall <william@osrfoundation.org>
* add README to the rclcpp/detail include directory
Signed-off-by: William Woodall <william@osrfoundation.org>
* fixup SubscriptionBase's use of visibility macros
Signed-off-by: William Woodall <william@osrfoundation.org>
* reapply function to create default options, as it is still needed on Windows
Signed-off-by: William Woodall <william@osrfoundation.org>
* address review comments
Signed-off-by: William Woodall <william@osrfoundation.org>
* workaround cppcheck 1.89 syntax error
Signed-off-by: William Woodall <william@osrfoundation.org>
* Take parameter overrides provided through the CLI.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Address peer review comments.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Do not 'find_package' rcpputils twice.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* add more context to exception message
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* fix linter warnings
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* Fail on invalid and unknown ROS specific arguments.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Revert changes to utilities.hpp in rclcpp
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Fully revert change to utilities.hpp
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
This fixes a runtime error caused by a race condition when making consecutive requests for the
result.
Specifically, this happens if the user provides a result callback when sending a goal and then
calls async_get_result shortly after.
Resolves#783
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Use --ros-args to deal with node arguments in rclcpp.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Document implicit --ros-args flag in NodeOptions::arguments().
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Add missing size_t to int cast.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Only add implicit --ros-args flag if not present already.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Add some rclcpp::NodeOptions test coverage.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Address peer review comments.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Please cpplint and uncrustify.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Add line break after first open paren in multiline function call
as per developer guide:
https://index.ros.org/doc/ros2/Contributing/Developer-Guide/#open-versus-cuddled-braces
see https://github.com/ament/ament_lint/pull/148
Signed-off-by: Dan Rose <dan@digilabs.io>
Fix dedent when first function argument starts with a brace
Signed-off-by: Dan Rose <dan@digilabs.io>
Line break with multiline if condition
Remove line breaks where allowed.
Signed-off-by: Dan Rose <dan@digilabs.io>
Fixup after rebase
Signed-off-by: Dan Rose <dan@digilabs.io>
Fixup again after reverting indent_paren_open_brace
Signed-off-by: Dan Rose <dan@digilabs.io>
* Revert comment spacing change, condense some lines
Signed-off-by: Dan Rose <dan@digilabs.io>
* Switch the NodeParameters lock to recursive.
This is so that the on_set_parameter_callback can successfully
call other parameter methods (like get_parameter) without
deadlocking.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Make sure that modifications can't happen within a callback.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Review fixes.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Set parameter_modification_enabled_ in calls that make modifications.
This will prevent any modification from within modification,
which is a good thing.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Fix windows errors.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Switch to an RAII-style recursion guard.
Also update the documentation.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Adding a factory method to create a Duration from seconds
There are many places in the ROS codebase where a time duration is
specified as a floating point number of seconds. A factory function
to create a Duration object from these values makes the code a
bit simpler in many cases.
Signed-off-by: Carl Delsey <carl.r.delsey@intel.com>
* Adding some comments to clarify which constructors get matched.
Signed-off-by: Carl Delsey <carl.r.delsey@intel.com>
