* Using ament_target_dependencies where possible
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
* Modified rcl_add_custom_* to use AMENT_DEPENDENCIES where possible
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
* Added again osrf_testing_tools_cpp::memory_tools library where needed.
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
* Modified with PR comment, and replaced forgotten osrf_testing_tools_cpp including
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
* Fix regression around fully qualified node name.
Regression was introduced in 114bc5289 (PR #381).
Signed-off-by: Michael Carroll <michael@openrobotics.org>
* Clean up test code based on feedback.
Signed-off-by: Michael Carroll <michael@openrobotics.org>
* Combine tests to prevent Connext timeout.
Signed-off-by: Michael Carroll <michael@openrobotics.org>
* Set symbol visibility to hidden for rcl
Enabling symbol visibility feature in gcc and clang compilers.
This will hep find symbol export related issues in linux and
potentially reduce compile times.
Discourse topic link:
https://discourse.ros.org/t/set-symbol-visibility-to-hidden-for-rmw-and-rcl-packages/7981
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* Remove WIN specific compiler definition in configure_rcl
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* Rename macro name rcl_set_symbol_visibility_hidden
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* Change macro to args for rcl_set_symbol_visibility_hidden
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* Drops legacy launch API usage.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Adds launch_testing as test dependency.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Changing security directory lookup to a prefix match rather than exact match.
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Changing security directory lookup to a prefix match rather than exact match.
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Changing security directory lookup to a prefix match rather than exact match.
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Changing security directory lookup to a prefix match rather than exact match.
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Adding security_directory module and moving rcl_get_secure_root function to it. Adding tests.
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Adding security_directory module and moving rcl_get_secure_root function to it. Adding tests.
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Adding security_directory module and moving rcl_get_secure_root function to it. Adding tests.
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Adding security_directory module and moving rcl_get_secure_root function to it. Adding tests.
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Adding security_directory module and moving rcl_get_secure_root function to it. Adding tests.
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Changing security directory prefix matching to be optional. Improving error messages around security directory lookup.
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Fixing get_best_matching_directory so that it always fetches the next file inside the loop.
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* make pr ready for ros2cli security feature (#1)
* update docs about possibility of rcl_take no taking (#356)
* update rcl_wait doc with respect to subs and possibility of failing takes
* add a note about possible failing takes in rcl_take docs
* 0.6.2
* Set rmw_wait timeout using ros timers too (#357)
* 0.6.3
* Avoid timer period being set to 0 (#359)
* Fix logic that moves goal handles when one expires (#360)
* Fix error from uncrustify v0.68 (#364)
* Ensure that context instance id storage is aligned correctly (#365)
* Ensure that context instance id storage is aligned correctly
* Make alignment compatible with MSVC
* Namespace alignment macro with RCL_
* [rcl] Guard against bad allocation calling rcl_arguments_copy() (#367)
* [rcl] Add test for copying arguments struct with no arguments
* Override allocate function in test to reveal bug
* [rcl] Only allocate arrays if there are things to copy in rcl_argument_copy()
Also guard against freeing invalid pointers if rcl_argument_copy() fails.
* Remove uncessary guard against NULL pointer
* linter, styles, uncrustify fixes
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Update rcl/include/rcl/security_directory.h
Co-Authored-By: AAlon <avishayalon@gmail.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Adding line break in docstring
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Removing duplicate doc string
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Removing tinydir from the source tree, instead using the ROS package tinydir_vendor.
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Removing tinydir
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Reformatting license notice as per linter template.
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Update test_security_directory.cpp
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Changing input to putenv to be a global, statically allocated buffer.
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* test_security_directory - Using a larger buffer for env string manipulations.
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Copy environment variable to allocated string so it is not clobbered by next lookup
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Address review comments
fix security directory exact match comment and unset env vars before tests
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Remove strncpy
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
* Enforce non-null argv values on rcl_init().
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Adds test case for null argv values on rcl_init().
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
The clock type is instead as an argument to the action server's init function and stored in the impl.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Move node_options into it's own header.
Signed-off-by: Michael Carroll <michael@openrobotics.org>
* Check before fini to avoid duplicate.
Signed-off-by: Michael Carroll <michael@openrobotics.org>
* pass context to wait set, and fini rmw context
Signed-off-by: William Woodall <william@osrfoundation.org>
* use identifier rather than impl to check init status
Signed-off-by: William Woodall <william@osrfoundation.org>
* Implementing the rosout logging feature.
* fixup for PR
* Fixup for PR.
* Fixing broken unit tests.
* Minor fixup for PR.
* Fixing bug in rosout teardown.
* Fixing unit test that broke because the rosout node wasn't getting counted.
* Fixing warnings on Windows.
Otherwise the preprocessor may gobble up the commas in mistake of extra parameters when it is passed to uuidcmpzero.
cppcheck v1.86 was complaining about this line.
* [rcl] Add test for copying arguments struct with no arguments
* Override allocate function in test to reveal bug
* [rcl] Only allocate arrays if there are things to copy in rcl_argument_copy()
Also guard against freeing invalid pointers if rcl_argument_copy() fails.
* Remove uncessary guard against NULL pointer
* Adding new cli parameters for configuring the logging.
cr https://code.amazon.com/reviews/CR-3728503
* Moving the external logger library from rcutils into rcl. Also automatic uncrustify.
* Fixing issue with rebase
* Temporarily switching the default to noop logger ext_lib while system dependency issue is solved for Windows/Mac.
* Fixing the format2/3 xmllint issue.
* style changes, and one actual fix
Signed-off-by: William Woodall <william@osrfoundation.org>
* rename rc_logging* to rcl_logging*
Signed-off-by: William Woodall <william@osrfoundation.org>
* Expand rcl_logging_configure API with allocator
This is to make sure that this API is complete, and we can merge rcl#350 later without breaking the API at a later date.
* update logging.c with new use of allocator in API
* update init.c with new API changes
* Switching back to va_list for output handlers.
* address review comments
Signed-off-by: William Woodall <william@osrfoundation.org>
* Add action_interaction_tests
* Fixed tests to work with new uuid
* Added comments for each test
* Addressed peer review comments
* Removed unnecessary rcl_reset_error calls from test_action_communication
* Addressed second part of peer review
