* add optional rmw payload to rcl options for pub and sub
Signed-off-by: William Woodall <william@osrfoundation.org>
* move ignore_local_publications into rmw options structure for subs
Signed-off-by: William Woodall <william@osrfoundation.org>
* Update action graph tests to account for type namespace
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Enable OpenSplice action graph test
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Exclude some action graph tests with OpenSplice
It appears that getting graph information from finalized nodes succeeds with OpenSplice, unlike the other RMW implementations.
Since we do not have tests covering this case in rcl, it's not clear if this is a bug or expected behaviour.
In the meantime, I've disabled testing this specific case for OpenSplice.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* const bool
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* implement rcl_wait and rcl_take for rcl_event_t
Signed-off-by: Miaofei <miaofei@amazon.com>
* address feedback regarding formatting issues
Signed-off-by: Miaofei <miaofei@amazon.com>
* Remove dependency on sleep in test_events
Signed-off-by: Ross Desmond <44277324+ross-desmond@users.noreply.github.com>
* update total max wait time for setting up publisher and subscriber to 10 seconds
Signed-off-by: Miaofei <miaofei@amazon.com>
* Fix test_events for rmw_connext
Signed-off-by: Ross Desmond <44277324+ross-desmond@users.noreply.github.com>
* Refactor out timed loop from tests to function
Signed-off-by: Miaofei <miaofei@amazon.com>
* address additional feedback from pull request
Signed-off-by: Miaofei <miaofei@amazon.com>
* update comment regarding difference between connext and opensplice
Signed-off-by: Miaofei <miaofei@amazon.com>
* fix uncrustify issues
Signed-off-by: Miaofei <miaofei@amazon.com>
* update test_events for compatibility with API changes
Signed-off-by: Miaofei <miaofei@amazon.com>
* temporarily disable test_events for macOS
Signed-off-by: Miaofei <miaofei@amazon.com>
* Add return code to CancelGoal service response
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Add case for terminated goals
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Check for ERROR_NONE instead of 0
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Proposola of changes for RMW_Preallocate. Related /ros2/rmw#160
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
* Changed RCL interface
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
* Updates for allocation in serialize methods.
Signed-off-by: Michael Carroll <michael@openrobotics.org>
* Fix tests for new APIs.
Signed-off-by: Michael Carroll <michael@openrobotics.org>
* Add action graph API
Builds on top of the rcl graph API.
A list of action names associated with action clients can be constructed by
looking for subscriber topic names that have the suffix "/_action/feedback".
Likewise, action servers are associated with publisher topic names with the same suffix.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Enable multiple rmw action graph API tests
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Use ament_target_dependencies for osrf_testing_tools_cpp
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Fix lint errors
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Refactor
* Move graph API common implementation to local function
* Refactor tests
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Disable graph tests with OpenSplice
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Include graph.h in rcl_action.h
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Remove duplicate test
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Prefix increment operators
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Rename 'suffix' -> 'identifier'
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Add missing finalize calls and remove redundant branch
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Finalize names and types struct on error
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Fix bugs in tests
Pass valid names and types struct and update expected error code.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Add zero allocator tests
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Fix indentation
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Check if action identifiers are the suffix
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Using ament_target_dependencies where possible
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
* Modified rcl_add_custom_* to use AMENT_DEPENDENCIES where possible
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
* Added again osrf_testing_tools_cpp::memory_tools library where needed.
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
* Modified with PR comment, and replaced forgotten osrf_testing_tools_cpp including
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
* Set symbol visibility to hidden for rcl
Enabling symbol visibility feature in gcc and clang compilers.
This will hep find symbol export related issues in linux and
potentially reduce compile times.
Discourse topic link:
https://discourse.ros.org/t/set-symbol-visibility-to-hidden-for-rmw-and-rcl-packages/7981
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* Remove WIN specific compiler definition in configure_rcl
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* Rename macro name rcl_set_symbol_visibility_hidden
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* Change macro to args for rcl_set_symbol_visibility_hidden
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
The clock type is instead as an argument to the action server's init function and stored in the impl.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
