niklas/rclcpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1006 commits 1 branch 0 tags 3.3 MiB
Commit graph

1006 commits

This branch
This branch
All branches
Author SHA1 Message Date
Dirk Thomas
8573433c1d
remove empty lines within method signatures (#1128) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-05-22 11:36:32 -07:00
Jacob Perron
64bdef61c8
Deprecate ClientGoalHandle::async_result() (#1120) 
Fixes https://github.com/ros2/rclcpp/issues/955

There are currently two public APIs for users to get the result of a goal.
This change deprecates one of the APIs, which was considered to be unsafe as
it may result in a race with user-code and raise an exception.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2020-05-21 11:39:07 -07:00
William Woodall
2aaeee72a6
[rclcpp] API review March 2020 (#1031) 
* API review part 1

Signed-off-by: William Woodall <william@osrfoundation.org>

* update pre second meeting

Signed-off-by: William Woodall <william@osrfoundation.org>

* notes from 2020-03-23 meeting

Signed-off-by: William Woodall <william@osrfoundation.org>

* online review comments

Signed-off-by: William Woodall <william@osrfoundation.org>
 2020-05-19 10:56:36 -07:00
Alejandro Hernández Cordero
731558aafb
Added features to rclcpp packages (#1106) 
* Added features to rclcpp packages

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback and improved lifecycle docblock

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added ffedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixing error

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-05-15 16:41:25 +02:00
Ivan Santiago Paunovic
0dd14baa32
Make test multi threaded executor more reliable (#1105) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-05-14 14:32:23 -03:00
Alejandro Hernández Cordero
9f04391fbb
[Quality Declaration] Fixed rep links and added more details to dependencies (#1116) 
* Fixed rep links and added more details to dependencies

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed rep link

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-05-13 15:47:05 +02:00
Alejandro Hernández Cordero
ce4c873ae3
Added dockblock to ComponentManager class (#1102) 
* Added dockblock to ComponentManager class

Signed-off-by: ahcorde <ahcorde@gmail.com>

* added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-05-13 08:17:56 +02:00
brawner
df3ba3a279
Update QDs to reflect version 1.0 (#1115) 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-05-12 17:55:49 -07:00
Jacob Perron
cb4bdb7b19 1.0.0 2020-05-12 14:05:31 -07:00
Ivan Santiago Paunovic
803d7f27be
Remove MANUAL_BY_NODE liveliness API (#1107) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-05-12 14:52:26 -03:00
brawner
cac761373f
Increasing test coverage of rclcpp_components (#1044) 
* Increasing test coverage of rclcpp_components

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Removing throws test for now

Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-05-12 10:26:49 -07:00
Karsten Knese
66114c3a4a
use rosidl_default_generators dependency in test (#1114) 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
 2020-05-12 08:29:45 -07:00
Chris Lalancette
ccf2f1c760
Make sure to include what you use. (#1112) 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-05-11 13:32:49 -04:00
Louise Poubel
846e4ce9d3
Mark flaky test with xfail: TestMultiThreadedExecutor (#1109) 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
 2020-05-11 09:16:04 -07:00
Karsten Knese
e24f402238
avoid callback_group deprecation (#1108) 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
 2020-05-08 09:04:38 -07:00
Chris Lalancette
4d1de47df3 0.9.1 2020-05-08 15:40:05 +00:00
Chris Lalancette
5b1877adc4 Changelog. 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-05-08 15:39:57 +00:00
Alejandro Hernández Cordero
e0d0e03078
Added rclcpp lifecycle Doxyfile (#1089) 
* Added rclcpp lifecycle Doxyfile

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed doxyfile

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-05-08 08:48:52 +02:00
Devin Bonnie
d10f7b7c62
Fix tests that were not properly torn down (#1073) 
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
 2020-05-06 13:04:45 -03:00
Alejandro Hernández Cordero
f160a8bc1d
Added docblock in rclcpp (#1103) 
* Added docblock in rclcpp

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-05-06 09:04:31 +02:00
Alejandro Hernández Cordero
e2dbc5d5d5
Added Quality declaration: rclcpp, rclpp_action, rclcpp_components andrclcpp_lifecycle (#1100) 
* Added Quality declaration: rclcpp, rclpp_action, rclcpp_components, rclcpp_lifecycle

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-05-01 22:41:22 +02:00
Ivan Santiago Paunovic
13c09acfad
Use RCL_RET_SERVICE_TAKE_FAILED and not RCL_RET_CLIENT_TAKE_FAILED when checking a request take (#1101) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-05-01 13:55:46 -03:00
brawner
f69b18203f
Increasing test coverage of rclcpp_lifecycle (#1045) 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-04-30 10:29:45 -07:00
Christophe Bedard
ef6434026f
Update comment about return value in Executor::get_next_ready_executable (#1085) 
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
 2020-04-30 10:27:52 -03:00
Jacob Perron
1c943d16fc 0.9.0 2020-04-29 22:44:16 -07:00
brawner
e6325839f1
Increasing test coverage of rclcpp_action (#1043) 
* Increasing test coverage of rclcpp_action

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Increasing test coverage of rclcpp_action

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Fix warnings

Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-04-29 14:25:52 -07:00
Alejandro Hernández Cordero
9150201d28
Added rclcpp_components Doxyfile (#1091) 
* Added rclcpp components Doxyfile

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-04-29 08:45:04 +02:00
Karsten Knese
c1b80bd367
Serialized message move constructor (#1097) 
* correct use of move semantics

Signed-off-by: Knese Karsten <karsten@openrobotics.org>

* more tests

Signed-off-by: Knese Karsten <karsten@openrobotics.org>

* make error message more exact

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* use std::exchange

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* fix typo

Signed-off-by: Karsten Knese <karsten@openrobotics.org>
 2020-04-27 22:23:43 -07:00
Michel Hidalgo
814298480c
Enforce a precedence for wildcard matching in parameter overrides. (#1094) 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-04-27 15:14:48 -03:00
Dirk Thomas
45f3976453
export targets in a addition to include directories / libraries (#1096) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-04-27 10:30:33 -07:00
brawner
e0bf4a9c20
Add serialized_message.hpp header (#1095) 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-04-26 21:40:40 -07:00
Prajakta Gokhale
04f3c33de5
Add received message age metric to topic statistics (#1080) 
* Add received message age metric to topic statistics

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Add unit tests

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Add IMU messages in unit test

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Use system time instead of steady time
Test received message age stats values are greater than 0

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Fix test warnings

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Replace IMU messages with new dummy messages

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Remove outdated TODO and unused test variables

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Address review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address review comments

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Re-add message with header for unit testing

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Address message review feedback

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Remove extra newline

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Address more review feedback

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Fix Windows failure

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Only set append_library_dirs once

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
 2020-04-23 20:41:35 -07:00
William Woodall
df3c2ffa8a
deprecate redundant namespaces (#1083) 
* deprecate redundant namespaces, move classes to own files, rename some classes

Signed-off-by: William Woodall <william@osrfoundation.org>

* fixup

Signed-off-by: William Woodall <william@osrfoundation.org>

* address review comments

Signed-off-by: William Woodall <william@osrfoundation.org>

* fix ups since rebase

Signed-off-by: William Woodall <william@osrfoundation.org>

* avoid deprecation warnings from deprecated functions

Signed-off-by: William Woodall <william@osrfoundation.org>

* more fixes

Signed-off-by: William Woodall <william@osrfoundation.org>

* another fixup, after another rebase

Signed-off-by: William Woodall <william@osrfoundation.org>
 2020-04-23 15:28:45 -07:00
Dirk Thomas
52ae3e0337
export targets in a addition to include directories / libraries (#1088) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-04-23 14:18:51 -07:00
Ivan Santiago Paunovic
80e8dcad02
Ensure logging is initialized just once (#998) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-04-23 17:33:56 -03:00
Karsten Knese
e64022f753
adapt subscription traits to rclcpp::SerializedMessage (#1092) 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
 2020-04-23 15:09:40 -03:00
tomoya
c3d599fc8c
protect subscriber_statistics_collectors_ with a mutex (#1084) 
* subscriber_statistics_collectors_ should be protected with mutex.

Co-Authored-By: William Woodall <william+github@osrfoundation.org>
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
 2020-04-22 23:55:04 -07:00
Devin Bonnie
cdeed8903d
Remove unused test variable (#1087) 
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
 2020-04-22 21:45:50 -07:00
Karsten Knese
46cfe84b14
Use serialized message (#1081) 
* use serialized message in callback

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* introduce resize method for serialized message

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* introduce release for serialized message

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* address review comments

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* correct typo

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* fix interface traits test

Signed-off-by: Karsten Knese <karsten@openrobotics.org>
 2020-04-22 19:30:56 -07:00
Devin Bonnie
bb91b6c2ef
Integrate topic statistics (#1072) 
* Add SubscriberTopicStatistics class

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Add SubscriberTopicStatistics Test

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Modify constructor to allow a node to create necessary components

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Fix docstring style

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Remove SetPublisherTimer method

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Change naming style to match rclcpp

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address style issues

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Use rclcpp:Time

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Remove unnecessary check for null publisher timer
Move anonymous namespace function to private class method

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Update message dependency

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Initial integration of Subscriber Topic Statistics

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Fix nanoseconds used for Topic Stats

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Add simple publishing test
Minor fixes

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Add test utils header

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Integrate with Topic Statistics options
Fixes after rebasing with master

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Update after rebasing

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address minor review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Move Topic Statistics instantiation to create_subscription

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Fix rebase issue
Fix topic statistics enable flag usage
Address minor formatting

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Move new timer creation method to relevant header

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Add timers interface to topic interface

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Use new create timer method

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
 2020-04-22 16:09:41 -07:00
Karsten Knese
4eab2a3c60
Fix rclcpp interface traits test (#1086) 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
 2020-04-22 14:19:39 -07:00
Michel Hidalgo
bb8c8ff2c0
Generate node interfaces' getters and traits. (#1069) 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Co-authored-by: Karsten Knese <karsten@openrobotics.org>
 2020-04-22 17:02:02 -03:00
Karsten Knese
c9319dafc2
use composition for serialized message (#1082) 
* use composition over inheritance

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* make parameter names equal

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* address review comments

Signed-off-by: Karsten Knese <karsten@openrobotics.org>
 2020-04-21 22:35:35 -07:00
DensoADAS
0f0a4a8e39
Dnae adas/serialized message (#1075) 
* Addes SerializedMessage and helper class for serialization to rcl_serialized_message

@Karsten1987 Thank you for your support

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>

* Updateds subscription traits for SerializedMessage

@Karsten1987 Thank you for your support

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>

* Addes tests SerializedMessage and subscription traits

@Karsten1987 Thank you for your support

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>

* Update rclcpp/include/rclcpp/serialization.hpp

Co-Authored-By: Karsten Knese <Karsten1987@users.noreply.github.com>

* Update rclcpp/test/test_serialized_message.cpp

Co-Authored-By: Karsten Knese <Karsten1987@users.noreply.github.com>

* fix windows compilation

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* cosmetic touchups

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

Co-authored-by: Joshua Hampp <j.hampp@denso-adas.de>
Co-authored-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Co-authored-by: Karsten Knese <karsten@openrobotics.org>
 2020-04-21 17:30:35 -07:00
Prajakta Gokhale
649d72f835
Reflect changes in rclcpp API (#1079) 
* Reflect changes in rclcpp API

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Revert earlier fix made in rclcpp

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
 2020-04-21 14:14:47 -07:00
Dirk Thomas
679196880e
fix build regression (#1078) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-04-21 08:57:31 -07:00
Prajakta Gokhale
1feea5e137
Add NodeDefault option for enabling topic statistics (#1074) 
* Add NodeDefault option for enabling topic statistics

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Remove unnecessary if statement

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
 2020-04-21 00:07:14 -07:00
Devin Bonnie
61e5075d06
Topic Statistics: Add SubscriptionTopicStatistics class (#1050) 
* Add SubscriberTopicStatistics class

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Add SubscriberTopicStatistics Test

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Modify constructor to allow a node to create necessary components

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Fix docstring style

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Remove SetPublisherTimer method

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Change naming style to match rclcpp

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address style issues

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Fix rebase issue

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Use rclcpp:Time

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Remove unnecessary check for null publisher timer
Move anonymous namespace function to private class method

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Update message dependency

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Revert constructor changes

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
 2020-04-20 16:18:21 -07:00
Prajakta Gokhale
593b577294
Add SubscriptionOptions for topic statistics (#1057) 
* Add SubscriptionOptions for topic statistics

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Add more options and unit test

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Address review comments

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Make default publish period 1sec

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
 2020-04-20 14:52:54 -07:00
Miaofei Mei
911291f8d3
remove warning message from failing to register default callback (#1067) 
Signed-off-by: Miaofei <miaofei@amazon.com>
 2020-04-17 16:56:26 -03:00