* Remove a bunch of redundant nullptr assignments
* Fix some memory leaks
* Ensure source string is deallocated
* Remove redundant array size assignment
Signed-off-by: Scott K Logan <logans@cottsay.net>
* Added benchmark test to rcl_yaml_param_parser
Signed-off-by: ahcorde <ahcorde@gmail.com>
* reset heap counters
Signed-off-by: ahcorde <ahcorde@gmail.com>
* updated benchmark tests
Signed-off-by: ahcorde <ahcorde@gmail.com>
* Added feedback
Signed-off-by: ahcorde <ahcorde@gmail.com>
* Replace BENCHMARK_DEFINE_F and BENCHMARK_REGISTER_F with BENCHMARK_F
Signed-off-by: ahcorde <ahcorde@gmail.com>
* Used rcpputils for the path
Signed-off-by: ahcorde <ahcorde@gmail.com>
* Clean up the CMake dependencies
Signed-off-by: Scott K Logan <logans@cottsay.net>
* Updated test
Signed-off-by: ahcorde <ahcorde@gmail.com>
* udpated test name
Signed-off-by: ahcorde <ahcorde@gmail.com>
Co-authored-by: Scott K Logan <logans@cottsay.net>
* Fix yaml parser error when meets .nan
Signed-off-by: Ada-King <Bingtao.Du@sony.com>
Correct code style
Signed-off-by: Ada-King <Bingtao.Du@sony.com>
Modify as suggested
Signed-off-by: Ada-King <Bingtao.Du@sony.com>
Improve test
Signed-off-by: Ada-King <Bingtao.Du@sony.com>
Fix minor flaw
Signed-off-by: Ada-King <Bingtao.Du@sony.com>
Fix minor flaw again
Signed-off-by: Ada-King <Bingtao.Du@sony.com>
Satisfy windows CI
Signed-off-by: Ada-King <Bingtao.Du@sony.com>
Change the match rule for special float
Signed-off-by: Ada-King <Bingtao.Du@sony.com>
Distinguish +.inf and -.inf
Signed-off-by: Ada-King <Bingtao.Du@sony.com>
* Remove unnecessary #include change.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Add in two more necessary includes.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Co-authored-by: Ada-King <Bingtao.Du@sony.com>
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Co-authored-by: Ada-King <Bingtao.Du@sony.com>
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
* Refactor parser.c for better testability (#754)
* Refactor rcl_yaml_param_parser for better testability
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Reorder parser.c to match parser.h
Signed-off-by: Stephen Brawner <brawner@gmail.com>
squash! Reorder parser.c to match parser.h
* Refactor yaml_variant.c for deduplication
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* ADD_VALUE_TO_SIMPLE_ARRAY for deduplication
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Remove fprintf
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* PR Fixup
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Move headers to src directory
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* PR Fixup
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Rebase #780
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Missing includes
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Cleanup and address issues in parser.c
Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>
squash! Cleanup and address issues in parser.c
* Increase test coverage of parser
Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>
* PR Fixup
Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>
* PR Fixup
Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>
Co-authored-by: Stephen Brawner <stephenbrawner@verbsurgical.com>
It wasn't preventing any allocations from happening, so it
doesn't seem to serve much purpose. Also remove the tests
for the maximum string size.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Support rcl_params_t copies.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Parse parameter overrides from command line.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Parameter overrides' tests passing.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Test rcl_yaml_node_struct_copy() function
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Export rcl_yaml_param_parser as rcl dependency.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Zero initialize parameter overrides before rcl arguments copy.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Initialize local variables early enough.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Simplify rcl package.xml
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Assert arguments sanity in rcl args parsing internal functions.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Extend rcl_yaml_param_parser tests to all parameter types.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Address peer review comments.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Support --remap/-r flags.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Please cpplint
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Increase MAX_STRING_SIZE
It's too short for string length.
It occurs the error when the string field in yaml files are too long....
Signed-off-by: Hyunseok Yang <hyunseok7.yang@lge.com>
* update test to match increased limit
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
