niklas/rcl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Increase MAX_STRING_SIZE (#487)

Browse source 
* Increase MAX_STRING_SIZE

It's too short for string length.
It occurs the error when the string field in yaml files are too long....

Signed-off-by: Hyunseok Yang <hyunseok7.yang@lge.com>

* update test to match increased limit

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
This commit is contained in:
hyunseok-yang 2019-08-24 06:52:46 +09:00 • committed by Dirk Thomas
parent 2431ed6d1f
commit d07003847b
2 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
rcl_yaml_param_parser/src/parser.c
View file

@ -65,7 +65,7 @@ typedef struct namespace_tracker_s
uint32_t num_parameter_ns;
} namespace_tracker_t;
#define MAX_STRING_SIZE 128U
#define MAX_STRING_SIZE 256U
#define PARAMS_KEY "ros__parameters"
#define NODE_NS_SEPERATOR "/"
#define PARAMETER_NS_SEPERATOR "."

3
rcl_yaml_param_parser/test/max_string_sz.yaml
View file

@ -5,5 +5,4 @@ lidar_ns:
lidar_1:
ros__parameters:
id: 10
name: "A very long name that will not be supported by the yaml parser. The max supported string size is 128
characters. Anything over the max size will be rejected"
name: "A long string that will not be supported by the yaml parser. The maximum supported length is 256 characters. Anything over that limit will be rejected and therefore this message has to be a bit longer in order to exceed that threshold by just one character."