* Adding new cli parameters for configuring the logging.
cr https://code.amazon.com/reviews/CR-3728503
* Moving the external logger library from rcutils into rcl. Also automatic uncrustify.
* Fixing issue with rebase
* Temporarily switching the default to noop logger ext_lib while system dependency issue is solved for Windows/Mac.
* Fixing the format2/3 xmllint issue.
* style changes, and one actual fix
Signed-off-by: William Woodall <william@osrfoundation.org>
* rename rc_logging* to rcl_logging*
Signed-off-by: William Woodall <william@osrfoundation.org>
* Expand rcl_logging_configure API with allocator
This is to make sure that this API is complete, and we can merge rcl#350 later without breaking the API at a later date.
* update logging.c with new use of allocator in API
* update init.c with new API changes
* Switching back to va_list for output handlers.
* address review comments
Signed-off-by: William Woodall <william@osrfoundation.org>
* fix compiler warning in clang
Signed-off-by: William Woodall <william@osrfoundation.org>
* same thing but for node too
Signed-off-by: William Woodall <william@osrfoundation.org>
* refactor init to not be global
Signed-off-by: William Woodall <william@osrfoundation.org>
* style changes
Signed-off-by: William Woodall <william@osrfoundation.org>
* refactor to hide use of C11 atomics in implementation
Signed-off-by: William Woodall <william@osrfoundation.org>
* fix new action tests
Signed-off-by: William Woodall <william@osrfoundation.org>
* use alternative atomic init for Windows support
* updates after rebase
Signed-off-by: William Woodall <william@osrfoundation.org>
* cleanup rmw_init_options before copying
Signed-off-by: William Woodall <william@osrfoundation.org>
* fix two bugs in new init code
* relax validity checks in a few places to facilitate post shutdown cleanup
Signed-off-by: William Woodall <william@osrfoundation.org>
* fixing tests for new API behavior
Signed-off-by: William Woodall <william@osrfoundation.org>
* to allocator -> to allocate
* acutally call rmw_shutdown() and address review comments
Signed-off-by: William Woodall <william@osrfoundation.org>
* move stdatomic_helper* to rcutils
Signed-off-by: William Woodall <william@osrfoundation.org>
* refactor after moving stdatomic_helper.h to rcutils
Signed-off-by: William Woodall <william@osrfoundation.org>
* use new error handling API from rcutils
Signed-off-by: William Woodall <william@osrfoundation.org>
* use semicolons after macros
Signed-off-by: William Woodall <william@osrfoundation.org>
* use new error handling API from rcutils
Signed-off-by: William Woodall <william@osrfoundation.org>
* minimize vertical whitespace
Signed-off-by: William Woodall <william@osrfoundation.org>
* use semicolons after macros
Signed-off-by: William Woodall <william@osrfoundation.org>
* Add semicolons to all RCLCPP and RCUTILS macros.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Add semicolons in Windows stdatomic_helper.h
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* rcl_wait() on timers with ROS clock
Timers handle time jump callbacks
rcl_wait() wakes when ros time gets a time after timer's next call time
* Set timer impl to NULL after fini
* Clock has multiple time jump callbacks
Replaces pre_update and post_update
Adds callbacks when ROS time is activated or deactivated
Add rcl_clock_change_t, rcl_time_jump_t, rcl_jump_threshold_t
Add rcl_clock_add_jump_callback()
Add rcl_clock_remove_jump_callback()
* Fini generic clock after confirming correct clock type
* test_time no ASAN detections
* initialize timer with clock
* use rcl_clock_get_now
* call rcl_clock_fini at the end of each test
* modify rcl_clock_get_now to take a rcl_time_point_value_t
* update docblock
* update to pass time_point_value
* add check for NULL
* add rcl_timer_clock()
* fix style
* doc fixes
* fini clock
* Set default logger level from command line
* Return INVALID_REMAP_RULE
* Add tests
* Do string parsing in rcutils
* Set log level after parsing all arguments
Less convenient but seems cleaner
* Document log arg format, custom return code
* Rename function
* Rename argument
* Refactor argument parsing after rebasing to include param files
* Renaming from param files support
* Doc fixup
* __log -> __log_level
* Use RCUTILS_SAFE_FWRITE_TO_STDERR on bad alloc
* doc fixup
* doc fixup
* Document behaviour if multiple __log_level rules found
* Update docblock formatting
* Label all documentation in arguments.c as internal
* remove old memory tools
* updates to use new memory_tools from osrf_testing_tools_cpp
* fixup new test
* fix lambda captures for Windows
* uncrustify fix
* extra_test_env -> rmw_implementation_env_var
* Stray extra_test_libraries
* Use default rmw impl outside of for_each_rmw_implementation loop
* style fixup
* fix typo