* reset error message before setting a new one, embed the original one
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* fix max line length
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* Bring back deprecated CLI arguments.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Remove extra vertical space.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Promote special CLI rules to flags.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Improve argument parsing logging and error messages.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Remove some short form CLI flags.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Fail fast on invalid ROS arguments.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Address peer review comments.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Fix warning on Windows.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Enforce -r/--remap flags.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Cast size_t to int explicitly.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Support rcl_params_t copies.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Parse parameter overrides from command line.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Parameter overrides' tests passing.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Test rcl_yaml_node_struct_copy() function
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Export rcl_yaml_param_parser as rcl dependency.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Zero initialize parameter overrides before rcl arguments copy.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Initialize local variables early enough.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Simplify rcl package.xml
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Assert arguments sanity in rcl args parsing internal functions.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Extend rcl_yaml_param_parser tests to all parameter types.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Address peer review comments.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Support --remap/-r flags.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Please cpplint
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Increase MAX_STRING_SIZE
It's too short for string length.
It occurs the error when the string field in yaml files are too long....
Signed-off-by: Hyunseok Yang <hyunseok7.yang@lge.com>
* update test to match increased limit
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* include actual size in error message
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* use %u for existing arguments
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* Prints the node name when failing to find security directory
Also quotes directory, node_name and lookup strategy in error message for readability
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
* don't quote lookup strategy
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
* newline -> whitespace
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
* Support parameter YAML string value parsing.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Address peer review comments.
- Improve test coverage using new getter API.
- Unify function return style and improve readability.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Clean up allocations in rcl_yaml_param_parser package tests.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Make rcl_yaml_param_parser depend on rcutils only.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Address peer review comments.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Add graph test for service clients
There were tests for publishers, subscriptions, and services, but not clients.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Add function for getting clients by node
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Update service client graph test
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Fix doc sentence
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Update docs
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
test_rcl_get_publisher_names_and_types_by_node was finalizing
without calling to rcl_names_and_types_fini which was
generating a memory leak.
These lines fix the leak. Complete report in the pull request
Signed-off-by: Víctor Mayoral Vilches <v.mayoralv@gmail.com>
Similar to the warnings when remapping to invalid namespaces, this better communicates failures to the user.
Resolves#449
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
