It wasn't preventing any allocations from happening, so it
doesn't seem to serve much purpose. Also remove the tests
for the maximum string size.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Support rcl_params_t copies.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Parse parameter overrides from command line.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Parameter overrides' tests passing.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Test rcl_yaml_node_struct_copy() function
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Export rcl_yaml_param_parser as rcl dependency.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Zero initialize parameter overrides before rcl arguments copy.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Initialize local variables early enough.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Simplify rcl package.xml
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Assert arguments sanity in rcl args parsing internal functions.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Extend rcl_yaml_param_parser tests to all parameter types.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Address peer review comments.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Support --remap/-r flags.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Please cpplint
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Increase MAX_STRING_SIZE
It's too short for string length.
It occurs the error when the string field in yaml files are too long....
Signed-off-by: Hyunseok Yang <hyunseok7.yang@lge.com>
* update test to match increased limit
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* include actual size in error message
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* use %u for existing arguments
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* Support parameter YAML string value parsing.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Address peer review comments.
- Improve test coverage using new getter API.
- Unify function return style and improve readability.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Clean up allocations in rcl_yaml_param_parser package tests.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Make rcl_yaml_param_parser depend on rcutils only.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Address peer review comments.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Set symbol visibility to hidden for rcl
Enabling symbol visibility feature in gcc and clang compilers.
This will hep find symbol export related issues in linux and
potentially reduce compile times.
Discourse topic link:
https://discourse.ros.org/t/set-symbol-visibility-to-hidden-for-rmw-and-rcl-packages/7981
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* Remove WIN specific compiler definition in configure_rcl
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* Rename macro name rcl_set_symbol_visibility_hidden
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* Change macro to args for rcl_set_symbol_visibility_hidden
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* use new error handling API from rcutils
Signed-off-by: William Woodall <william@osrfoundation.org>
* use semicolons after macros
Signed-off-by: William Woodall <william@osrfoundation.org>
* use new error handling API from rcutils
Signed-off-by: William Woodall <william@osrfoundation.org>
* minimize vertical whitespace
Signed-off-by: William Woodall <william@osrfoundation.org>
* use semicolons after macros
Signed-off-by: William Woodall <william@osrfoundation.org>
