Commit graph

799 commits

Author SHA1 Message Date
Dirk Thomas
d681d29219 replace deprecated <CONFIGURATION> with <CONFIG> 2016-12-20 11:38:30 -08:00
Dirk Thomas
638f976783 Merge pull request #99 from ros2/fix_test
add missing wait-for-server-being-available
2016-12-15 16:02:37 -08:00
Dirk Thomas
73393dff3c add missing wait-for-server-being-available 2016-12-15 16:02:12 -08:00
Karsten Knese
a18ef97e5a add rcl lifecycle
* (refactor) add rcl_lifecycle package

* (refactor) cleanup free calls

* (fix) initialize state machine with external node handle

* (dev) use external typesupport

* (fix) use external typesupport

* (fix) cleanup states

* (fix) no pointer comparison in state machine

* (test) refactor for rcl testing purpose

* (test) test suite for lifecycle sequence

* (dev) change to rcl_ret_t

* (test) wrong transition test

* (fix) dependency for isolated build

* (clean) remove std_msgs as a dep

* (fix) enable correct visibility control

* (fix) correct test for initialization

* (fix) correct visibility attributes

* (dev) change default value to lifecycle_msgs

* (clean) style and lifecycle prefix

* (dev) cmake macro get_rcl_lifecycle_information

* (cleanup) remove unused files'

* (cleanup) remove callback pointer

* (debug) add print state machine function

* (review) address review comments

* (bugfix) correct export in information.cmake

* (fix) correct visibility control

* (vcs) fix convertion from size_t to unsigned int

* (typo) fix internal struct name

* const correctness

* get_available_states service

* new service msgs

* tes for multiple instances

* (dev) return codes

* initial refactor

* test default sequence

* refactor state machine

* apply upstream changes

* c++14

* disable state machine print

* address review comments

* uncrustify

* fix comparison with unsigned warning
2016-12-14 09:28:54 -08:00
dhood
4590fc5f77 Print warning when transient local used for services (#96)
* Print warning when transient local used for services

* Fixup
2016-12-13 16:26:32 -08:00
Morgan Quigley
748703066d c++14 (#94) 2016-12-13 14:41:07 -08:00
Mikael Arguedas
3658932230 Canceled timers (#95)
* don't wake up on canceled timers

* test wait with canceled timers
2016-12-11 14:31:19 -08:00
William Woodall
6bc013dd28 triggering a guard condition is not const (#89)
* triggering a guard condition is not const

* missed a const
2016-12-09 17:10:16 -08:00
Dirk Thomas
e93544861c Merge pull request #92 from ros2/typesupport_reloaded
update to use refactored typesupport
2016-12-08 14:00:37 -08:00
Dirk Thomas
b64bb0eec0 update to use refactored typesupport 2016-12-02 18:11:28 -08:00
Mikael Arguedas
723e561b80 Mark blacklisted tests as skipped (#90)
* support skipping tests

* skip blacklisted test_graph test

* deduplicate function call

* rename _SKIP_TEST to SKIP_TEST

* arg order
2016-11-30 10:20:48 -08:00
Dirk Thomas
8ecb08cb6e Merge pull request #88 from ros2/fix_error_msg
remove error msg from valid case
2016-11-10 10:53:51 -08:00
Dirk Thomas
a19dcbd0b8 remove error msg from valid case 2016-11-09 16:57:01 -08:00
Mikael Arguedas
545cb5602c Revert "cast time at macro expansion (#86)" (#87)
This reverts commit 5fe6c528f3.
2016-11-04 11:36:15 -07:00
Mikael Arguedas
5fe6c528f3 cast time at macro expansion (#86) 2016-11-04 10:59:44 -07:00
William Woodall
74574a4ff5 support local graph changes in Connext (#67)
* pass node to client and service destroy funcs

* address a flaky test with connext, will ticket

* invert test_graph exclusion logic

* use zero initialization of tnat in test_graph

* change is_connext logic
2016-10-28 18:30:52 -07:00
Mikael Arguedas
32bcd0d760 Zero init topic names and types (#85)
* initialize topic_names_and_type struct in rcl

* sanity check in get_topic_names_and_types

* uncrustify

* initialize all fields...

* address documentation request

* typo
2016-10-27 19:00:06 -07:00
Esteve Fernandez
7661ab2202 Return correct error when rcl_take_request fails 2016-10-09 10:23:55 +09:00
Lennart Nachtigall
77b034840b Removed RCL_RET_CLIENT_INVALID from documentation for rcl_send_response (#80)
* Removed RCL_RET_CLIENT_INVALID from documentation for rcl_send_response

* rcl_send_response has RCL_RET_SERVICE_INVALID in its documentation now
2016-09-23 15:35:49 -07:00
William Woodall
66208db876 remove mentions of "taken" bool in rcl_take (#74) 2016-09-16 15:32:42 -07:00
Dirk Thomas
d7120e57fd Merge pull request #79 from ros2/fix_no_data_handling
fix no data handling
2016-09-15 15:05:43 -07:00
Dirk Thomas
4058e44ffc fix no data handling 2016-09-15 13:25:16 -07:00
William Woodall
9c97489c53 check for alloc failure when copying argv (#68) 2016-08-30 15:36:59 -07:00
William Woodall
03900d6af9 call to rmw_init, despite the lack of rmw_shutdown (#69)
See: https://github.com/ros2/rclcpp/pull/207/files#r73983227
2016-08-26 18:08:58 -07:00
gerkey
0abda63db3 Merge pull request #75 from ros2/fix_time_arm32
Avoid overflow on 32-bit machines when working with large ns values
2016-08-24 17:05:24 -07:00
hsu
88db3d821a avoid overflow on 32-bit machines when working with large ns values 2016-08-24 15:40:44 -07:00
Dirk Thomas
b5a77f2233 Merge pull request #72 from firesurfer/master
Changed RCL_RET_SUBSCRIPTION_TAKE_FAILED to 401
2016-08-22 11:27:29 -07:00
Lennart Nachtigall
3349d71b4d Changed RCL_RET_SUBSCRIPTION_TAKE_FAILED to 401
Changed RCL_RET_SUBSCRIPTION_TAKE_FAILED to 401 instead of 501. Seems to be a copy&paste error: https://github.com/ros2/rcl/issues/71
2016-08-22 19:53:58 +02:00
Dirk Thomas
7bdc682ab8 update schema url 2016-06-28 20:02:10 -07:00
Dirk Thomas
3f03b1d933 add schema to manifest files 2016-06-26 17:14:48 -07:00
William Woodall
e6e7713c43 remove incorrect asserts (#63) 2016-06-22 20:18:36 -07:00
Esteve Fernandez
9bbe3666ac Enable fastrtps for rcl (#32)
* Enable fastrtps

* Fix invalid timer access
2016-06-21 18:02:52 -07:00
William Woodall
5733d36ed2 pass qos to rmw create pub/sub (#65) 2016-06-21 14:53:11 -07:00
Dirk Thomas
8cd81a5a9a Merge pull request #64 from ros2/cmake35
require CMake 3.5
2016-06-16 12:20:21 -07:00
Dirk Thomas
35add7f8cc remove trailing spaces from comparisons, obsolete quotes and explicit variable expansion 2016-06-16 09:19:20 -07:00
Dirk Thomas
9f5fb0fb5e require CMake 3.5 2016-06-15 11:35:56 -07:00
Dirk Thomas
10c14e02e0 suppress cpplint warning 2016-06-14 12:18:06 -07:00
William Woodall
fd3d4a21e8 de-duplicate documentation 2016-06-13 16:29:45 -07:00
Dirk Thomas
4f252bc31a Merge pull request #62 from ros2/xenial
fix compiler warning
2016-06-10 10:43:54 -07:00
Dirk Thomas
41573e3540 fix compiler warning 2016-06-10 09:48:43 -07:00
Jackie Kay
ef5690278b adjust timing in flaky Windows test (#60)
Adjust "wait_period" to be much greater than "trigger_period" in multi-threaded waitset test
2016-06-06 17:44:41 -07:00
William Woodall
17845ae1f9 Clarify wait concurrency (#59)
* fix bug where "wait set empty" check was wrong

* clarify rcl_wait is thread-safe with unique sets

* style fixup

* explicitly capture const local variables

this is required on Windows, but not gcc/clang
2016-06-02 16:08:56 -07:00
William Woodall
818b15463b add graph functions to support wait_for_service (#57)
* add graph functions to support wait_for_service

* is_ready -> is_available

* add function to create rcl_guard_condition from an existing rmw_guard_condition

* create graph guard condition in node automatically

* tests for graph API

* style fixup

* remove debug stuff from test_graph

* only enable test_graph for OpenSplice

* fixup

* add rcl_node_is_valid function

* add tests for new graph API functions

* fixup

* reorder the destruction of node vs waitset

this also addressed the segfault issues, but the
proper fix was committed to rmw_opensplice_cpp
while this ordering is not strictly necessary it
is slightly more correct

* disable missing-field-intializers warning

it's too strict and will be relaxed in newer gcc's

* use to_string since type changes with OS

* use more specific gtest assert to avoid warning

* added a secondary check in the test_graph.test_rcl_service_server_is_available test

* uncrustify

* doc fixup

* condition pragma on not _WIN32
2016-05-28 15:14:38 -07:00
Jackie Kay
2811eb1312 Keep service around until client exits (#48)
* Keep service around until client exits

* use ignore_signal return handler
2016-05-03 15:55:55 -07:00
William Woodall
2c9320f5b0 check rmw id using RCL_ASSERT_RMW_ID_MATCHES (#51)
* check rmw id using RCL_CHECK_RMW_ID_MATCHES_OR_DIE

* return a more distinct return code on mismatch

* rename env var to RCL_ASSERT_RMW_ID_MATCHES

* [style] fixup
2016-05-03 13:38:49 -07:00
William Woodall
a01943973a fix typo 2016-05-02 19:00:08 -07:00
Dirk Thomas
2c33b23589 Merge pull request #56 from ros2/ctest_build_testing
use CTest BUILD_TESTING
2016-05-02 10:11:27 -07:00
Dirk Thomas
347f520b46 use CTest BUILD_TESTING 2016-04-28 18:44:26 -07:00
dhood
7aeb957c2c Workaround for the change in libnddscore.so in connext 5.2.0 between gcc4.6.3 and gcc4.8.2 (#55)
* Workaround for the change in libnddscore.so in connext 5.2.0 between gcc4.6.3 and gcc4.8.2

* Prefix macro variables with underscore
2016-04-28 15:27:12 -07:00
Jackie Kay
11753a3dd3 Cmake issues (#53)
* Clean up cmake infrastructure for tests
2016-04-26 15:54:51 -07:00