* Add -Wnon-virtual-dtor -Woverloaded-virtual compiler options
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
* Add missing virtual dtors
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
* please linter
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
This keeps it from going out of scope while the executor
is still dealing with QoSEvents.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* expose get_service_names_and_types_by_node from rcl in rclcpp
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* fix spelling
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* zero initialize
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* check return value and cleanup
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* use throw_from_rcl_error
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* cleanup error handling
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* API review part 1
Signed-off-by: William Woodall <william@osrfoundation.org>
* update pre second meeting
Signed-off-by: William Woodall <william@osrfoundation.org>
* notes from 2020-03-23 meeting
Signed-off-by: William Woodall <william@osrfoundation.org>
* online review comments
Signed-off-by: William Woodall <william@osrfoundation.org>
* Add received message age metric to topic statistics
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
* Add unit tests
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
* Add IMU messages in unit test
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
* Use system time instead of steady time
Test received message age stats values are greater than 0
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
* Fix test warnings
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
* Replace IMU messages with new dummy messages
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
* Remove outdated TODO and unused test variables
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
* Address review comments
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
* Address review comments
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
* Re-add message with header for unit testing
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
* Address message review feedback
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
* Remove extra newline
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
* Address more review feedback
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
* Fix Windows failure
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
* Only set append_library_dirs once
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
* deprecate redundant namespaces, move classes to own files, rename some classes
Signed-off-by: William Woodall <william@osrfoundation.org>
* fixup
Signed-off-by: William Woodall <william@osrfoundation.org>
* address review comments
Signed-off-by: William Woodall <william@osrfoundation.org>
* fix ups since rebase
Signed-off-by: William Woodall <william@osrfoundation.org>
* avoid deprecation warnings from deprecated functions
Signed-off-by: William Woodall <william@osrfoundation.org>
* more fixes
Signed-off-by: William Woodall <william@osrfoundation.org>
* another fixup, after another rebase
Signed-off-by: William Woodall <william@osrfoundation.org>
* subscriber_statistics_collectors_ should be protected with mutex.
Co-Authored-By: William Woodall <william+github@osrfoundation.org>
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
