* Increase MAX_STRING_SIZE
It's too short for string length.
It occurs the error when the string field in yaml files are too long....
Signed-off-by: Hyunseok Yang <hyunseok7.yang@lge.com>
* update test to match increased limit
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* include actual size in error message
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* use %u for existing arguments
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* Support parameter YAML string value parsing.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Address peer review comments.
- Improve test coverage using new getter API.
- Unify function return style and improve readability.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Clean up allocations in rcl_yaml_param_parser package tests.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Make rcl_yaml_param_parser depend on rcutils only.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Address peer review comments.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Set symbol visibility to hidden for rcl
Enabling symbol visibility feature in gcc and clang compilers.
This will hep find symbol export related issues in linux and
potentially reduce compile times.
Discourse topic link:
https://discourse.ros.org/t/set-symbol-visibility-to-hidden-for-rmw-and-rcl-packages/7981
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* Remove WIN specific compiler definition in configure_rcl
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* Rename macro name rcl_set_symbol_visibility_hidden
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* Change macro to args for rcl_set_symbol_visibility_hidden
Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
* use new error handling API from rcutils
Signed-off-by: William Woodall <william@osrfoundation.org>
* use semicolons after macros
Signed-off-by: William Woodall <william@osrfoundation.org>
* use new error handling API from rcutils
Signed-off-by: William Woodall <william@osrfoundation.org>
* minimize vertical whitespace
Signed-off-by: William Woodall <william@osrfoundation.org>
* use semicolons after macros
Signed-off-by: William Woodall <william@osrfoundation.org>
In get_value() function ret_val is allocated from rcutils_strdup when type is DATA_TYPE_STRING,
Should be deallocate in switch val_type=DATA_TYPE_STRING case.
Signed-off-by: Chris Ye <chris.ye@intel.com>
* Implement a basic YAML based parameter parser for ros2 nodes
* Add README file
* Fix the issues after moving from rcutils_yaml_param_parser to rcl_yaml_param_parser
- rename folders from rcutils_yaml_param_parser to rcl_yaml_param_parser
- rename project, header guards and include statements from rcutils_yaml_param_parser to rcl_yaml_param_parser
- move type declaration in separat file and namespace new structures
- Fix the code review comments from Mikael
* Few minor changes
- Changed "params" string to "ros__parameters"
- Add -Wall, -Wextra and -Wpedantic falgs
- Fix the compile warning with the new flags
* Fix the changes made in the design of C structure
- Remove the node_namespaces entry in rcl_params_t
- Change the type of num_nodes and num_params to size_t
* depend on libyaml_vendor (#236)
* Fix cmake setting standard(C and C++) and add byte_array in C struct
* Remove C11 so that it defaults to C99
* [rcl_yaml_param_parser] fix export symbols (#237)
* add visibility macros
* remove unused macro
* Support for multi level node and parameter name spaces
* Additional fixes and cleanups
- Support for string namespace seperator
- Provide parameter structure init function API
- name cleanups
* off by 1
* Call yaml_parser_delete()
* fclose(yaml_file)
* free() allocated paths
* Call yaml_event_delete()
* completely deallcoate string array
* Few cleanup changes
- Add install command into CMakelists.txt
- Replace one of the zero_allocate with reallocate
- Pass allocator state
- Fix int32_t -> rcl_ret_t return value
* Don't include unistd.h
* Use size_t for array indices
* Just pass the allocator in the init function
