* Move clear wait set from after rcl_wait to ahead
Current code clear wait set after rcl_wait, it is not respond latency
friendly. In fact, clear wait set operation is not urgent, making sure it is
done before next rcl_wait should be fine.
Signed-off-by: jwang <jing.j.wang@intel.com>
* remove trailing whitespace
* Fix the dereference to NULL
rmw_*_validation_result_string(validation_result) may return NULL,
and it's dereferenced by passing arg to NameValidationError
Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
* address NULL case of undefined type
Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
* Address the issue to deference to NULL with adapt
to the change of API rmw_*_validation_result_string
Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
* revise the typo
* throw exception when valid rmw check but invalid rcl check
Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
* Change rmw_count_publishers API, to rcl equivalent rcl_count_publishers and remove the TODO line.
Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
* Remove rmw_handle and refer to rcl_node_handle, change the API signature to topic_names.
Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
* Use rcl_* specific functions to derive the fully qualified topic name.
Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
* [nitpick] remove unnecessary variable storage
* copy and assignment operator for state
copy and assignment operator for transition
remove unused const_casts
address comments
check for null in copy constructor
up
use init and fini functions from rcl
remove unused include
* explicitly zero initialize state and transitions
* add todo comment for follow up
* Remove reference for logger so it can be rclcpp::Logger &
This is the type when captured by reference in a lambda; windows can't
resolve it without.
* Wrap lines
* Add Logger class and give one to nodes
* Try to improve compiler errors when non-Logger is passed to macros
* Add define for 'disabling' loggers
* Add/update tests
* Linter fix
* Documentation
* Windows fix
* Move free functions to source file (windows was upset)
* Fix windows by changing prototype ordering
* Store node logger in NodeBase
* Windows is not happy with this EXPECT_ANY_THROW
* Move get_logger to a NodeLogger interface
* Move Logger into 'logger' namespace
* Move helper function for macro errors into macro header
* Remove 'logger' namespace
* Return type on separate line
* Update copyright year
* Give lifecycle nodes a logger
* Add test for lifecycle node logger
Move the default_state_machine tests to another file because having
different test fixtures was causing init to be called twice.
* Switch to static_assert for logger check
* global ns scope in macro calls
just in case
* Revert "Add test for lifecycle node logger" (make diff smaller)
demos use the loggers and we don't test other node stuff in lifecycle_node
* Update for rcutils function name change
* Add reference to Node::get_logger() in doxygen
* Rename NodeLoggerInterface to NodeLoggingInterface
