This keeps it from going out of scope while the executor
is still dealing with QoSEvents.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* expose get_service_names_and_types_by_node from rcl in rclcpp
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* fix spelling
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* zero initialize
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* check return value and cleanup
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* use throw_from_rcl_error
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* cleanup error handling
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* [rclcpp_action] Action client holds weak pointers to goal handles
Fixes#861
It is against the design of ROS actions to rely on the status topic for the core implementation,
instead it should just be used for introspection.
Rather than relying on the status topic to remove references to goal handles, the action client
instead holds weak pointers to the goal handles. This way as long as a user holds a reference to
the goal handle they can use it to interact with the action client.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Move cleanup logic to the end of the function
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Add TODO
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Log debug messages when dropping a weak references to goal handles
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Improve documentation
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Fixes https://github.com/ros2/rclcpp/issues/955
There are currently two public APIs for users to get the result of a goal.
This change deprecates one of the APIs, which was considered to be unsafe as
it may result in a race with user-code and raise an exception.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* API review part 1
Signed-off-by: William Woodall <william@osrfoundation.org>
* update pre second meeting
Signed-off-by: William Woodall <william@osrfoundation.org>
* notes from 2020-03-23 meeting
Signed-off-by: William Woodall <william@osrfoundation.org>
* online review comments
Signed-off-by: William Woodall <william@osrfoundation.org>
* Increasing test coverage of rclcpp_components
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* PR fixup
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Fixup
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Removing throws test for now
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Add received message age metric to topic statistics
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
* Add unit tests
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
* Add IMU messages in unit test
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
* Use system time instead of steady time
Test received message age stats values are greater than 0
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
* Fix test warnings
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
* Replace IMU messages with new dummy messages
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
* Remove outdated TODO and unused test variables
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
* Address review comments
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
* Address review comments
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
* Re-add message with header for unit testing
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
* Address message review feedback
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
* Remove extra newline
Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
* Address more review feedback
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
* Fix Windows failure
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
* Only set append_library_dirs once
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
