Commit graph

86 commits

Author SHA1 Message Date
ahcorde
316a21ae5d
changelog
Signed-off-by: ahcorde <ahcorde@gmail.com>
2020-11-03 08:31:09 +01:00
brawner
b62b83b5cd Add mocking unit tests for rcl_yaml_param_parser (coverage part 3/3) (#772)
* Add mocking unit tests for rcl_yaml

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* deallocate test_path

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Fix memory leaks

Signed-off-by: Stephen Brawner <brawner@gmail.com>
2020-10-09 09:02:32 +02:00
brawner
08bbdde860 Add fault-injection unit tests (coverage part 2/3) (#766)
* Fault injection tests for rcl_yaml

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Pause fault injection

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* variant_copy

Signed-off-by: Stephen Brawner <brawner@gmail.com>
2020-10-09 09:02:32 +02:00
brawner
79e2e044d3 Add basic unit tests for refactored functions in rcl_yaml_param_parser (coverage part 1/3) (#771)
* Add basic unit tests for refactored functions

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Fix memory errors

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* headers moved

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Addressing feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Switch to decltype

Signed-off-by: Stephen Brawner <brawner@gmail.com>
2020-10-09 09:02:32 +02:00
brawner
a34c4816c9 Fix mem leaks in unit test from 776 (#779)
Signed-off-by: Stephen Brawner <brawner@gmail.com>
2020-10-09 09:02:32 +02:00
tomoya
bf2029acf8 remove debugging statements. (#755)
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
2020-10-09 09:02:32 +02:00
ahcorde
bba14e9318 Removed variant benchmark
Signed-off-by: ahcorde <ahcorde@gmail.com>
2020-10-08 08:45:33 +02:00
Scott K Logan
b981951677 Several memory-related fixes for rcl_variant_t benchmarks (#813)
* Remove a bunch of redundant nullptr assignments
* Fix some memory leaks
* Ensure source string is deallocated
* Remove redundant array size assignment

Signed-off-by: Scott K Logan <logans@cottsay.net>
2020-10-08 08:45:33 +02:00
Alejandro Hernández Cordero
f1bc651394 Improved rcl_yaml_param_parser benchmark test (#810)
Signed-off-by: ahcorde <ahcorde@gmail.com>
2020-10-08 08:45:33 +02:00
Alejandro Hernández Cordero
1c08083888 Added benchmark test to rcl_yaml_param_parser (#803)
* Added benchmark test to rcl_yaml_param_parser

Signed-off-by: ahcorde <ahcorde@gmail.com>

* reset heap counters

Signed-off-by: ahcorde <ahcorde@gmail.com>

* updated benchmark tests

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Replace BENCHMARK_DEFINE_F and BENCHMARK_REGISTER_F with BENCHMARK_F

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Used rcpputils for the path

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Clean up the CMake dependencies

Signed-off-by: Scott K Logan <logans@cottsay.net>

* Updated test

Signed-off-by: ahcorde <ahcorde@gmail.com>

* udpated test name

Signed-off-by: ahcorde <ahcorde@gmail.com>

Co-authored-by: Scott K Logan <logans@cottsay.net>
2020-10-08 08:45:33 +02:00
Jacob Perron
46e9ff8032 1.1.8 2020-10-07 10:41:11 -07:00
brawner
7c1f2746f4
Fix yaml parser error when meets .nan (refactor on #754) (#781) (#785)
* Fix yaml parser error when meets .nan

Signed-off-by: Ada-King <Bingtao.Du@sony.com>

Correct code style

Signed-off-by: Ada-King <Bingtao.Du@sony.com>

Modify as suggested

Signed-off-by: Ada-King <Bingtao.Du@sony.com>

Improve test

Signed-off-by: Ada-King <Bingtao.Du@sony.com>

Fix minor flaw

Signed-off-by: Ada-King <Bingtao.Du@sony.com>

Fix minor flaw again

Signed-off-by: Ada-King <Bingtao.Du@sony.com>

Satisfy windows CI

Signed-off-by: Ada-King <Bingtao.Du@sony.com>

Change the match rule for special float

Signed-off-by: Ada-King <Bingtao.Du@sony.com>

Distinguish +.inf and -.inf

Signed-off-by: Ada-King <Bingtao.Du@sony.com>

* Remove unnecessary #include change.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Add in two more necessary includes.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

Co-authored-by: Ada-King <Bingtao.Du@sony.com>
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Stephen Brawner <brawner@gmail.com>

Co-authored-by: Ada-King <Bingtao.Du@sony.com>
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
2020-10-05 18:12:26 -07:00
brawner
2c513aa0ed
[foxy backport] Refactor parser.c for better testability (#754) (#784)
* Refactor parser.c for better testability (#754)

* Refactor rcl_yaml_param_parser for better testability

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Reorder parser.c to match parser.h

Signed-off-by: Stephen Brawner <brawner@gmail.com>

squash! Reorder parser.c to match parser.h

* Refactor yaml_variant.c for deduplication

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* ADD_VALUE_TO_SIMPLE_ARRAY for deduplication

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Remove fprintf

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Move headers to src directory

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Rebase #780

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Missing includes

Signed-off-by: Stephen Brawner <brawner@gmail.com>
2020-10-05 18:01:07 -07:00
brawner
d22d923931
Don't overwrite cur_ns pointer if reallocation fails (#780) (#783)
Signed-off-by: Stephen Brawner <brawner@gmail.com>
2020-10-01 16:25:16 -07:00
brawner
2e9ce913db
Set yaml_variant values to NULL on finalization (#765) (#782)
Signed-off-by: Stephen Brawner <brawner@gmail.com>
2020-10-01 15:06:52 -07:00
Michel Hidalgo
a26c9cf575
Fix rcl_parse_yaml_file() error handling. (#776) (#786)
It should not fini its output argument, silently invalidating the given pointer.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
2020-09-24 10:14:41 -03:00
Jacob Perron
a9d8044858 1.1.7 2020-08-03 14:56:23 -07:00
Alejandro Hernández Cordero
aa0967f0e2
Removed doxygen warnings (#712) (#724)
* Removed doxygen warnings

Signed-off-by: ahcorde <ahcorde@gmail.com>

* added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
2020-07-22 15:23:48 +02:00
Jacob Perron
f172071469 1.1.6 2020-07-07 20:31:47 -07:00
Jacob Perron
2be7dc89ad 1.1.5 2020-06-03 20:23:42 -07:00
Jacob Perron
f82eecafdd 1.1.4 2020-06-02 23:40:26 -07:00
Jacob Perron
06bd93bc87 1.1.3 2020-06-01 10:46:25 -07:00
Chris Lalancette
83364247cd
Add Security Vulnerability Policy pointing to REP-2006. (#661)
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
2020-05-29 16:49:34 -04:00
Ivan Santiago Paunovic
21b5396517 1.1.2 2020-05-28 14:13:20 +00:00
Ivan Santiago Paunovic
fad0963cf1 Changelogs
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
2020-05-28 14:12:26 +00:00
Jacob Perron
75e475819b 1.1.1 2020-05-26 19:30:32 -07:00
brawner
65c2d46ee0
Increase rcl_yaml_param_parser test coverage (#656)
* Cleanup and address issues in parser.c

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

squash! Cleanup and address issues in parser.c

* Increase test coverage of parser

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

* PR Fixup

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

* PR Fixup

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

Co-authored-by: Stephen Brawner <stephenbrawner@verbsurgical.com>
2020-05-26 12:45:36 -07:00
Ivan Santiago Paunovic
30e0536a1d 1.1.0 2020-05-22 14:46:38 +00:00
Ivan Santiago Paunovic
35944ce9cd Changelogs
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
2020-05-22 14:46:07 +00:00
brawner
7f57396fb4
Updated QDs for 1.0 (#647)
Signed-off-by: Stephen Brawner <brawner@gmail.com>
2020-05-12 17:55:21 -07:00
Jacob Perron
d3217513b1 1.0.0 2020-05-12 14:02:12 -07:00
Chris Lalancette
cec60fb831 0.9.1 2020-05-08 15:18:17 +00:00
Chris Lalancette
752a8511f2 Changelog.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
2020-05-08 15:18:05 +00:00
Alejandro Hernández Cordero
0f0424fe7f
Included features (#644)
* Included features

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* fix on rcl_yaml_param_parser doxygen

Signed-off-by: ahcorde <ahcorde@gmail.com>
2020-05-08 08:48:03 +02:00
brawner
728b8b89bd
Quality Declarations for rcl_action, rcl_lifecycle, yaml_parser (#641)
* READMEs and Quality Declarations for rcl_action, rcl_lifecycle, yaml_parser

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>
2020-05-07 09:35:41 +02:00
Jacob Perron
47501d17c5 0.9.0 2020-04-29 09:41:48 -07:00
Alejandro Hernández Cordero
0d27a03a4f
added rcl yaml param parser doxyfile (#634)
* Added rcl yaml param parser Doxyfile

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed predefined tag

Signed-off-by: ahcorde <ahcorde@gmail.com>
2020-04-29 09:17:30 +02:00
Alejandro Hernández Cordero
9ade5a114d
Fixed rcl_yaml_param_parser package description (#637)
Signed-off-by: ahcorde <ahcorde@gmail.com>
2020-04-28 20:26:02 +02:00
Dirk Thomas
3d1337d0fc
fix usage to not expose underlying yaml (#630)
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
2020-04-22 15:14:47 -07:00
Dirk Thomas
0a795cc776
export targets in a addition to include directories / libraries (#621)
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
2020-04-20 09:33:04 -07:00
Dirk Thomas
918dd5a4d3
remove usage of undefined CMake variable (#620)
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
2020-04-17 12:48:32 -07:00
y-okumura-isp
85948c7c3c
Rcl issues 469 test arguments (#564)
* `rcl_arguments_fini` free external_log_config_file (#469)

* Fix memory leak in `parse_key` in parser.c

Signed-off-by: y-okumura-isp <y-okumura@isp.co.jp>
2020-03-12 10:12:30 -04:00
Dirk Thomas
4b9c0a30be
code style only: wrap after open parenthesis if not in one line (#565)
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
2020-02-03 09:06:35 -08:00
Shane Loretz
9034c406c2 0.8.3
Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
2019-11-08 11:26:28 -08:00
Shane Loretz
3d3b77c1fd 0.8.2
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
2019-10-23 17:35:56 -07:00
Dan Rose
c1739354b1 Specify test working directory (#529)
Avert breakage from https://github.com/ament/ament_cmake/pull/206
Signed-off-by: Dan Rose <dan@digilabs.io>
2019-10-23 13:40:43 -07:00
Chris Lalancette
cdf1b4d17d
Remove the maximum string size. (#524)
It wasn't preventing any allocations from happening, so it
doesn't seem to serve much purpose.  Also remove the tests
for the maximum string size.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
2019-10-21 18:21:38 -04:00
Chris Lalancette
0198ffef71 0.8.1 2019-10-08 12:09:24 +00:00
Chris Lalancette
e261e5c1a8 Changelog.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
2019-10-08 12:09:10 +00:00
Chris Lalancette
d655147310 0.8.0 2019-09-26 18:45:43 +00:00