niklas/rclcpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
938 commits 1 branch 0 tags 3.3 MiB
Commit graph

938 commits

This branch
This branch
All branches
Author SHA1 Message Date
Dan Rose
96ebf59a60
Don't check lifespan on publisher QoS (#1002) 
Signed-off-by: Dan Rose <dan@digilabs.io>
 2020-03-10 17:51:40 -03:00
DongheeYe
d508ce3492
Fix get_parameter_tyeps of AsyncPrameterClient results are always empty (#1019) 
Signed-off-by: Donghee Ye <donghee.ye@samsung.com>
 2020-03-09 13:58:23 -07:00
Jacob Perron
977c6a5de1
Cleanup node interfaces includes (#1016) 
Some headers were being included even though they are not required and other headers were being included transitively.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2020-03-09 13:36:58 -07:00
Dirk Thomas
87fa896e38
Add ifdefs to remove tracing-related calls if tracing is disabled (#1001) 
* Add ifdefs to remove tracing-related calls if tracing is disabled

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>

* Move ifndefs inside register_callback_for_tracing

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
 2020-03-05 11:03:19 -08:00
Jacob Perron
68cb936bca
Include missing header in node_graph.cpp (#994) 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2020-03-04 18:00:37 -08:00
Jacob Perron
603a4a85fb
Add missing includes of logging.hpp (#995) 
The header is needed wherever RCLCPP_* logging macros are used.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2020-03-04 12:59:09 -08:00
Jacob Perron
e3949cb5ec
Fix unknown macro errors reported by cppcheck 1.90 (#1000) 
It was complaining about an unknown macro RCLCPP_SMART_PTR_DEFINITIONS.
Passing rclcpp include directories to cppcheck resolves the errors
reported in rclcpp_action and rclcpp_lifecycle.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2020-03-04 09:05:21 -08:00
Jacob Perron
d48d4608e5
Zero initialize publisher GID in subscription intra process callback (#1011) 
This fixes a cppcheck error that was detected when including the rclcpp headers in rclcpp_action and rclcpp_lifecycle.
It is not clear to me why cppcheck does not report the unitialized member when testing rclcpp directly.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2020-03-03 09:28:20 -08:00
Alejandro Hernández Cordero
fffbe5972c
removed ament_cmake from package and cmakelists.txt (#989) 
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
 2020-03-03 10:44:37 +01:00
Chris Lalancette
f30329fbec
Switch to using new rcutils_strerror. (#993) 
* Switch to using new rcutils_strerror.

Also increase timeouts for test_logging, which should reduce flakes on Windows.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-02-28 15:22:25 -05:00
Michel Hidalgo
1644e926f9 Ensure all rclcpp::Clock accesses are thread-safe. 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-02-28 09:43:59 -03:00
Michel Hidalgo
b100b39353 Use a PIMPL for rclcpp::Clock implementation 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-02-28 09:43:59 -03:00
Alejandro Hernández Cordero
09bde58ba7
[rclcpp] replace rmw_implementation for rmw dependency in package.xml (#990) 
* rclcpp removed rmw_implementation

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

* rclcpp added rmw as a depend in package.xml

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

* rclcpp alpha order package.xml

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
 2020-02-28 08:59:52 +01:00
Alejandro Hernández Cordero
88ce87457c
[rclcpp_action] removed rosidl_generator_c dependency (#992) 
* rclcpp_action removed rosidl_generator_cpp and rosidl_generator_c dependencies

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

* rclcpp_action restored rosidl_generator_c dependency

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

* rclcpp action alpha order CMakeLists.txt

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
 2020-02-27 18:25:10 +01:00
Alejandro Hernández Cordero
090e1cbec3
[rclcpp lifecycle] removed rmw_implementation from package.xml (#991) 
* rclcpp lifecycle removed rmw_implementation from package.xml

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

* rclcpp lifecycle added rmw depend in package.xml

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
 2020-02-27 08:39:11 +01:00
Christophe Bedard
2371923761
Add missing service callback registration tracepoint (#986) 
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
 2020-02-26 09:51:38 -03:00
Ivan Santiago Paunovic
9c002c65da
Rename rmw_topic_endpoint_info_array count to size (#996) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-02-20 14:11:18 -03:00
Barry Xu
2d9c6ea3a7
Implement functions to get publisher and subcription informations like QoS policies from topic name (#960) 
Signed-off-by: Barry Xu <Barry.Xu@sony.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
Co-authored-by: Miaofei Mei <ameision@hotmail.com>
 2020-02-14 17:25:03 -03:00
Dirk Thomas
7c1721a0b3
code style only: wrap after open parenthesis if not in one line (#977) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-02-03 09:06:57 -08:00
Ivan Santiago Paunovic
c2b855897f
Accept taking an rvalue ref future in spin_until_future_complete (#971) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-01-30 09:35:11 -03:00
mschickler
3ec882cd2d Allow node clock use in logging macros (#969) (#970) 
Capturing a cached reference allows a clock object that is not a local
(e.g. the one returned by Node::get_clock()) to be passed to the throttle
logging macro.

Signed-off-by: Matt Schickler <mschickler@gmail.com>
Co-Authored-By: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-01-28 14:08:00 -03:00
Jacob Perron
fdaf96f217
Change order of deprecated and visibility attributes (#968) 
This fixes a build issue with Clang.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2020-01-22 15:18:09 -08:00
Jacob Perron
7a8606fb39
Deprecated is_initialized() (#967) 
The function was previously documented as being deprecated, but this change adds compiler warnings if it is used.
Ignore compiler warnings where the function is being tested and change to the preferred usage elsewhere.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2020-01-22 14:11:58 -05:00
Sean Kelly
54ad49703a Don't specify calling convention in std::_Binder template (#952) 
Fix for a build error on 32-bit Windows. Member functions use the
__thiscall convention by default which is incompatible with __cdecl.

Signed-off-by: Sean Kelly <sean@seankelly.dev>
 2020-01-21 13:16:32 -05:00
Dino Hüllmann
9037bba7f1 logging.hpp: Added missing include (#964) 
Signed-off-by: Dino Hüllmann <dino.huellmann@bam.de>
 2020-01-16 19:00:00 -05:00
Dirk Thomas
b25213a186 fix style from #963 2020-01-13 15:08:19 -08:00
brawner
9dbd124f1d Assigning make_shared result to variables in test (#963) 
* Assigning make_shared result to variables in test
Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-01-13 14:23:41 -08:00
Mikael Arguedas
d2723fb159 fix unused parameter warning (#962) 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
 2020-01-12 09:57:32 -08:00
Ivan Santiago Paunovic
01d03c5d4e
Stop retaining ownership of the rcl context in GraphListener (#946) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-01-07 10:01:36 -03:00
Ivan Santiago Paunovic
914ea81c63
Clear sub contexts when starting another init-shutdown cycle (#947) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-01-03 09:55:11 -03:00
Ivan Santiago Paunovic
fd3655c26c
Avoid possible UB in Clock jump callbacks (#954) 
* Avoid possible UB in Clock jump callbacks

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2019-12-20 12:04:29 -03:00
Michel Hidalgo
efbce4a11b
Handle unknown global ROS arguments. (#951) 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2019-12-19 13:38:28 +00:00
Jacob Perron
0c66d0c725
Remove absolute path from installed CMake code (#948) 
Otherwise, rclcpp_components_register_node() fails if used from a fat archive.

Related to https://github.com/ros2/ros2/issues/606.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2019-12-17 15:23:16 -08:00
Dirk Thomas
afbdfc1dec
fix function docblock, check for unparsed arguments (#945) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2019-12-16 14:39:37 -08:00
Marya Belanger
26bc60704c
New README (#942) 
* New README

* dashing to eloquent for api docs

* remove "accepted"

Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org>

* components > APIs

Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org>
 2019-12-11 19:39:06 +03:00
Steven! Ragnarök
7e3f5511c4
Mark get_clock() as override to fix clang warnings. (#939) 
Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
 2019-12-09 22:27:44 -05:00
Steven Macenski
9d5947108b Create node clock calls const (try 2) (#922) 
* create node clock calls const

Signed-off-by: stevemacenski <stevenmacenski@gmail.com>

* two methods for get clock, one const

Signed-off-by: stevemacenski <stevenmacenski@gmail.com>

* changing APIs for NodeClock and NodeClockInterface

Signed-off-by: stevemacenski <stevenmacenski@gmail.com>

* changing RCLCPP_LIFECYCLE_PUBLIC from RCLCPP_PUBLIC for rclcpp lifecycle node get_clock const method

Signed-off-by: stevemacenski <stevenmacenski@gmail.com>
 2019-12-06 14:03:58 -08:00
Zachary Michaels
6ba0f59fed Fix asserts on shared_ptr::use_count; expects long, got uint32 (#936) 
* Fix asserts on shared_ptr::use_count; expects long, got uint32

Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>

* Add suffix to integer literals to make them longs

Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>

* Add missing L

Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
 2019-12-06 11:25:58 -08:00
Jacob Perron
6ef23841f4
Fix typo in action client logger name (#937) 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2019-12-05 16:29:13 -08:00
Ivan Santiago Paunovic
4f84948a8e
Use absolute topic name for parameter events (#929) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2019-12-05 10:25:59 -03:00
Barry Xu
e494b3efad Add enable_rosout into NodeOptions. (#900) 
* Add disable_rosout into NodeOptions.

Signed-off-by: Barry Xu <Barry.Xu@sony.com>

* Update comments

Signed-off-by: Barry Xu <Barry.Xu@sony.com>

* keep implementation consistency by using enable_rosout name

Signed-off-by: Barry Xu <Barry.Xu@sony.com>

* fix error comment

Signed-off-by: Barry Xu <Barry.Xu@sony.com>

* add test case for node options

Signed-off-by: Barry Xu <Barry.Xu@sony.com>

* fix source about copy value and reset rcl_node_options, add more test cases

Signed-off-by: Barry Xu <Barry.Xu@sony.com>
 2019-12-03 10:08:06 -03:00
Claire Wang
e2efb76477
Merge pull request #897 from monidzik/upstream-apex-changes 
Removing "virtual", adding "override" keywords in the package
 2019-12-02 14:22:25 -08:00
Barry Xu
3288bdd2c5 Use weak_ptr to store context in GraphListener (#906) 
* Use weak_ptr to store context in graph listener

Signed-off-by: Barry Xu <Barry.Xu@sony.com>
 2019-12-02 18:38:41 -03:00
Ivan Santiago Paunovic
5867e52d68
Complete published event message when declaring a parameter (#928) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2019-11-29 10:01:10 -03:00
Devin Bonnie
3eb1fe52d7 Fix duration.cpp lint error (#930) 
* Fix duration.cpp lint error

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Apply review format suggestion

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
 2019-11-27 13:58:17 -08:00
Todd Malsbary
59e7bbbe7c Intra-process subscriber should use RMW actual qos. (ros2#913) (#914) 
* Intra-process subscriber should use RMW actual qos. (ros2#913)

Signed-off-by: Todd Malsbary <todd.malsbary@intel.com>
 2019-11-25 09:42:09 -03:00
monidzik
88a342db29 Type conversions fixes (#901) 
* Fix type conversions

Signed-off-by: Monika Idzik <monika.idzik@apex.ai>

* Add static_casts

Signed-off-by: Monika Idzik <monika.idzik@apex.ai>

* Address PR comments

Signed-off-by: Monika Idzik <monika.idzik@apex.ai>

* Remove one time use variable

Signed-off-by: Monika Idzik <monika.idzik@apex.ai>
 2019-11-22 10:23:55 -08:00
Monika Idzik
c024189773 Add override keyword to functions 
Signed-off-by: Monika Idzik <monika.idzik@apex.ai>
 2019-11-22 18:02:00 +01:00
Monika Idzik
ef52953824 Remove unnecessary virtual keywords 
Signed-off-by: Monika Idzik <monika.idzik@apex.ai>
 2019-11-22 17:55:20 +01:00
roger-strain
b1dc6f36b9 Only check for new work once in spin_some (#471) (#844) 
To prevent the Executor::spin_some() method for potentially running
indefinitely long.

Distribution Statement A; OPSEC #2893

Signed-off-by: Roger Strain <rstrain@swri.org>
 2019-11-22 13:19:47 -03:00