niklas/rcl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
792 commits 1 branch 0 tags 2.4 MiB
Commit graph

792 commits

This branch
This branch
All branches
Author SHA1 Message Date
Jacob Perron
f91a556bcb
fix test_info_by_topic flaky. (#859) (#944) 
* fix test_info_by_topic flaky using GraphCache interface

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

Co-authored-by: tomoya <Tomoya.Fujita@sony.com>
 2021-10-15 10:07:57 -07:00
Jacob Perron
f96196512e 1.1.11 2021-04-14 14:35:19 -07:00
shonigmann
f4c3aab4b3
updating quality declaration links (re: ros2/docs.ros2.org#52) (#910) 
Signed-off-by: Simon Honigmann <shonigmann@blueorigin.com>

Co-authored-by: Simon Honigmann <shonigmann@blueorigin.com>
 2021-04-02 08:24:01 +02:00
Jacob Perron
7ddea6c155 1.1.10 2020-12-09 17:10:41 -08:00
Stephen Brawner
6dbb394d2e
rcl_action: address various clang static analysis fixes (#864) (#875) 
* Address various clang static analysis fixes

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Add gtest assert

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Taking array by reference

Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-12-09 09:25:40 -08:00
Stephen Brawner
814d958984
Update build.ros2.org links (#868) 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-11-30 15:52:43 -08:00
Stephen Brawner
12e216c74d
[foxy] Update QD to QL 1 (#867) 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-11-25 16:32:06 -08:00
Alejandro Hernández Cordero
4376552e7c
[Backport Foxy] Update QD (#843) 
* Update tracetools' QL to 2 in rcl's QD (#690)

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>

* Fix link to latest API docs (#692)

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>

* Update quality declaration and coverage (#674)

* Update quality level and coverage

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed wording and links

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Updated QD

Signed-off-by: ahcorde <ahcorde@gmail.com>

* udpate QD links to foxy

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Update tracetools QL and add to rcl_lifecycle's QD (#845)

List tracetools in rcl_lifecycle's QD

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>

* update QL dependencies on rcl_yaml_param_parser

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Updated QD

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Updated QD

Signed-off-by: ahcorde <ahcorde@gmail.com>

Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Co-authored-by: Jorge Perez <jjperez@ekumenlabs.com>
 2020-11-05 08:10:57 +01:00
ahcorde
f911664ca5 Removed set_log_level test 
Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-11-03 20:17:19 +01:00
ahcorde
f08c1a2bdc Adapted logging test to Foxy 
Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-11-03 20:17:19 +01:00
Michel Hidalgo
d8a691f82c Complete rcl package's logging API test coverage. (#747) 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-11-03 20:17:19 +01:00
ahcorde
9090625982
1.1.9 2020-11-03 08:31:48 +01:00
ahcorde
316a21ae5d
changelog 
Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-11-03 08:31:09 +01:00
Dirk Thomas
6bbe229fac increase timeouts in test_services fixtures for Connext (#745) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-11-02 16:22:11 +01:00
Chris Lalancette
90ce16dfd8 Add a semicolon to RCUTILS_LOGGING_AUTOINIT. (#816) 
This makes it look like a C statement.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-11-02 16:22:11 +01:00
Chris Lalancette
1f7baf2ee5 Make sure to always check return values. (#840) 
* Make sure to always check return values.

Pointed out by clang static analysis, we should always
check these return values.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-11-02 16:22:11 +01:00
Jacob Perron
fd2f427563 Zero initialize events an size_of_events members of rcl_wait_set_t (#841) 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2020-11-02 16:22:11 +01:00
Jacob Perron
675dbac13f Return OK when finalizing zero-initialized contexts (#842) 
Resolves #814

This is consistent behavior with finalizing other types of zero-initialized objects.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2020-11-02 16:22:11 +01:00
Chris Lalancette
885fa21a89 Make sure to check the return value of rcl APIs. (#838) 
This is just a further check to ensure the test is correct,
and also gets rid of a slew of dead store warnings from
clang static analysis.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-11-02 16:22:11 +01:00
Chen Lihui
0d353dde87 Fix memory leak because of mock test (#800) 
* Fix memory leak because of mock test

Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-11-02 16:22:11 +01:00
Chen Lihui
22d4eee1a7 Fix that not to deallocate event impl in some failure case (#790) 
* Fix that not to deallocate event impl in some failure case

Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-11-02 16:22:11 +01:00
Chen Lihui
5dc097b9bb calling fini functions to avoid memory leak (#791) 
* Fix test memory leaks

1.  calling rcutils_string_map_fini to avoid memory leak
2.  Fix memory leak that not to call rcutils_string_array_fini for enclaves
3.  Fix that not to rcutils_string_array_fini for node_names_2 and node_namespaces_2
4.  Fix that not to rcl_log_levels_fini for copied_log_levels
5.  Fix that not to call rmw_security_options_fini for options
6.  Call test_msgs__srv__BasicTypes_Request__fini for service_request in the end

Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
 2020-11-02 16:22:11 +01:00
ahcorde
2746f51f37 Fixed log level in backported foxy tests 
Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-11-02 16:22:11 +01:00
Michel Hidalgo
424296b153 Bump rcl arguments' API test coverage. (#777) 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Michel Hidalgo
4271bcf2dd Fix rcl arguments' API memory leaks and bugs. (#778) 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Jorge Perez
0613045684 Add coverage tests wait module (#769) 
* Add coverage tests wait module
* Add fault injection test
* Add zero_init allocator test to init
* Remove bomb allocator test
* Add better handling fault injection
* Add comment to fault injection tests
* Move test to another section

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Jorge Perez
af60a36853 Fix wait allocation cleanup (#770) 
* Add fix wait.c init/fini allocation on error
* Add test for the fix
* Remove unit tests

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Michel Hidalgo
907a93dacc Bump test coverage. (#764) 
* init/shutdown API
* context fini API
* node init/fini API
* guard condition init/fini API
* security APIs

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Michel Hidalgo
14ef8e02f8 Check rcutils_strdup() outcome immediately. (#768) 
Within rcl_node_init() implementation.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Michel Hidalgo
9be4fe9e43 Cleanup rcl_get_secure_root() implementation. (#762) 
* Do not assume allocation will succeed.
* Do not leak allocated memory on failure.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
brawner
97e066ff64 Add fault injection macros to rcl functions (#727) 
* Add fault injection macros to rcl functions

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-11-02 16:22:11 +01:00
Michel Hidalgo
13ded97050 Yield rcl_context_fini() error codes. (#763) 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Michel Hidalgo
4476c92dd4 Do not invalidate context before successful shutdown. (#761) 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Michel Hidalgo
6d32b6767e Zero initialize guard condition on failed init. (#760) 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Jorge Perez
8d7bb9fe65 Adding tests to arguments.c (#752) 
* Add nullptr tests get_param_files
* Add bad alloc tests
* Add missing tests
* Add bad alloc tests rcl_arguments_copy
* Remove repeated test
* Remove spaces
* Restore erased test
* Relocate test
* Refactor bomb allocator test
* Add missing rcl_reset_error() checks

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Michel Hidalgo
31f5c9963d Extend rcl_expand_topic_name() API test coverage. (#758) 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Jorge Perez
6d95545a9f Add coverage tests 94% service.c (#756) 
* Add tests for fail init
* Add fini tests
* Add tests rcl_take_request_with_info
* Add tests send_response
* Change const strings to constexpr
* Improve test descriptions
* Remove test

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Michel Hidalgo
04210ebdc2 Clean up rcl_expand_topic_name() implementation. (#757) 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
ahcorde
0698835633 Added path_to_fail to mocking_utils in rcl 
Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-11-02 16:22:11 +01:00
Michel Hidalgo
7669ced71b Complete rcl enclave validation API coverage. (#751) 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Jorge Perez
fe2d89d0e1 Fix allocation arguments copy (#748) 
* Change allocation method for copied parameter files
* Add bad allocator test

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Michel Hidalgo
316765b2e0 Fix rcl package's logging API error specs and handling. (#746) 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Jorge Perez
184e3320e3 Fix bug error handling get_param_files (#743) 
* Add bomb allocator
* Fix memory checked for error
* Add tests for bad alloc
* Fix break statement
* Add static keyword to methods added

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Michel Hidalgo
2fabe16d9c Complete subscription API test coverage (#734) 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Jorge Perez
72837b77c6 Add deallocate calls to free strdup allocated memory (#737) 
* Add deallocate calls to free strdup allocated memory
* Add variables to know if free is required
* Reformat not use extra booleans
* Address peer review comments

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Jorge Perez
f3a8bb0127 Add missing calls to rcl_convert_rmw_ret_to_rcl_ret (#738) 
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Jorge Perez
c1bf050bff Add mock tests, publisher 95% coverage (#732) 
* Add mimick test for rcl_publisher_get_subscription_count
* Remove const qualifiers
* Add missing mock suffix
* Improve test description
* Add mock test for rcl_publisher_assert_liveliness
* Add class to init publisher tests
* Add test for mocked rmw_publish
* Add mock test for rcl_publish_serialized
* Mock rcutils_string_map_init to make init fail
* Add mock test making rmw_publisher_get_actual_qos fail
* Add class to ease mimick usage
* Reformat tests to use helper class
* Add mocked rcutils_string_map_init to make init fail
* Add tests mocking loaned functions
* Add mock fail tests for publisher_init
* Add publisher fini fail mock tests
* Add nullptr tests
* Update mocking utilities
* Reformat with macro utility
* Add comments for mocked tests
* Check count_size value after test
* Reformat to use constexpr where possible
* Add variable making clear bad param test
* Add link to original file to help tracking changes

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Jorge Perez
e4004955ad Reformat rmw_impl_id_check to call a testable function (#725) 
* Reformat rmw_impl_id_check to call a testable function
* Reformat to expose the function in the public header
* Reformat style return result
* Expose macro names to be tested with the function checker
* Add test for failing cases of the function
* Set error variable and log in the main caller
* Use format string for logging
* Change name of checker function
* Reset rcl error to avoid overwrite

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00
Chris Lalancette
c8889f2363 Make sure to call rcl_arguments_fini at the end of the test. 
This just prevents a memory leak.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-11-02 16:22:11 +01:00
Jorge Perez
4e14874cf4 Add remap needed null check (#711) 
* Add needed extra null check
* Add test for added check
* Add tests for nullptrs

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
 2020-11-02 16:22:11 +01:00