niklas/rclcpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1084 commits 1 branch 0 tags 3.3 MiB
Commit graph

1084 commits

This branch
This branch
All branches
Author SHA1 Message Date
William Woodall
bf70ce15bf
2.0.0 2020-06-01 21:54:47 -07:00
William Woodall
cf92aad139
changelogs 
Signed-off-by: William Woodall <william@osrfoundation.org>
 2020-06-01 21:51:42 -07:00
Ivan Santiago Paunovic
769a9d0439
Add missing virtual destructors (#1149) 
* Add -Wnon-virtual-dtor -Woverloaded-virtual compiler options

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

* Add missing virtual dtors

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

* please linter

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-06-01 19:58:48 -07:00
Michel Hidalgo
819612aec6
Avoid multiple type topics in tests. (#1150) 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-06-01 20:04:29 -03:00
Ivan Santiago Paunovic
ed68b4bde7
Make test_rate more reliable on Windows and improve error output when it fails (#1146) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-06-01 15:02:38 -03:00
Chris Lalancette
fdf232b7b8
Add Security Vulnerability Policy pointing to REP-2006. (#1130) 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-05-29 16:49:45 -04:00
Ivan Santiago Paunovic
4b9437639a
Add missing header in logging_mutex.cpp (#1145) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-05-29 13:38:36 -03:00
Ivan Santiago Paunovic
56bcc848be
Pass shared pointer by value instead than by const & when possible (#1141) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-05-28 18:48:53 -03:00
Ivan Santiago Paunovic
40e8b01cac
SubscriptionBase::get_subscription_handle() const should return a shared pointer to const value (#1140) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-05-28 15:48:20 -04:00
Chris Lalancette
c9c4253c84 Make sure the Waitable class has a virtual destructor. 
Noticed while reviewing this issue.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-05-28 15:47:39 -04:00
Chris Lalancette
5632fa03ae Hold onto the rcl_{subscription,publisher}_t shared_ptr. 
This keeps it from going out of scope while the executor
is still dealing with QoSEvents.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-05-28 15:47:39 -04:00
Chris Lalancette
4efcfdc16b Make the rcl publisher handle a shared pointer. 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-05-28 15:47:39 -04:00
Alejandro Hernández Cordero
1a48a60a75
Improved rclcpp docblock (#1127) 
* Improved rclcpp docblock

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Improved docblock

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Included feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-05-28 08:34:29 +02:00
tomoya
e3abe8bf7f
Fix lock-order-inversion (potential deadlock) (#1135) 
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
 2020-05-27 19:06:50 -03:00
Ivan Santiago Paunovic
eff11d61bb
Fix test_lifecycle_node.cpp:check_parameters (#1136) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-05-27 16:59:35 -03:00
Ivan Santiago Paunovic
87bb9f9758
Fix potential Construction/Destruction order problem between global contexts vector and Context of static lifetime (#1132) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-05-27 10:21:07 -03:00
Jacob Perron
337984db42 1.1.0 2020-05-26 20:40:26 -07:00
Claire Wang
d13c098feb
Deprecate set_on_parameters_set_callback (#1123) 
* add deprecate statement
* replace tests to use add_on_param fn
* deprecate set_on_pram fn in node_parameters
* deprecate in lifecycle_node and add replacement fn
* update documentation
* add warning suppression to test_node.cpp
* correct namespace in lifecycle_node.cpp
* remove whitespace fix line length in lifecycle_node
* move reset fn to below add_on
* deprecate set_on in test_lifecycle_node
* suppress deprecation warning in node.cpp
* suppress warning in lifecycle_node.cpp

Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
 2020-05-26 19:19:20 -07:00
Claire Wang
01ec06d601
Merge pull request #1134 from ros2/claire/add_missing_fn_lifecyle_node 
add add_on and remove_on fns to deprecate set_on_param fn
 2020-05-26 15:35:13 -07:00
claireyywang
223aeecb53 reduce line length 
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
 2020-05-26 14:39:11 -07:00
claireyywang
e76a1bbc3c revert 
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
 2020-05-26 14:36:40 -07:00
claireyywang
63a48a1998 remove return from void fn 
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
 2020-05-26 13:28:25 -07:00
claireyywang
9de9c466b5 add } 
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
 2020-05-26 12:17:41 -07:00
claireyywang
b3e526ce3c add add_on and remove_on 
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
 2020-05-26 11:47:53 -07:00
Dirk Thomas
0ef9731feb
expose get_service_names_and_types_by_node from rcl in rclcpp (#1131) 
* expose get_service_names_and_types_by_node from rcl in rclcpp

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* fix spelling

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* zero initialize

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* check return value and cleanup

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* use throw_from_rcl_error

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* cleanup error handling

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-05-26 10:26:51 -07:00
Ivan Santiago Paunovic
a5e1418093
Fix thread safety issues related to logging (#1125) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-05-22 18:17:01 -03:00
ChenYing Kuo
4f34562878
Make sure rmw_publisher_options is initialized in to_rcl_publisher_options. (#1099) 
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
 2020-05-22 17:14:48 -03:00
Jacob Perron
c7b62bff71
[rclcpp_action] Action client holds weak pointers to goal handles (#1122) 
* [rclcpp_action] Action client holds weak pointers to goal handles

Fixes #861

It is against the design of ROS actions to rely on the status topic for the core implementation,
instead it should just be used for introspection.

Rather than relying on the status topic to remove references to goal handles, the action client
instead holds weak pointers to the goal handles. This way as long as a user holds a reference to
the goal handle they can use it to interact with the action client.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Move cleanup logic to the end of the function

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Add TODO

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Log debug messages when dropping a weak references to goal handles

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Improve documentation

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2020-05-22 11:41:34 -07:00
Dirk Thomas
8573433c1d
remove empty lines within method signatures (#1128) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-05-22 11:36:32 -07:00
Jacob Perron
64bdef61c8
Deprecate ClientGoalHandle::async_result() (#1120) 
Fixes https://github.com/ros2/rclcpp/issues/955

There are currently two public APIs for users to get the result of a goal.
This change deprecates one of the APIs, which was considered to be unsafe as
it may result in a race with user-code and raise an exception.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2020-05-21 11:39:07 -07:00
William Woodall
2aaeee72a6
[rclcpp] API review March 2020 (#1031) 
* API review part 1

Signed-off-by: William Woodall <william@osrfoundation.org>

* update pre second meeting

Signed-off-by: William Woodall <william@osrfoundation.org>

* notes from 2020-03-23 meeting

Signed-off-by: William Woodall <william@osrfoundation.org>

* online review comments

Signed-off-by: William Woodall <william@osrfoundation.org>
 2020-05-19 10:56:36 -07:00
Alejandro Hernández Cordero
731558aafb
Added features to rclcpp packages (#1106) 
* Added features to rclcpp packages

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback and improved lifecycle docblock

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added ffedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixing error

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-05-15 16:41:25 +02:00
Ivan Santiago Paunovic
0dd14baa32
Make test multi threaded executor more reliable (#1105) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-05-14 14:32:23 -03:00
Alejandro Hernández Cordero
9f04391fbb
[Quality Declaration] Fixed rep links and added more details to dependencies (#1116) 
* Fixed rep links and added more details to dependencies

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed rep link

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-05-13 15:47:05 +02:00
Alejandro Hernández Cordero
ce4c873ae3
Added dockblock to ComponentManager class (#1102) 
* Added dockblock to ComponentManager class

Signed-off-by: ahcorde <ahcorde@gmail.com>

* added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-05-13 08:17:56 +02:00
brawner
df3ba3a279
Update QDs to reflect version 1.0 (#1115) 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-05-12 17:55:49 -07:00
Jacob Perron
cb4bdb7b19 1.0.0 2020-05-12 14:05:31 -07:00
Ivan Santiago Paunovic
803d7f27be
Remove MANUAL_BY_NODE liveliness API (#1107) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-05-12 14:52:26 -03:00
brawner
cac761373f
Increasing test coverage of rclcpp_components (#1044) 
* Increasing test coverage of rclcpp_components

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Removing throws test for now

Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-05-12 10:26:49 -07:00
Karsten Knese
66114c3a4a
use rosidl_default_generators dependency in test (#1114) 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
 2020-05-12 08:29:45 -07:00
Chris Lalancette
ccf2f1c760
Make sure to include what you use. (#1112) 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-05-11 13:32:49 -04:00
Louise Poubel
846e4ce9d3
Mark flaky test with xfail: TestMultiThreadedExecutor (#1109) 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
 2020-05-11 09:16:04 -07:00
Karsten Knese
e24f402238
avoid callback_group deprecation (#1108) 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
 2020-05-08 09:04:38 -07:00
Chris Lalancette
4d1de47df3 0.9.1 2020-05-08 15:40:05 +00:00
Chris Lalancette
5b1877adc4 Changelog. 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-05-08 15:39:57 +00:00
Alejandro Hernández Cordero
e0d0e03078
Added rclcpp lifecycle Doxyfile (#1089) 
* Added rclcpp lifecycle Doxyfile

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed doxyfile

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-05-08 08:48:52 +02:00
Devin Bonnie
d10f7b7c62
Fix tests that were not properly torn down (#1073) 
Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
 2020-05-06 13:04:45 -03:00
Alejandro Hernández Cordero
f160a8bc1d
Added docblock in rclcpp (#1103) 
* Added docblock in rclcpp

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-05-06 09:04:31 +02:00
Alejandro Hernández Cordero
e2dbc5d5d5
Added Quality declaration: rclcpp, rclpp_action, rclcpp_components andrclcpp_lifecycle (#1100) 
* Added Quality declaration: rclcpp, rclpp_action, rclcpp_components, rclcpp_lifecycle

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-05-01 22:41:22 +02:00
Ivan Santiago Paunovic
13c09acfad
Use RCL_RET_SERVICE_TAKE_FAILED and not RCL_RET_CLIENT_TAKE_FAILED when checking a request take (#1101) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-05-01 13:55:46 -03:00