niklas/rclcpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1113 commits 1 branch 0 tags 3.3 MiB
Commit graph

1113 commits

This branch
This branch
All branches
Author SHA1 Message Date
Michel Hidalgo
23ef782e02 Fix rclcpp::NodeOptions::operator= (#1211) 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-10-19 10:25:18 -07:00
brawner
00b4020194 Check period duration in create_wall_timer (#1178) 
* Check period duration in create_wall_timer

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Adding comments

Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-10-19 10:25:18 -07:00
brawner
823e1dd404 Throw exception if rcl_timer_init fails (#1179) 
* Throw exception if rcl_timer_init fails

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Add bad-argument tests for GenericTimer

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Add comments

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Address feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Address feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-10-19 10:25:18 -07:00
brawner
f71d3bfda2
Remove finalization of guard_condition from GraphListener::__shutdown() (#1401) 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-10-13 15:13:43 -07:00
Jacob Perron
cf1be86f5c 2.2.0 2020-10-07 10:50:16 -07:00
Jacob Perron
4dcb0eda68
Fix implementation of NodeOptions::use_global_arguments() (#1176) (#1372) 
`this->node_options_` might still be `nullptr` for a default initialized NodeOptions instance.
`use_global_arguments()` must return `this->use_global_arguments_`, in analogy to `NodeOptions::enable_rosout()`.

Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>

Co-authored-by: Johannes Meyer <johannes@intermodalics.eu>
 2020-10-06 11:33:26 -07:00
Jacob Perron
9c1cbdf6c7
Fix conversion of negative durations to messages (#1188) (#1371) 
* Fix conversion from negative Duration or Time to the respective message type and throw in Duration::to_rmw_time() if the duration is negative.
rmw_time_t cannot represent negative durations.

Constructors and assignment operators can be just defaulted.

Other changes are mainly cosmetical, to make conversions between signed
and unsigned types and between 32-bit and 64-bit types more explicit.

Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>

* Add -Wconversion compiler option and fix implicit conversions that might alter the value

Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>

* Fix usage of fixture class in some unit tests by using gtest macro TEST_F() instead of TEST().

Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>

* Add compiler option -Wno-sign-conversion to fix build with Clang on macOS

Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>

Co-authored-by: Johannes Meyer <johannes@intermodalics.eu>
 2020-10-06 11:30:43 -07:00
brawner
6e6dd9cb1a
[backport foxy] Log error instead of throwing exception in Transition and State reset() mark no except (#1297) (#1378) 
* Log error instead of throwing exception in Transition and State reset(), mark no except (#1297)

* Catch potential exception in destructor and log

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Remove thrown error from reset and mark it no except

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Remove noexcept for ABI compatibility

Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-10-05 15:44:55 -07:00
brawner
45a47c6448
Call vector.erase with end iterator overload (#1314) (#1380) 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-10-05 13:39:42 -07:00
brawner
6e408b79f3
Check waitable for nullptr during constructor (#1315) (#1379) 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-10-05 13:39:22 -07:00
brawner
b843c75ef8
Remove rmw-dependent unit-test checks (#1293) (#1377) 
* Remove rmw-dependent unit-test checks

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Address feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-10-05 13:38:17 -07:00
Dereck Wonnacott
cb1b32ee15
Include original exception in ComponentManagerException (#1157) (#1223) 
* Include original exception in ComponentManagerException

Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com>

* Update rclcpp_components/src/component_manager.cpp

Co-authored-by: tomoya <Tomoya.Fujita@sony.com>
Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com>

Co-authored-by: tomoya <Tomoya.Fujita@sony.com>

Co-authored-by: Martijn Buijs <Martijn.buijs@gmail.com>
Co-authored-by: tomoya <Tomoya.Fujita@sony.com>
 2020-10-01 12:42:49 -07:00
Jacob Perron
b67fa594f8
Fix pub/sub count API tests. (#1203) (#1319) 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-09-18 13:30:25 -07:00
brawner
8bfc8e631f
Reorganize test directory and split CMakeLists.txt (#1173) (#1262) 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-08-19 14:43:28 -07:00
Ivan Santiago Paunovic
75f3d54d57
Add operator!= for duration (#1236) (#1278) 
Signed-off-by: Jannik Abbenseth <jannik.abbenseth@ipa.fraunhofer.de>

Co-authored-by: Jannik Abbenseth <ipa-jba@users.noreply.github.com>
 2020-08-18 09:58:50 -03:00
Jacob Perron
27e59d930a 2.1.0 2020-08-03 15:03:27 -07:00
Jacob Perron
ce5de8757d
Warn about unused result of add_on_set_parameters_callback (#1238) (#1244) 
If the user doesn't retain a reference to the returned shared pointer there will be zero references and their callback will be unregistered.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2020-08-03 12:10:27 -07:00
brawner
6ea67a4e9f
Add missing RCLCPP_PUBLIC to ~StaticExecutorEntitiesCollector (#1227) (#1228) 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-07-14 09:54:15 -07:00
brawner
5f6bf45202
Remove recreation of entities_collector (#1217) (#1224) 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-07-13 09:50:41 -07:00
Jacob Perron
dc528ad710 2.0.2 2020-07-07 21:07:12 -07:00
Dirk Thomas
26e824c7c0
link against thread library where necessary (#1210) (#1214) 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
 2020-07-07 20:34:33 -07:00
tomoya
3a3ba55fa2
fix exception message on rcl_clock_init (#1182) (#1193) 
* fix exception message on rcl_clock_init.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

* error messages start with lower case.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
 2020-06-25 09:45:13 -07:00
Jacob Perron
1745db6dcd 2.0.1 2020-06-23 17:32:15 -07:00
brawner
7ed387f862
Add create_publisher include to create_subscription (#1180) (#1192) 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
 2020-06-23 14:44:39 -07:00
Jacob Perron
a10ae56629
Fix get_node_time_source_interface() docstring (#988) (#1185) 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
 2020-06-23 10:44:19 -07:00
Alejandro Hernández Cordero
1f000b8d97
Fixed doxygen warnings (#1163) (#1191) 
Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-06-23 19:43:41 +02:00
Ivan Santiago Paunovic
c14f46e6f3 Check if context is valid when looping in spin_some (#1167) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-06-17 09:52:04 -03:00
DongheeYe
70e1830ecd Fix spin_until_future_complete: check spinning value (#1023) 
Signed-off-by: Donghee Ye <donghee.ye@samsung.com>

Make Executor::spin_once_impl private before backporting, to avoid API compatibility issues

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-06-17 09:52:04 -03:00
Devin Bonnie
77564eb2ff
Add check for invalid topic statistics publish period (#1151) (#1172) 
* Add check for invalid topic statistics publish period

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Update documentation

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address doc formatting comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Update doc spacing

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
 2020-06-15 10:25:17 -07:00
William Woodall
bf70ce15bf
2.0.0 2020-06-01 21:54:47 -07:00
William Woodall
cf92aad139
changelogs 
Signed-off-by: William Woodall <william@osrfoundation.org>
 2020-06-01 21:51:42 -07:00
Ivan Santiago Paunovic
769a9d0439
Add missing virtual destructors (#1149) 
* Add -Wnon-virtual-dtor -Woverloaded-virtual compiler options

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

* Add missing virtual dtors

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

* please linter

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-06-01 19:58:48 -07:00
Michel Hidalgo
819612aec6
Avoid multiple type topics in tests. (#1150) 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
 2020-06-01 20:04:29 -03:00
Ivan Santiago Paunovic
ed68b4bde7
Make test_rate more reliable on Windows and improve error output when it fails (#1146) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-06-01 15:02:38 -03:00
Chris Lalancette
fdf232b7b8
Add Security Vulnerability Policy pointing to REP-2006. (#1130) 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-05-29 16:49:45 -04:00
Ivan Santiago Paunovic
4b9437639a
Add missing header in logging_mutex.cpp (#1145) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-05-29 13:38:36 -03:00
Ivan Santiago Paunovic
56bcc848be
Pass shared pointer by value instead than by const & when possible (#1141) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-05-28 18:48:53 -03:00
Ivan Santiago Paunovic
40e8b01cac
SubscriptionBase::get_subscription_handle() const should return a shared pointer to const value (#1140) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-05-28 15:48:20 -04:00
Chris Lalancette
c9c4253c84 Make sure the Waitable class has a virtual destructor. 
Noticed while reviewing this issue.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-05-28 15:47:39 -04:00
Chris Lalancette
5632fa03ae Hold onto the rcl_{subscription,publisher}_t shared_ptr. 
This keeps it from going out of scope while the executor
is still dealing with QoSEvents.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-05-28 15:47:39 -04:00
Chris Lalancette
4efcfdc16b Make the rcl publisher handle a shared pointer. 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
 2020-05-28 15:47:39 -04:00
Alejandro Hernández Cordero
1a48a60a75
Improved rclcpp docblock (#1127) 
* Improved rclcpp docblock

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Improved docblock

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Included feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
 2020-05-28 08:34:29 +02:00
tomoya
e3abe8bf7f
Fix lock-order-inversion (potential deadlock) (#1135) 
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
 2020-05-27 19:06:50 -03:00
Ivan Santiago Paunovic
eff11d61bb
Fix test_lifecycle_node.cpp:check_parameters (#1136) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-05-27 16:59:35 -03:00
Ivan Santiago Paunovic
87bb9f9758
Fix potential Construction/Destruction order problem between global contexts vector and Context of static lifetime (#1132) 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
 2020-05-27 10:21:07 -03:00
Jacob Perron
337984db42 1.1.0 2020-05-26 20:40:26 -07:00
Claire Wang
d13c098feb
Deprecate set_on_parameters_set_callback (#1123) 
* add deprecate statement
* replace tests to use add_on_param fn
* deprecate set_on_pram fn in node_parameters
* deprecate in lifecycle_node and add replacement fn
* update documentation
* add warning suppression to test_node.cpp
* correct namespace in lifecycle_node.cpp
* remove whitespace fix line length in lifecycle_node
* move reset fn to below add_on
* deprecate set_on in test_lifecycle_node
* suppress deprecation warning in node.cpp
* suppress warning in lifecycle_node.cpp

Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
 2020-05-26 19:19:20 -07:00
Claire Wang
01ec06d601
Merge pull request #1134 from ros2/claire/add_missing_fn_lifecyle_node 
add add_on and remove_on fns to deprecate set_on_param fn
 2020-05-26 15:35:13 -07:00
claireyywang
223aeecb53 reduce line length 
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
 2020-05-26 14:39:11 -07:00
claireyywang
e76a1bbc3c revert 
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
 2020-05-26 14:36:40 -07:00