* Clear members for StaticExecutorEntitiesCollector to avoid shared_ptr dependency
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Increase test timeouts of slow running tests with rmw_connext_cpp
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Fix other issues with connext
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Add unit tests for qos and qos_event files
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* PR Feedback
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Address PR Feedback
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Fix windows CI
Signed-off-by: Stephen Brawner <brawner@gmail.com>
In particular, add API coverage for spin_node_until_future_complete,
spin_until_future_complete, and spin_node_once.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Add test for ParameterService
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Address PR feedback
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Change value used as max representation
* Add coverage tests time
* Add call to detach clock
* Add tests time
* Add duration construction tests
* Add const qualifier to constants
* Add check clock stays the same
* Make operator RCLCPP_PUBLIC
* Add tests exceptions duration
* Fix division by 0 on windows
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
* Test the remaining node public API
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Address PR feedback
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Add comment
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Complete coverage of Parameter and ParameterValue API
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Adding comments
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Add tests for node_options API
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Remove c-style casts
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Improve the error messages in the Executor class.
In particular, make sure to use 'throw_from_rcl_error'
as much as possible.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Allow mimick patching of methods with up to 9 arguments.
This will be needed by the executor tests.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Add in unit tests for the Executor class.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Adjust test_executor for foxy
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
* Add coverage for client API
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* PR feedback
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* PR Feedback
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Remove deprecated executor::FutureReturnCode APIs. (#1327)
While we are here, add in another test for the stream operator for future_return_code.cpp
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Revert removing deprecated API
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
* Increase coverage of publisher/subscription API
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* PR Feedback
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Add coverage for missing API (except executors
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* PR Fixup
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Do not check state
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Increase coverage of node_interfaces, including with mocking rcl errors
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* PR Fixup
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Add mocking utils for rclcpp
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Add coverage for wait_set_policies
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Address PR feedback
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Fix windows issues
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Add test comment
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Add tests getters msg type support
* Add missing fini
* Add tests type_support services
* Reformat to re use test structure
* Remove not needed headers
* Improve teardown test cases
* Add nullptr checks to type_support tests
* Reformat type_support testing
* Replace expect tests with asserts
* "Improve error msg for rcl_service_ini/fini fail"
* Improve test readability
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Without this change, I am unable to build locally.
std_msgs is not declared as a test dependency or find_package'd anywhere, so
I'm not sure why CI ever passed the build phase.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Increase timeouts for connext for long tests
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Fix cmakelists
Signed-off-by: Stephen Brawner <brawner@gmail.com>
It turns out rmw_connext_cpp adds a default waitable that other rmw
implementations do not. Adjusting the unit test to take this into
account in a non-rmw specific manner.
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* fix failing test with Connext since it doesn't wait for discovery
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* Check for added service in the node graph
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Co-authored-by: Stephen Brawner <brawner@gmail.com>
* fix node graph test with Connext and CycloneDDS returning actual data
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* use ADD_FAILURE()
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* Unit tests for memory_strategy classes (part 1)
Adds unit tests for:
* strategies/message_pool_memory_strategy.hpp
* memory_strategy.cpp
* message_memory_strategy.cpp
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Address PR Feedback
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Update with new macros
Signed-off-by: Stephen Brawner <brawner@gmail.com>
