Commit graph

24 commits

Author SHA1 Message Date
5da7e19337 WIP: backport message flow tracing to foxy 2025-05-17 14:50:44 +02:00
brawner
dd62d09042 Add fault injection macros and unit tests to rcl_lifecycle (#731)
* Add fault injection macros and unit tests to rcl_lifecycle

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Address feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>
2020-10-16 19:28:38 +02:00
brawner
7146919c3f
Increase rcl_lifecycle test coverage and add more safety checks (#649)
* Increase test coverage and add more safety checks

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* More coverage

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Concatenating error messages

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

* PR Fixup

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

* Forgot a

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

* PR Fixup

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

* Moving var to top

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

Co-authored-by: Stephen Brawner <stephenbrawner@verbsurgical.com>
2020-05-22 14:44:11 -07:00
Dirk Thomas
2f76cdc9e4
export targets in a addition to include directories / libraries (#635)
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
2020-04-27 10:30:30 -07:00
Alejandro Hernández Cordero
08e0c715c5
Changed rosidl_generator_c/cpp to rosidl_runtime_c/cpp (#588)
* Changed rosidl_generator_c/cpp to rosidl_runtime_c/cpp

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed rcl rcl_runtime_c dependency

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed rcl_action rcl_runtime_c dependency

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed rcl_lifecycle rcl_runtime_c dependency

Signed-off-by: ahcorde <ahcorde@gmail.com>

* keep the originally used dependency type

Signed-off-by: ahcorde <ahcorde@gmail.com>
2020-04-10 12:25:26 +02:00
Alejandro Hernández Cordero
f8f8b41b7d
[rcl lifecycle] removed rmw_implementation from package.xml (#575)
* fixed package.xml

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

* removed rosidl_generator_c dependency

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

* rcl lifecycle restoring rosidl_generator_c dependency

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
2020-03-03 20:28:03 +01:00
ivanpauno
99630cb66d
Using ament_target_dependencies where possible (#400)
* Using ament_target_dependencies where possible

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>

* Modified rcl_add_custom_* to use AMENT_DEPENDENCIES where possible

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>

* Added again osrf_testing_tools_cpp::memory_tools library where needed.

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>

* Modified with PR comment, and replaced forgotten osrf_testing_tools_cpp including

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
2019-03-19 09:22:16 -03:00
Sachin Suresh Bhat
2ff5df0c11 Set symbol visibility to hidden for rcl (#391)
* Set symbol visibility to hidden for rcl

Enabling symbol visibility feature in gcc and clang compilers.
This will hep find symbol export related issues in linux and
potentially reduce compile times.

Discourse topic link:
https://discourse.ros.org/t/set-symbol-visibility-to-hidden-for-rmw-and-rcl-packages/7981

Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>

* Remove WIN specific compiler definition in configure_rcl

Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>

* Rename macro name rcl_set_symbol_visibility_hidden

Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>

* Change macro to args for rcl_set_symbol_visibility_hidden

Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
2019-03-05 18:09:55 -08:00
William Woodall
97ad0013e2
refactor init to not be global (#336)
* refactor init to not be global

Signed-off-by: William Woodall <william@osrfoundation.org>

* style changes

Signed-off-by: William Woodall <william@osrfoundation.org>

* refactor to hide use of C11 atomics in implementation

Signed-off-by: William Woodall <william@osrfoundation.org>

* fix new action tests

Signed-off-by: William Woodall <william@osrfoundation.org>

* use alternative atomic init for Windows support

* updates after rebase

Signed-off-by: William Woodall <william@osrfoundation.org>

* cleanup rmw_init_options before copying

Signed-off-by: William Woodall <william@osrfoundation.org>

* fix two bugs in new init code

* relax validity checks in a few places to facilitate post shutdown cleanup

Signed-off-by: William Woodall <william@osrfoundation.org>

* fixing tests for new API behavior

Signed-off-by: William Woodall <william@osrfoundation.org>

* to allocator -> to allocate

* acutally call rmw_shutdown() and address review comments

Signed-off-by: William Woodall <william@osrfoundation.org>
2018-11-29 21:32:54 -08:00
Dirk Thomas
0ed0581c44
remove use of uninitialized CMake var (#268) 2018-07-11 08:38:41 -07:00
Mikael Arguedas
9a9762f175
Fix rosidl dependencies (#265)
* [rcl_lifecycle] remove rosidl deps as this package doesnt generate any messages

* depend on rosidl_generator_c
2018-07-05 13:01:12 -07:00
Dirk Thomas
bad0f55416
change export order for static linking (#216) 2018-03-22 16:26:33 -07:00
dhood
9f92f8fa37
Switch rcl_lifecyle to ament_cmake_ros (#186) 2017-11-20 14:41:25 -08:00
Karsten Knese
c37bfec072 use rcl_allocator for rcl_lifecycle & namespaced topics (#142)
* use rcl_allocator for rcl_lifecycle

* correct return value interpretation

* fix unsigned comparison

* use namespace for lifecycle in-built topics

* linters
2017-06-16 14:44:06 -07:00
Esteve Fernandez
0f2519944a Explicitly set C11 and C++14 via the CMake variables (#141)
* Explicitly set C99 and C++14 via the CMake variables

* Enable passing CMAKE_C_STANDARD and CMAKE_CXX_STANDARD externally

* Use add_compile_options

* Be more specific about the compiler, independent from the OS

* Check compiler, not OS. Use add_compile_options instead of CMAKE_C_FLAGS and CMAKE_CXX_FLAGS

* add_compile_options() takes a list, not a string

* switch to c11 because of redefinition warnings

avoid typedef redifinition warning on macos

remove todo, compiler come from redefinition of typedef
2017-06-16 13:23:59 -07:00
William Woodall
bed40d3d40 rename {c_}utilities to rcutils (#130) 2017-04-20 11:15:03 -07:00
Karsten Knese
f9e03e51bb use c_utilities packages (#129)
* use c_utilities packages

* use rmw topic validation

* fix rebase/merge commits

* alphabetical includes
2017-04-19 15:40:41 -07:00
Dirk Thomas
c429f2e18c Merge pull request #106 from ros2/use_rmw_impl
use rmw implementation
2017-01-09 08:54:15 -08:00
Dirk Thomas
7a54a0e32f remove obsolete CMake functions 2017-01-06 15:51:47 -08:00
dhood
c6b050e7c7 Fix cmake for appending c/cxx flags (#104) 2017-01-06 07:48:32 +10:00
Dirk Thomas
72e7d03198 use rmw implementation 2017-01-05 12:02:04 -08:00
Mikael Arguedas
e3c1427591 dependency order (#105) 2017-01-05 17:28:08 +01:00
Hunter Allen
5f74a081e1 Require C11 (#101)
* Made CMake enforce the C11 standard during build.
2016-12-23 08:34:17 -08:00
Karsten Knese
a18ef97e5a add rcl lifecycle
* (refactor) add rcl_lifecycle package

* (refactor) cleanup free calls

* (fix) initialize state machine with external node handle

* (dev) use external typesupport

* (fix) use external typesupport

* (fix) cleanup states

* (fix) no pointer comparison in state machine

* (test) refactor for rcl testing purpose

* (test) test suite for lifecycle sequence

* (dev) change to rcl_ret_t

* (test) wrong transition test

* (fix) dependency for isolated build

* (clean) remove std_msgs as a dep

* (fix) enable correct visibility control

* (fix) correct test for initialization

* (fix) correct visibility attributes

* (dev) change default value to lifecycle_msgs

* (clean) style and lifecycle prefix

* (dev) cmake macro get_rcl_lifecycle_information

* (cleanup) remove unused files'

* (cleanup) remove callback pointer

* (debug) add print state machine function

* (review) address review comments

* (bugfix) correct export in information.cmake

* (fix) correct visibility control

* (vcs) fix convertion from size_t to unsigned int

* (typo) fix internal struct name

* const correctness

* get_available_states service

* new service msgs

* tes for multiple instances

* (dev) return codes

* initial refactor

* test default sequence

* refactor state machine

* apply upstream changes

* c++14

* disable state machine print

* address review comments

* uncrustify

* fix comparison with unsigned warning
2016-12-14 09:28:54 -08:00