* Add basic unit tests for refactored functions
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* PR Fixup
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Fix memory errors
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* headers moved
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Addressing feedback
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Switch to decltype
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Remove a bunch of redundant nullptr assignments
* Fix some memory leaks
* Ensure source string is deallocated
* Remove redundant array size assignment
Signed-off-by: Scott K Logan <logans@cottsay.net>
* Added benchmark test to rcl_yaml_param_parser
Signed-off-by: ahcorde <ahcorde@gmail.com>
* reset heap counters
Signed-off-by: ahcorde <ahcorde@gmail.com>
* updated benchmark tests
Signed-off-by: ahcorde <ahcorde@gmail.com>
* Added feedback
Signed-off-by: ahcorde <ahcorde@gmail.com>
* Replace BENCHMARK_DEFINE_F and BENCHMARK_REGISTER_F with BENCHMARK_F
Signed-off-by: ahcorde <ahcorde@gmail.com>
* Used rcpputils for the path
Signed-off-by: ahcorde <ahcorde@gmail.com>
* Clean up the CMake dependencies
Signed-off-by: Scott K Logan <logans@cottsay.net>
* Updated test
Signed-off-by: ahcorde <ahcorde@gmail.com>
* udpated test name
Signed-off-by: ahcorde <ahcorde@gmail.com>
Co-authored-by: Scott K Logan <logans@cottsay.net>
* Fix yaml parser error when meets .nan
Signed-off-by: Ada-King <Bingtao.Du@sony.com>
Correct code style
Signed-off-by: Ada-King <Bingtao.Du@sony.com>
Modify as suggested
Signed-off-by: Ada-King <Bingtao.Du@sony.com>
Improve test
Signed-off-by: Ada-King <Bingtao.Du@sony.com>
Fix minor flaw
Signed-off-by: Ada-King <Bingtao.Du@sony.com>
Fix minor flaw again
Signed-off-by: Ada-King <Bingtao.Du@sony.com>
Satisfy windows CI
Signed-off-by: Ada-King <Bingtao.Du@sony.com>
Change the match rule for special float
Signed-off-by: Ada-King <Bingtao.Du@sony.com>
Distinguish +.inf and -.inf
Signed-off-by: Ada-King <Bingtao.Du@sony.com>
* Remove unnecessary #include change.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Add in two more necessary includes.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Co-authored-by: Ada-King <Bingtao.Du@sony.com>
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Co-authored-by: Ada-King <Bingtao.Du@sony.com>
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
* Cleanup and address issues in parser.c
Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>
squash! Cleanup and address issues in parser.c
* Increase test coverage of parser
Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>
* PR Fixup
Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>
* PR Fixup
Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>
Co-authored-by: Stephen Brawner <stephenbrawner@verbsurgical.com>
It wasn't preventing any allocations from happening, so it
doesn't seem to serve much purpose. Also remove the tests
for the maximum string size.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Support rcl_params_t copies.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Parse parameter overrides from command line.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Parameter overrides' tests passing.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Test rcl_yaml_node_struct_copy() function
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Export rcl_yaml_param_parser as rcl dependency.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Zero initialize parameter overrides before rcl arguments copy.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Initialize local variables early enough.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Simplify rcl package.xml
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Assert arguments sanity in rcl args parsing internal functions.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Extend rcl_yaml_param_parser tests to all parameter types.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Address peer review comments.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Support --remap/-r flags.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Please cpplint
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Increase MAX_STRING_SIZE
It's too short for string length.
It occurs the error when the string field in yaml files are too long....
Signed-off-by: Hyunseok Yang <hyunseok7.yang@lge.com>
* update test to match increased limit
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* Support parameter YAML string value parsing.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Address peer review comments.
- Improve test coverage using new getter API.
- Unify function return style and improve readability.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* Clean up allocations in rcl_yaml_param_parser package tests.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
* use new error handling API from rcutils
Signed-off-by: William Woodall <william@osrfoundation.org>
* use semicolons after macros
Signed-off-by: William Woodall <william@osrfoundation.org>
* use new error handling API from rcutils
Signed-off-by: William Woodall <william@osrfoundation.org>
* minimize vertical whitespace
Signed-off-by: William Woodall <william@osrfoundation.org>
* use semicolons after macros
Signed-off-by: William Woodall <william@osrfoundation.org>
* Implement a basic YAML based parameter parser for ros2 nodes
* Add README file
* Fix the issues after moving from rcutils_yaml_param_parser to rcl_yaml_param_parser
- rename folders from rcutils_yaml_param_parser to rcl_yaml_param_parser
- rename project, header guards and include statements from rcutils_yaml_param_parser to rcl_yaml_param_parser
- move type declaration in separat file and namespace new structures
- Fix the code review comments from Mikael
* Few minor changes
- Changed "params" string to "ros__parameters"
- Add -Wall, -Wextra and -Wpedantic falgs
- Fix the compile warning with the new flags
* Fix the changes made in the design of C structure
- Remove the node_namespaces entry in rcl_params_t
- Change the type of num_nodes and num_params to size_t
* depend on libyaml_vendor (#236)
* Fix cmake setting standard(C and C++) and add byte_array in C struct
* Remove C11 so that it defaults to C99
* [rcl_yaml_param_parser] fix export symbols (#237)
* add visibility macros
* remove unused macro
* Support for multi level node and parameter name spaces
* Additional fixes and cleanups
- Support for string namespace seperator
- Provide parameter structure init function API
- name cleanups
* off by 1
* Call yaml_parser_delete()
* fclose(yaml_file)
* free() allocated paths
* Call yaml_event_delete()
* completely deallcoate string array
* Few cleanup changes
- Add install command into CMakelists.txt
- Replace one of the zero_allocate with reallocate
- Pass allocator state
- Fix int32_t -> rcl_ret_t return value
* Don't include unistd.h
* Use size_t for array indices
* Just pass the allocator in the init function
