niklas/tracetools_analysis
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge branch 'improve-required-event-not-found-message' into 'master'

Browse source 
Improve RequiredEventNotFoundError message

See merge request micro-ROS/ros_tracing/tracetools_analysis!66
This commit is contained in:
Christophe Bedard 2020-05-23 15:22:36 +00:00
commit 0b55273881
1 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
tracetools_analysis/tracetools_analysis/processor/__init__.py
View file

@ -282,7 +282,7 @@ class Processor():
"""Processor class, which dispatches events to event handlers.""" """Processor class, which dispatches events to event handlers."""
class RequiredEventNotFoundError(RuntimeError): class RequiredEventNotFoundError(RuntimeError):
"""When a trace does not contain one event required by an EventHandler.""" """When a trace does not contain at least one event required by an EventHandler."""
pass pass
@ -380,12 +380,15 @@ class Processor():
) -> None: ) -> None:
event_names = self.get_event_names(events) event_names = self.get_event_names(events)
# Check names separately so that we can know which event from which handler is missing # Check names separately so that we can know which event from which handler is missing
missing_events: Dict[str, Set[str]] = defaultdict(set)
for handler in self._expanded_handlers: for handler in self._expanded_handlers:
for name in handler.required_events(): for name in handler.required_events():
if name not in event_names: if name not in event_names:
raise self.RequiredEventNotFoundError( missing_events[handler.__class__.__name__].add(name)
f'missing event {name} for {handler.__class__.__name__}' if missing_events:
) raise self.RequiredEventNotFoundError(
f'missing events: {dict(missing_events)}'
)
def process( def process(
self, self,