niklas/rclcpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Assigning make_shared result to variables in test (#963)

Browse source 
* Assigning make_shared result to variables in test
Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>
This commit is contained in:
brawner 2020-01-13 14:23:41 -08:00 • committed by Dirk Thomas
parent d2723fb159
commit 9dbd124f1d
2 changed files with 12 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
rclcpp/test/test_node.cpp
View file

@ -48,20 +48,23 @@ protected:
*/ */
TEST_F(TestNode, construction_and_destruction) { TEST_F(TestNode, construction_and_destruction) {
{ {
std::make_shared<rclcpp::Node>("my_node", "/ns"); auto node = std::make_shared<rclcpp::Node>("my_node", "/ns");
(void)node;
} }
{ {
ASSERT_THROW( ASSERT_THROW(
{ {
std::make_shared<rclcpp::Node>("invalid_node?", "/ns"); auto node = std::make_shared<rclcpp::Node>("invalid_node?", "/ns");
(void)node;
}, rclcpp::exceptions::InvalidNodeNameError); }, rclcpp::exceptions::InvalidNodeNameError);
} }
{ {
ASSERT_THROW( ASSERT_THROW(
{ {
std::make_shared<rclcpp::Node>("my_node", "/invalid_ns?"); auto node = std::make_shared<rclcpp::Node>("my_node", "/invalid_ns?");
(void)node;
}, rclcpp::exceptions::InvalidNamespaceError); }, rclcpp::exceptions::InvalidNamespaceError);
} }
} }

4
rclcpp/test/test_parameter_client.cpp
View file

@ -69,7 +69,9 @@ TEST_F(TestParameterClient, async_construction_and_destruction) {
{ {
ASSERT_THROW( ASSERT_THROW(
{ {
auto asynchronous_client =
std::make_shared<rclcpp::AsyncParametersClient>(node, "invalid_remote_node?"); std::make_shared<rclcpp::AsyncParametersClient>(node, "invalid_remote_node?");
(void)asynchronous_client;
}, rclcpp::exceptions::InvalidServiceNameError); }, rclcpp::exceptions::InvalidServiceNameError);
} }
} }
@ -103,7 +105,9 @@ TEST_F(TestParameterClient, sync_construction_and_destruction) {
{ {
ASSERT_THROW( ASSERT_THROW(
{ {
auto synchronous_client =
std::make_shared<rclcpp::SyncParametersClient>(node, "invalid_remote_node?"); std::make_shared<rclcpp::SyncParametersClient>(node, "invalid_remote_node?");
(void)synchronous_client;
}, rclcpp::exceptions::InvalidServiceNameError); }, rclcpp::exceptions::InvalidServiceNameError);
} }
} }