From 9dbd124f1d0db159910a9bbca19d28c41b04b72c Mon Sep 17 00:00:00 2001
From: brawner <brawner@gmail.com>
Date: Mon, 13 Jan 2020 14:23:41 -0800
Subject: [PATCH] Assigning make_shared result to variables in test (#963)

* Assigning make_shared result to variables in test
Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>
---
 rclcpp/test/test_node.cpp             | 9 ++++++---
 rclcpp/test/test_parameter_client.cpp | 8 ++++++--
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/rclcpp/test/test_node.cpp b/rclcpp/test/test_node.cpp
index 1eddeea..213252d 100644
--- a/rclcpp/test/test_node.cpp
+++ b/rclcpp/test/test_node.cpp
@@ -48,20 +48,23 @@ protected:
  */
 TEST_F(TestNode, construction_and_destruction) {
   {
-    std::make_shared<rclcpp::Node>("my_node", "/ns");
+    auto node = std::make_shared<rclcpp::Node>("my_node", "/ns");
+    (void)node;
   }
 
   {
     ASSERT_THROW(
     {
-      std::make_shared<rclcpp::Node>("invalid_node?", "/ns");
+      auto node = std::make_shared<rclcpp::Node>("invalid_node?", "/ns");
+      (void)node;
     }, rclcpp::exceptions::InvalidNodeNameError);
   }
 
   {
     ASSERT_THROW(
     {
-      std::make_shared<rclcpp::Node>("my_node", "/invalid_ns?");
+      auto node = std::make_shared<rclcpp::Node>("my_node", "/invalid_ns?");
+      (void)node;
     }, rclcpp::exceptions::InvalidNamespaceError);
   }
 }
diff --git a/rclcpp/test/test_parameter_client.cpp b/rclcpp/test/test_parameter_client.cpp
index 2630353..4b7aa69 100644
--- a/rclcpp/test/test_parameter_client.cpp
+++ b/rclcpp/test/test_parameter_client.cpp
@@ -69,7 +69,9 @@ TEST_F(TestParameterClient, async_construction_and_destruction) {
   {
     ASSERT_THROW(
     {
-      std::make_shared<rclcpp::AsyncParametersClient>(node, "invalid_remote_node?");
+      auto asynchronous_client =
+        std::make_shared<rclcpp::AsyncParametersClient>(node, "invalid_remote_node?");
+      (void)asynchronous_client;
     }, rclcpp::exceptions::InvalidServiceNameError);
   }
 }
@@ -103,7 +105,9 @@ TEST_F(TestParameterClient, sync_construction_and_destruction) {
   {
     ASSERT_THROW(
     {
-      std::make_shared<rclcpp::SyncParametersClient>(node, "invalid_remote_node?");
+      auto synchronous_client =
+        std::make_shared<rclcpp::SyncParametersClient>(node, "invalid_remote_node?");
+      (void)synchronous_client;
     }, rclcpp::exceptions::InvalidServiceNameError);
   }
 }