niklas/rcl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Increase test coverage of rcl_action (#663)

Browse source 
* Add action_server validity check, and remove dead code

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Increase test coverage of rcl_action

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Reorganizing impl structs into private header

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Addressing PR Feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Addressing memory error and PR feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>

Co-authored-by: Stephen Brawner <stephenbrawner@verbsurgical.com>
This commit is contained in:
brawner 2020-05-28 16:02:35 -07:00 • committed by GitHub
parent d4927e274a
commit b786cea348
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
13 changed files with 1496 additions and 68 deletions
Download patch file Download diff file Expand all files Collapse all files

26
rcl_action/CMakeLists.txt
View file

@ -85,6 +85,7 @@ if(BUILD_TESTING)
if(TARGET test_action_client)
target_include_directories(test_action_client PUBLIC
include
src
)
target_link_libraries(test_action_client
${PROJECT_NAME}
@ -146,6 +147,7 @@ if(BUILD_TESTING)
if(TARGET test_action_server)
target_include_directories(test_action_server PUBLIC
include
src
)
target_link_libraries(test_action_server
${PROJECT_NAME}
@ -166,7 +168,7 @@ if(BUILD_TESTING)
target_link_libraries(test_goal_handle
${PROJECT_NAME}
)
ament_target_dependencies(test_action_server "rcl")
ament_target_dependencies(test_goal_handle "rcl")
endif()
ament_add_gtest(test_goal_state_machine
test/rcl_action/test_goal_state_machine.cpp
@ -175,7 +177,7 @@ if(BUILD_TESTING)
target_link_libraries(test_goal_state_machine
${PROJECT_NAME}
)
ament_target_dependencies(test_action_server "rcl")
ament_target_dependencies(test_goal_state_machine "osrf_testing_tools_cpp" "rcl")
endif()
ament_add_gtest(test_types
test/rcl_action/test_types.cpp
@ -187,7 +189,7 @@ if(BUILD_TESTING)
target_link_libraries(test_types
${PROJECT_NAME}
)
ament_target_dependencies(test_action_server "rcl")
ament_target_dependencies(test_types "rcl")
endif()
ament_add_gtest(test_names
test/rcl_action/test_names.cpp
@ -196,7 +198,23 @@ if(BUILD_TESTING)
target_link_libraries(test_names
${PROJECT_NAME}
)
ament_target_dependencies(test_action_server "rcl")
ament_target_dependencies(test_names "rcl")
endif()
ament_add_gtest(test_wait
test/rcl_action/test_wait.cpp
)
if(TARGET test_wait)
target_link_libraries(test_wait
${PROJECT_NAME}
)
target_include_directories(test_wait PUBLIC
src
)
ament_target_dependencies(test_wait
"osrf_testing_tools_cpp"
"rcl"
"test_msgs"
)
endif()
endif()