Merge branch '49-fix-windows-build-fail' into 'master'

Resolve "Fix Windows build fail"

Closes #49

See merge request micro-ROS/ros_tracing/ros2_tracing!88

tracetools_launch/tracetools_launch/action.py

@@ -28,6 +28,7 @@ from launch.launch_context import LaunchContext
 from tracetools_trace.tools import lttng
 from tracetools_trace.tools import names
 from tracetools_trace.tools import path
+from tracetools_trace.tools import tracing_supported
 
 
 class Trace(Action):
@@ -73,10 +74,12 @@ class Trace(Action):
         self.__ld_preload_action = None
         if self.has_profiling_events(events_ust):
             profile_lib_name = self.PROFILE_LIB_FAST if profile_fast else self.PROFILE_LIB_NORMAL
-            self.__ld_preload_action = SetEnvironmentVariable(
-                'LD_PRELOAD',
-                self.get_shared_lib_path(profile_lib_name),
-            )
+            profile_lib_path = self.get_shared_lib_path(profile_lib_name)
+            if profile_lib_path is not None:
+                self.__ld_preload_action = SetEnvironmentVariable(
+                    'LD_PRELOAD',
+                    profile_lib_path,
+                )
 
     @classmethod
     def has_profiling_events(cls, events_ust: List[str]) -> bool:
@@ -91,6 +94,8 @@ class Trace(Action):
         :param lib_name: the name of the shared library
         :return: the full path if found, `None` otherwise
         """
+        if not tracing_supported():
+            return None
         (exit_code, output) = subprocess.getstatusoutput(f'whereis -b {lib_name}')
         if exit_code != 0:
             return None

tracetools_read/tracetools_read/__init__.py

@@ -12,73 +12,15 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-"""Module with functions for reading traces."""
+"""Module with trace-reading utilities."""
 
 from typing import Any
 from typing import Dict
-from typing import Iterable
-from typing import List
-
-import babeltrace
 
 
 DictEvent = Dict[str, Any]
 
 
-def get_trace_ctf_events(trace_directory: str) -> Iterable[babeltrace.babeltrace.Event]:
-    """
-    Get the events of a trace.
-
-    :param trace_directory: the path to the main/top trace directory
-    :return: events iterable
-    """
-    tc = babeltrace.TraceCollection()
-    tc.add_traces_recursive(trace_directory, 'ctf')
-    return tc.events
-
-
-def get_trace_events(trace_directory: str) -> List[DictEvent]:
-    """
-    Get the events of a trace.
-
-    :param trace_directory: the path to the main/top trace directory
-    :return: events
-    """
-    return [event_to_dict(event) for event in get_trace_ctf_events(trace_directory)]
-
-
-# List of ignored CTF fields
-_IGNORED_FIELDS = [
-    'content_size',
-    'events_discarded',
-    'id',
-    'packet_size',
-    'packet_seq_num',
-    'stream_id',
-    'stream_instance_id',
-    'timestamp_end',
-    'timestamp_begin',
-    'magic',
-    'uuid',
-    'v',
-]
-_DISCARD = 'events_discarded'
-
-
-def event_to_dict(event: babeltrace.babeltrace.Event) -> DictEvent:
-    """
-    Convert name, timestamp, and all other keys except those in IGNORED_FIELDS into a dictionary.
-
-    :param event: the event to convert
-    :return: the event as a dictionary
-    """
-    if hasattr(event, _DISCARD) and event[_DISCARD] > 0:
-        print(event[_DISCARD])
-    meta = {'_name': event.name, '_timestamp': event.timestamp}
-    data = {key: event[key] for key in event.keys() if key not in _IGNORED_FIELDS}
-    return {**meta, **data}
-
-
 def get_field(
     event: DictEvent,
     field_name: str,

tracetools_read/tracetools_read/trace.py

@@ -0,0 +1,79 @@
+# Copyright 2019 Robert Bosch GmbH
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""Module with functions for reading traces."""
+
+from typing import Iterable
+from typing import List
+
+import babeltrace
+
+from . import DictEvent
+
+
+BabeltraceEvent = babeltrace.babeltrace.Event
+
+
+def get_trace_ctf_events(trace_directory: str) -> Iterable[BabeltraceEvent]:
+    """
+    Get the events of a trace.
+
+    :param trace_directory: the path to the main/top trace directory
+    :return: events iterable
+    """
+    tc = babeltrace.TraceCollection()
+    tc.add_traces_recursive(trace_directory, 'ctf')
+    return tc.events
+
+
+def get_trace_events(trace_directory: str) -> List[DictEvent]:
+    """
+    Get the events of a trace.
+
+    :param trace_directory: the path to the main/top trace directory
+    :return: events
+    """
+    return [event_to_dict(event) for event in get_trace_ctf_events(trace_directory)]
+
+
+# List of ignored CTF fields
+_IGNORED_FIELDS = [
+    'content_size',
+    'events_discarded',
+    'id',
+    'packet_size',
+    'packet_seq_num',
+    'stream_id',
+    'stream_instance_id',
+    'timestamp_end',
+    'timestamp_begin',
+    'magic',
+    'uuid',
+    'v',
+]
+_DISCARD = 'events_discarded'
+
+
+def event_to_dict(event: BabeltraceEvent) -> DictEvent:
+    """
+    Convert name, timestamp, and all other keys except those in IGNORED_FIELDS into a dictionary.
+
+    :param event: the event to convert
+    :return: the event as a dictionary
+    """
+    if hasattr(event, _DISCARD) and event[_DISCARD] > 0:
+        print(event[_DISCARD])
+    meta = {'_name': event.name, '_timestamp': event.timestamp}
+    data = {key: event[key] for key in event.keys() if key not in _IGNORED_FIELDS}
+    return {**meta, **data}

tracetools_test/tracetools_test/case.py

@@ -25,7 +25,7 @@ from tracetools_read import get_event_name
 from tracetools_read import get_event_timestamp
 from tracetools_read import get_field
 from tracetools_read import get_procname
-from tracetools_read import get_trace_events
+from tracetools_read.trace import get_trace_events
 
 from .utils import cleanup_trace
 from .utils import get_event_names

tracetools_trace/tracetools_trace/tools/__init__.py

@@ -11,3 +11,16 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+
+"""Module for tracing."""
+
+import sys
+
+
+def tracing_supported() -> bool:
+    """
+    Check if tracing is supported on this platform.
+
+    It does not mean a tracer is installed.
+    """
+    return sys.platform == 'linux'

tracetools_trace/tracetools_trace/tools/lttng.py

@@ -16,7 +16,10 @@
 
 from typing import List
 
-import lttng
+try:
+    import lttng
+except ImportError:
+    lttng = None
 
 from .names import DEFAULT_CONTEXT
 from .names import DEFAULT_EVENTS_KERNEL
@@ -41,6 +44,8 @@ def lttng_init(
     :param kernel_events: list of kernel events to enable
     :param context_names: list of context elements to enable
     """
+    if lttng is None:
+        return None
     _lttng_setup(session_name, base_path, ros_events, kernel_events, context_names)
     _lttng_start(session_name)
 
@@ -51,6 +56,8 @@ def lttng_fini(session_name: str) -> None:
 
     :param session_name: the name of the session
     """
+    if lttng is None:
+        return None
     _lttng_stop(session_name)
     _lttng_destroy(session_name)