Update style for test_service_callback

This commit is contained in:
Christophe Bedard 2019-11-16 15:17:15 -08:00
parent ff4155ab84
commit 5b5731dc84

View file

@ -36,6 +36,8 @@ class TestServiceCallback(TraceTestCase):
# Check fields # Check fields
start_events = self.get_events_with_name('ros2:callback_start') start_events = self.get_events_with_name('ros2:callback_start')
end_events = self.get_events_with_name('ros2:callback_end')
for event in start_events: for event in start_events:
self.assertValidHandle(event, 'callback') self.assertValidHandle(event, 'callback')
# Should not be 1 for services (yet) # Should not be 1 for services (yet)
@ -43,24 +45,25 @@ class TestServiceCallback(TraceTestCase):
event, event,
'is_intra_process', 'is_intra_process',
0, 0,
'invalid value for is_intra_process') 'invalid value for is_intra_process',
)
end_events = self.get_events_with_name('ros2:callback_end')
for event in end_events: for event in end_events:
self.assertValidHandle(event, 'callback') self.assertValidHandle(event, 'callback')
# Check that there is at least a start/end pair for each node # Check that there is at least 1 start/end pair for each node
for node in self._nodes: for node in self._nodes:
test_start_events = self.get_events_with_procname(node, start_events) test_start_events = self.get_events_with_procname(node, start_events)
test_end_events = self.get_events_with_procname(node, end_events) test_end_events = self.get_events_with_procname(node, end_events)
self.assertGreater( self.assertGreater(
len(test_start_events), len(test_start_events),
0, 0,
f'no start_callback events for node: {node}') f'no start_callback events for node: {node}',
)
self.assertGreater( self.assertGreater(
len(test_end_events), len(test_end_events),
0, 0,
f'no end_callback events for node: {node}') f'no end_callback events for node: {node}',
)
if __name__ == '__main__': if __name__ == '__main__':