Remove duplicated code for trace command

This commit is contained in:
Christophe Bedard 2019-12-08 14:01:57 -08:00
parent 9c4e564bb4
commit 3d3cbe9ec3
3 changed files with 58 additions and 75 deletions

View file

@ -11,62 +11,3 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""API functions for the ROS 2 trace command."""
from tracetools_trace.tools import args
from tracetools_trace.tools import lttng
from tracetools_trace.tools import path
from tracetools_trace.tools import print_events_list
def add_trace_arguments(parser):
args.add_arguments(parser)
def init(args):
"""
Init and start tracing.
:param args: the parsed arguments object containing the right fields
"""
session_name = args.session_name
base_path = args.path
ros_events = args.events_ust
kernel_events = args.events_kernel
ust_enabled = len(ros_events) > 0
kernel_enabled = len(kernel_events) > 0
if ust_enabled:
print(f'UST tracing enabled ({len(ros_events)} events)')
if args.list:
print_events_list(ros_events)
else:
print('UST tracing disabled')
if kernel_enabled:
print(f'kernel tracing enabled ({len(kernel_events)} events)')
if args.list:
print_events_list(kernel_events)
else:
print('kernel tracing disabled')
full_session_path = path.get_full_session_path(session_name, base_path)
print(f'writing tracing session to: {full_session_path}')
input('press enter to start...')
lttng.lttng_init(
session_name,
base_path=base_path,
ros_events=ros_events,
kernel_events=kernel_events)
def fini(args):
"""
Stop and finalize tracing.
:param args: the parsed arguments object containing the right fields
"""
session_name = args.session_name
input('press enter to stop...')
print('stopping & destroying tracing session')
lttng.lttng_fini(session_name)

View file

@ -15,18 +15,26 @@
"""Module for trace command extension implementation."""
from ros2cli.command import CommandExtension
from ros2trace.api import add_trace_arguments
from ros2trace.api import fini
from ros2trace.api import init
from tracetools_trace.tools import args
from tracetools_trace.trace import init
from tracetools_trace.trace import fini
class TraceCommand(CommandExtension):
"""Trace ROS nodes to get information on their execution."""
def add_arguments(self, parser, cli_name):
add_trace_arguments(parser)
args.add_arguments(parser)
def main(self, *, parser, args):
init(args)
fini(args)
init(
args.session_name,
args.path,
args.events_ust,
args.events_kernel,
args.list,
)
fini(
args.session_name,
)
return 0