rclcpp/rclcpp_action
astere-cpr ecc39cace6 issue-919 Fixed "memory leak" in action clients (#920)
Whenever a call is made to `rclcpp_action::Client::wait_for_action_server`
a weak pointer to an Event object gets added to the graph_event_ vector
of the NodeGraph interface. This vector will be cleared on a node graph
change event, but if no such event occurs the weak pointer will be stuck
in the vector.  Furthermore, if client code issues repeated calls to
`wait_for_action_server` the vector will keep growing.

The fix moves the Event object creation right after the early return from
`wait_for_action_server` so that the Event object is not created in the
case that the server is known to be present and therefore there is no
need to wait for a node graph change event to occur.

Signed-off-by: Adrian Stere <astere@clearpath.ai>
2019-11-19 16:09:41 -03:00
..
include/rclcpp_action template node type for rclcpp action server and clients (#892) 2019-10-16 18:31:36 -07:00
src issue-919 Fixed "memory leak" in action clients (#920) 2019-11-19 16:09:41 -03:00
test Trait tests for generated actions (#853) 2019-10-15 13:51:57 -05:00
CHANGELOG.rst 0.8.2 2019-11-18 16:56:29 -08:00
CMakeLists.txt [rclcpp_action] Bump test_client timeout. (#917) 2019-11-12 19:15:38 -03:00
Doxyfile Add Doxyfile for rclcpp_action 2019-03-12 11:56:18 -07:00
package.xml 0.8.2 2019-11-18 16:56:29 -08:00