No description
Find a file
astere-cpr ecc39cace6 issue-919 Fixed "memory leak" in action clients (#920)
Whenever a call is made to `rclcpp_action::Client::wait_for_action_server`
a weak pointer to an Event object gets added to the graph_event_ vector
of the NodeGraph interface. This vector will be cleared on a node graph
change event, but if no such event occurs the weak pointer will be stuck
in the vector.  Furthermore, if client code issues repeated calls to
`wait_for_action_server` the vector will keep growing.

The fix moves the Event object creation right after the early return from
`wait_for_action_server` so that the Event object is not created in the
case that the server is known to be present and therefore there is no
need to wait for a node graph change event to occur.

Signed-off-by: Adrian Stere <astere@clearpath.ai>
2019-11-19 16:09:41 -03:00
.github advise to ask questions on ROS answers 2018-02-26 22:01:36 -08:00
rclcpp 0.8.2 2019-11-18 16:56:29 -08:00
rclcpp_action issue-919 Fixed "memory leak" in action clients (#920) 2019-11-19 16:09:41 -03:00
rclcpp_components 0.8.2 2019-11-18 16:56:29 -08:00
rclcpp_lifecycle 0.8.2 2019-11-18 16:56:29 -08:00
.gitignore add wait_for_action_server() for action clients (#598) 2018-12-06 18:57:25 -08:00
CONTRIBUTING.md add section about DCO to CONTRIBUTING.md 2019-03-20 08:38:07 -07:00
LICENSE update license file to keep copyright template 2015-04-03 12:30:27 -07:00