rclcpp/rclcpp_action/src
astere-cpr ecc39cace6 issue-919 Fixed "memory leak" in action clients (#920)
Whenever a call is made to `rclcpp_action::Client::wait_for_action_server`
a weak pointer to an Event object gets added to the graph_event_ vector
of the NodeGraph interface. This vector will be cleared on a node graph
change event, but if no such event occurs the weak pointer will be stuck
in the vector.  Furthermore, if client code issues repeated calls to
`wait_for_action_server` the vector will keep growing.

The fix moves the Event object creation right after the early return from
`wait_for_action_server` so that the Event object is not created in the
case that the server is known to be present and therefore there is no
need to wait for a node graph change event to occur.

Signed-off-by: Adrian Stere <astere@clearpath.ai>
2019-11-19 16:09:41 -03:00
..
client.cpp issue-919 Fixed "memory leak" in action clients (#920) 2019-11-19 16:09:41 -03:00
qos.cpp change API to encourage users to specify history depth always (#713) 2019-05-08 14:24:40 -07:00
server.cpp Add line break after first open paren in multiline function call (#785) 2019-08-07 08:33:06 -07:00
server_goal_handle.cpp Rename action state transitions (#677) 2019-04-16 04:46:40 -07:00
types.cpp update to use separated action types (#601) 2019-03-11 21:12:47 -07:00