niklas/rclcpp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[rclcpp_lifecycle] Change uint8_t iterator variables to size_t (#1461) (#1488)

Browse source 
* Change uint8_t iterator variables to size_t

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Change to unsigned int

Signed-off-by: Stephen Brawner <brawner@gmail.com>

Co-authored-by: brawner <brawner@gmail.com>
This commit is contained in:
Jacob Perron 2020-12-08 12:35:37 -08:00 • committed by GitHub
parent a4fd8ceece
commit b132a2b0cd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
rclcpp_lifecycle/src/lifecycle_node_interface_impl.hpp
View file

@ -265,7 +265,7 @@ public:
throw std::runtime_error( throw std::runtime_error(
"Can't get available states. State machine is not initialized."); "Can't get available states. State machine is not initialized.");
} }
for (uint8_t i = 0; i < state_machine_.transition_map.states_size; ++i) { for (unsigned int i = 0; i < state_machine_.transition_map.states_size; ++i) {
lifecycle_msgs::msg::State state; lifecycle_msgs::msg::State state;
state.id = static_cast<uint8_t>(state_machine_.transition_map.states[i].id); state.id = static_cast<uint8_t>(state_machine_.transition_map.states[i].id);
state.label = static_cast<std::string>(state_machine_.transition_map.states[i].label); state.label = static_cast<std::string>(state_machine_.transition_map.states[i].label);
@ -286,7 +286,7 @@ public:
"Can't get available transitions. State machine is not initialized."); "Can't get available transitions. State machine is not initialized.");
} }
for (uint8_t i = 0; i < state_machine_.current_state->valid_transition_size; ++i) { for (unsigned int i = 0; i < state_machine_.current_state->valid_transition_size; ++i) {
auto rcl_transition = state_machine_.current_state->valid_transitions[i]; auto rcl_transition = state_machine_.current_state->valid_transitions[i];
lifecycle_msgs::msg::TransitionDescription trans_desc; lifecycle_msgs::msg::TransitionDescription trans_desc;
trans_desc.transition.id = static_cast<uint8_t>(rcl_transition.id); trans_desc.transition.id = static_cast<uint8_t>(rcl_transition.id);
@ -312,7 +312,7 @@ public:
"Can't get available transitions. State machine is not initialized."); "Can't get available transitions. State machine is not initialized.");
} }
for (uint8_t i = 0; i < state_machine_.transition_map.transitions_size; ++i) { for (unsigned int i = 0; i < state_machine_.transition_map.transitions_size; ++i) {
auto rcl_transition = state_machine_.transition_map.transitions[i]; auto rcl_transition = state_machine_.transition_map.transitions[i];
lifecycle_msgs::msg::TransitionDescription trans_desc; lifecycle_msgs::msg::TransitionDescription trans_desc;
trans_desc.transition.id = static_cast<uint8_t>(rcl_transition.id); trans_desc.transition.id = static_cast<uint8_t>(rcl_transition.id);
@ -336,7 +336,7 @@ public:
get_available_states() get_available_states()
{ {
std::vector<State> states; std::vector<State> states;
for (uint8_t i = 0; i < state_machine_.transition_map.states_size; ++i) { for (unsigned int i = 0; i < state_machine_.transition_map.states_size; ++i) {
State state(&state_machine_.transition_map.states[i]); State state(&state_machine_.transition_map.states[i]);
states.push_back(state); states.push_back(state);
} }
@ -348,7 +348,7 @@ public:
{ {
std::vector<Transition> transitions; std::vector<Transition> transitions;
for (uint8_t i = 0; i < state_machine_.transition_map.transitions_size; ++i) { for (unsigned int i = 0; i < state_machine_.transition_map.transitions_size; ++i) {
Transition transition( Transition transition(
&state_machine_.transition_map.transitions[i]); &state_machine_.transition_map.transitions[i]);
transitions.push_back(transition); transitions.push_back(transition);