From b132a2b0cd2dff92e120cf5d10871a1a8612e83a Mon Sep 17 00:00:00 2001
From: Jacob Perron <jacob@openrobotics.org>
Date: Tue, 8 Dec 2020 12:35:37 -0800
Subject: [PATCH] [rclcpp_lifecycle] Change uint8_t iterator variables to
 size_t (#1461) (#1488)

* Change uint8_t iterator variables to size_t

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Change to unsigned int

Signed-off-by: Stephen Brawner <brawner@gmail.com>

Co-authored-by: brawner <brawner@gmail.com>
---
 rclcpp_lifecycle/src/lifecycle_node_interface_impl.hpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/rclcpp_lifecycle/src/lifecycle_node_interface_impl.hpp b/rclcpp_lifecycle/src/lifecycle_node_interface_impl.hpp
index 9fc21e5..1696e26 100644
--- a/rclcpp_lifecycle/src/lifecycle_node_interface_impl.hpp
+++ b/rclcpp_lifecycle/src/lifecycle_node_interface_impl.hpp
@@ -265,7 +265,7 @@ public:
       throw std::runtime_error(
               "Can't get available states. State machine is not initialized.");
     }
-    for (uint8_t i = 0; i < state_machine_.transition_map.states_size; ++i) {
+    for (unsigned int i = 0; i < state_machine_.transition_map.states_size; ++i) {
       lifecycle_msgs::msg::State state;
       state.id = static_cast<uint8_t>(state_machine_.transition_map.states[i].id);
       state.label = static_cast<std::string>(state_machine_.transition_map.states[i].label);
@@ -286,7 +286,7 @@ public:
               "Can't get available transitions. State machine is not initialized.");
     }
 
-    for (uint8_t i = 0; i < state_machine_.current_state->valid_transition_size; ++i) {
+    for (unsigned int i = 0; i < state_machine_.current_state->valid_transition_size; ++i) {
       auto rcl_transition = state_machine_.current_state->valid_transitions[i];
       lifecycle_msgs::msg::TransitionDescription trans_desc;
       trans_desc.transition.id = static_cast<uint8_t>(rcl_transition.id);
@@ -312,7 +312,7 @@ public:
               "Can't get available transitions. State machine is not initialized.");
     }
 
-    for (uint8_t i = 0; i < state_machine_.transition_map.transitions_size; ++i) {
+    for (unsigned int i = 0; i < state_machine_.transition_map.transitions_size; ++i) {
       auto rcl_transition = state_machine_.transition_map.transitions[i];
       lifecycle_msgs::msg::TransitionDescription trans_desc;
       trans_desc.transition.id = static_cast<uint8_t>(rcl_transition.id);
@@ -336,7 +336,7 @@ public:
   get_available_states()
   {
     std::vector<State> states;
-    for (uint8_t i = 0; i < state_machine_.transition_map.states_size; ++i) {
+    for (unsigned int i = 0; i < state_machine_.transition_map.states_size; ++i) {
       State state(&state_machine_.transition_map.states[i]);
       states.push_back(state);
     }
@@ -348,7 +348,7 @@ public:
   {
     std::vector<Transition> transitions;
 
-    for (uint8_t i = 0; i < state_machine_.transition_map.transitions_size; ++i) {
+    for (unsigned int i = 0; i < state_machine_.transition_map.transitions_size; ++i) {
       Transition transition(
         &state_machine_.transition_map.transitions[i]);
       transitions.push_back(transition);