Commit graph

13 commits

Author SHA1 Message Date
Shane Loretz
66b82291a1
adapt to action implicit changes (#353) 2018-12-06 16:42:41 -08:00
Alexis Pojomovsky
c5798e4774 Adds action interaction tests (#352)
* Add action_interaction_tests

* Fixed tests to work with new uuid

* Added comments for each test

* Addressed peer review comments

* Removed unnecessary rcl_reset_error calls from test_action_communication

* Addressed second part of peer review
2018-12-06 14:09:03 -08:00
Alexis Pojomovsky
b1c4d95abe Change UUID type in action msgs (#338)
* Make use of unique_identifier_msgs/uuid in rcl_action

* Update to use goal_id.uuid

* Remove unnecessary find_package of unique_identifier_msgs
2018-12-04 11:05:20 -08:00
Shane Loretz
fd77323b9d
Add timer to action server to check expired goals + asan fixes (#343)
* Add timer to action server to check expired goals

* Fix leak in action_server

* Fix leaks and heap overflow errors

* Fix leaks in tests
2018-11-30 18:24:17 -08:00
Alexis Pojomovsky
128f28499b Increased timeout for rcl_wait in action tests (#344) 2018-11-30 14:56:07 -08:00
William Woodall
97ad0013e2
refactor init to not be global (#336)
* refactor init to not be global

Signed-off-by: William Woodall <william@osrfoundation.org>

* style changes

Signed-off-by: William Woodall <william@osrfoundation.org>

* refactor to hide use of C11 atomics in implementation

Signed-off-by: William Woodall <william@osrfoundation.org>

* fix new action tests

Signed-off-by: William Woodall <william@osrfoundation.org>

* use alternative atomic init for Windows support

* updates after rebase

Signed-off-by: William Woodall <william@osrfoundation.org>

* cleanup rmw_init_options before copying

Signed-off-by: William Woodall <william@osrfoundation.org>

* fix two bugs in new init code

* relax validity checks in a few places to facilitate post shutdown cleanup

Signed-off-by: William Woodall <william@osrfoundation.org>

* fixing tests for new API behavior

Signed-off-by: William Woodall <william@osrfoundation.org>

* to allocator -> to allocate

* acutally call rmw_shutdown() and address review comments

Signed-off-by: William Woodall <william@osrfoundation.org>
2018-11-29 21:32:54 -08:00
Alexis Pojomovsky
aead12917a Addressed peer review comments v2 2018-11-28 15:07:46 -03:00
Alexis Pojomovsky
10eebe3a3b Added checks for wait set entities 2018-11-27 14:25:56 -03:00
Alexis Pojomovsky
d03d5605c1 Addressed peer review comments 2018-11-27 14:11:47 -03:00
Alexis Pojomovsky
4ee3182380 Updated action tests to match the updated API
Added action cancel test

Added action result communication test

Added action status communication test

Added action feedback communication test

Fix wrong return code in action client
2018-11-26 19:27:53 -03:00
Michel Hidalgo
bde76ab40e [rcl action] Augments test_action_communication test. 2018-11-22 11:14:56 -03:00
Michel Hidalgo
f531f682ea [rcl action] Exposes sequence numbers for all requests and responses. (#339) 2018-11-21 16:50:03 -08:00
Jacob Perron
acc974e43b
Add action server implementation (#323)
* Implement action server init, fini, and is_valid functions

* Add macros for initializing services and publishers

* Implement rcl_action_server_get_default_options()

* Implement rcl_action_accept_new_goal()

* Add function, rcl_action_server_goal_exists(), for checking if goal is already being tracked by an action server

* Add unit tests

* Implement rcl_action_server_get_goal_handles()

* Implement rcl_action_server_get_options()

* Implement rcl_action_server_get_action_name()

* Implement rcl_action_get_goal_status_array()

* Bugfix: reset pointers and size in type finalize functions
Also let finalize functions be called on already finalized objects

* Implement send/take functions for action server services

* Implement action server publishers for feedback and status

* Implement rcl_action_process_cancel_request()

* Add partial communication tests

* Define UUID_SIZE

* Use type-erased pointer for rcl_action_publish_status()

* Implement rcl_action_clear_expired_goals()
Introduce rcl_clock_t to action server implementation.

* Change internal goal handle array to be an array of pointers.

* Add check for invalid action names

* Do heap allocation of temporary array to satisfy MSVC compiler

* Bugfix: finalize node in test tear downs and reset expected errors

* Update documentation

* Update package.xml

* Pass in rcl_clock_t to action server
Rather than initializing internally.

* Do not finalize goal handles in expire function
Instead, leave it up to the caller to finalize goal handles.
Renamed the function to rcl_action_expire_goals.
2018-11-20 12:04:13 -08:00