Commit graph

7 commits

Author SHA1 Message Date
Chris Lalancette
885fa21a89 Make sure to check the return value of rcl APIs. (#838)
This is just a further check to ensure the test is correct,
and also gets rid of a slew of dead store warnings from
clang static analysis.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
2020-11-02 16:22:11 +01:00
brawner
a4e6485313 Fix test_rcl_lifecycle (#788)
Signed-off-by: Stephen Brawner <brawner@gmail.com>
2020-10-16 19:28:38 +02:00
brawner
dd62d09042 Add fault injection macros and unit tests to rcl_lifecycle (#731)
* Add fault injection macros and unit tests to rcl_lifecycle

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Address feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>
2020-10-16 19:28:38 +02:00
Shane Loretz
055d7eba62
Topic fix rcl lifecycle test issue (#715) (#796)
* Fix missing call fini() for lifecycle_transition and node in test_rcl_lifecycle

Signed-off-by: Barry Xu <barry.xu@sony.com>

* Fix error overwritten while allocator is Nullptr.

Signed-off-by: Barry Xu <barry.xu@sony.com>

* Optimize used variables

Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

Co-authored-by: Barry Xu <barry.xu@sony.com>
2020-09-09 15:25:10 -07:00
brawner
474754586c
Remove std::cout line from test_rcl_lifecycle.cpp (#773) (#774)
Signed-off-by: Stephen Brawner <brawner@gmail.com>
2020-08-28 10:47:26 -07:00
Karsten Knese
0de31d0483
transition start and goal states can be null (#662)
* transition start and goal states can be null

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* correct tests

Signed-off-by: Karsten Knese <karsten@openrobotics.org>
2020-05-27 12:03:10 -07:00
brawner
7146919c3f
Increase rcl_lifecycle test coverage and add more safety checks (#649)
* Increase test coverage and add more safety checks

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* More coverage

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Concatenating error messages

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

* PR Fixup

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

* Forgot a

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

* PR Fixup

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

* Moving var to top

Signed-off-by: Stephen Brawner <stephenbrawner@verbsurgical.com>

Co-authored-by: Stephen Brawner <stephenbrawner@verbsurgical.com>
2020-05-22 14:44:11 -07:00