niklas/rcl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove todo that doesnt seem necessary anymore (#161)

Browse source
This commit is contained in:
Mikael Arguedas 2017-08-29 22:58:21 -07:00 • committed by GitHub
parent 173f1da229
commit cd8cff0024
2 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
rcl/test/rcl/test_publisher.cpp
View file

@ -127,9 +127,7 @@ TEST_F(CLASSNAME(TestPublisherFixture, RMW_IMPLEMENTATION), test_publisher_nomin
std_msgs__msg__String__init(&msg);
ASSERT_TRUE(rosidl_generator_c__String__assign(&msg.data, "testing"));
ret = rcl_publish(&publisher, &msg);
// TODO(wjwwood): re-enable this fini when ownership of the string is resolved.
// currently with Connext we will spuriously get a double free here.
// std_msgs__msg__String__fini(&msg);
std_msgs__msg__String__fini(&msg);
ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
}

4
rcl/test/rcl/test_subscription.cpp
View file

@ -212,9 +212,7 @@ TEST_F(CLASSNAME(TestSubscriptionFixture, RMW_IMPLEMENTATION), test_subscription
std_msgs__msg__String__init(&msg);
ASSERT_TRUE(rosidl_generator_c__String__assign(&msg.data, test_string));
ret = rcl_publish(&publisher, &msg);
// TODO(wjwwood): re-enable this fini when ownership of the string is resolved.
// currently with Connext we will spuriously get a double free here.
// std_msgs__msg__String__fini(&msg);
std_msgs__msg__String__fini(&msg);
ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
}
bool success;