niklas/rcl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix mem leaks in unit test from 776 (#779)

Browse source 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
This commit is contained in:
brawner 2020-08-31 16:03:52 -07:00 • committed by Alejandro Hernández Cordero
parent bf2029acf8
commit a34c4816c9
2 changed files with 34 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

16
rcl_yaml_param_parser/test/test_parser.cpp
View file

@ -330,11 +330,9 @@ TEST(RclYamlParamParser, test_parse_file_with_bad_allocator) {
bool res = rcl_parse_yaml_file(path, params_hdl);
// Not verifying res is true or false here, because eventually it will come back with an ok
// result. We're just trying to make sure that bad allocations are properly handled
if (res) {
// This is already freed in the case of a non-ok error in rcl_parse_yaml_file
rcl_yaml_node_struct_fini(params_hdl);
params_hdl = NULL;
}
(void)res;
rcl_yaml_node_struct_fini(params_hdl);
params_hdl = NULL;
}
// Check sporadic failing calloc calls
@ -347,11 +345,9 @@ TEST(RclYamlParamParser, test_parse_file_with_bad_allocator) {
bool res = rcl_parse_yaml_file(path, params_hdl);
// Not verifying res is true or false here, because eventually it will come back with an ok
// result. We're just trying to make sure that bad allocations are properly handled
if (res) {
// This is already freed in the case of a non-ok error in rcl_parse_yaml_file
rcl_yaml_node_struct_fini(params_hdl);
params_hdl = NULL;
}
(void)res;
rcl_yaml_node_struct_fini(params_hdl);
params_hdl = NULL;
}
}