update to use new memory_tools from osrf_testing_tools_cpp (#238)

* remove old memory tools

* updates to use new memory_tools from osrf_testing_tools_cpp

* fixup new test

* fix lambda captures for Windows

* uncrustify fix

* extra_test_env -> rmw_implementation_env_var

* Stray extra_test_libraries

* Use default rmw impl outside of for_each_rmw_implementation loop

* style fixup

* fix typo

rcl/package.xml

@@ -35,6 +35,7 @@
   <test_depend>rmw_implementation_cmake</test_depend>
   <test_depend>launch</test_depend>
   <test_depend>example_interfaces</test_depend>
+  <test_depend>osrf_testing_tools_cpp</test_depend>
   <test_depend>std_msgs</test_depend>
 
   <export>

rcl/test/CMakeLists.txt

@@ -6,21 +6,21 @@ find_package(std_msgs REQUIRED)
 
 find_package(rmw_implementation_cmake REQUIRED)
 
+find_package(osrf_testing_tools_cpp REQUIRED)
+
+get_target_property(memory_tools_ld_preload_env_var
+  osrf_testing_tools_cpp::memory_tools LIBRARY_PRELOAD_ENVIRONMENT_VARIABLE)
+
 include(cmake/rcl_add_custom_executable.cmake)
 include(cmake/rcl_add_custom_gtest.cmake)
 include(cmake/rcl_add_custom_launch_test.cmake)
 
-set(extra_test_libraries)
-set(extra_test_env)
 set(extra_lib_dirs "${rcl_lib_dir}")
 
 # finding gtest once in the highest scope
 # prevents finding it repeatedly in each local scope
 ament_find_gtest()
 
-# This subdirectory extends both extra_test_libraries, extra_test_env, and extra_lib_dirs.
-add_subdirectory(memory_tools)
-
 macro(test_target)
   find_package(${rmw_implementation} REQUIRED)
   test_target_function()
@@ -28,58 +28,60 @@ endmacro()
 
 function(test_target_function)
   message(STATUS "Creating tests for '${rmw_implementation}'")
-  list(APPEND extra_test_env RMW_IMPLEMENTATION=${rmw_implementation})
+  set(rmw_implementation_env_var RMW_IMPLEMENTATION=${rmw_implementation})
 
   # Gtests
 
   rcl_add_custom_gtest(test_client${target_suffix}
     SRCS rcl/test_client.cpp
-    ENV ${extra_test_env}
+    INCLUDE_DIRS ${osrf_testing_tools_cpp_INCLUDE_DIRS}
+    ENV ${rmw_implementation_env_var}
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    LIBRARIES ${PROJECT_NAME}
     AMENT_DEPENDENCIES ${rmw_implementation} "example_interfaces"
   )
 
   rcl_add_custom_gtest(test_time${target_suffix}
     SRCS rcl/test_time.cpp
-    ENV ${extra_test_env}
+    ENV ${rmw_implementation_env_var} ${memory_tools_ld_preload_env_var}
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    LIBRARIES ${PROJECT_NAME} osrf_testing_tools_cpp::memory_tools
     AMENT_DEPENDENCIES ${rmw_implementation}
   )
 
   rcl_add_custom_gtest(test_common${target_suffix}
     SRCS rcl/test_common.cpp
     ENV
-      ${extra_test_env}
+      ${rmw_implementation_env_var}
       EMPTY_TEST=
       NORMAL_TEST=foo
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    LIBRARIES ${PROJECT_NAME}
     AMENT_DEPENDENCIES ${rmw_implementation}
   )
 
   rcl_add_custom_gtest(test_get_node_names${target_suffix}
     SRCS rcl/test_get_node_names.cpp
-    ENV ${extra_test_env}
+    ENV ${rmw_implementation_env_var}
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    LIBRARIES ${PROJECT_NAME}
     AMENT_DEPENDENCIES ${rmw_implementation}
   )
 
   rcl_add_custom_gtest(test_lexer${target_suffix}
     SRCS rcl/test_lexer.cpp
-    ENV ${extra_test_env}
+    ENV ${rmw_implementation_env_var}
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    LIBRARIES ${PROJECT_NAME}
     AMENT_DEPENDENCIES ${rmw_implementation}
   )
 
   rcl_add_custom_gtest(test_lexer_lookahead${target_suffix}
     SRCS rcl/test_lexer_lookahead.cpp
-    ENV ${extra_test_env}
+    INCLUDE_DIRS ${osrf_testing_tools_cpp_INCLUDE_DIRS}
+    ENV ${rmw_implementation_env_var}
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    LIBRARIES ${PROJECT_NAME}
     AMENT_DEPENDENCIES ${rmw_implementation}
   )
 
@@ -93,97 +95,107 @@ function(test_target_function)
   endif()
   rcl_add_custom_gtest(test_graph${target_suffix}
     SRCS rcl/test_graph.cpp
-    ENV ${extra_test_env}
+    INCLUDE_DIRS ${osrf_testing_tools_cpp_INCLUDE_DIRS}
+    ENV ${rmw_implementation_env_var}
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    LIBRARIES ${PROJECT_NAME}
     AMENT_DEPENDENCIES ${rmw_implementation} "example_interfaces" "std_msgs"
     ${SKIP_TEST}
   )
 
   rcl_add_custom_gtest(test_rcl${target_suffix}
     SRCS rcl/test_rcl.cpp
-    ENV ${extra_test_env}
+    ENV ${rmw_implementation_env_var} ${memory_tools_ld_preload_env_var}
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    LIBRARIES ${PROJECT_NAME} osrf_testing_tools_cpp::memory_tools
     AMENT_DEPENDENCIES ${rmw_implementation}
   )
 
   rcl_add_custom_gtest(test_node${target_suffix}
     SRCS rcl/test_node.cpp
-    ENV ${extra_test_env}
+    INCLUDE_DIRS ${osrf_testing_tools_cpp_INCLUDE_DIRS}
+    ENV ${rmw_implementation_env_var} ${memory_tools_ld_preload_env_var}
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    LIBRARIES ${PROJECT_NAME} osrf_testing_tools_cpp::memory_tools
     AMENT_DEPENDENCIES ${rmw_implementation}
   )
 
   rcl_add_custom_gtest(test_arguments${target_suffix}
     SRCS rcl/test_arguments.cpp
-    ENV ${extra_test_env}
+    ENV ${rmw_implementation_env_var}
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    LIBRARIES ${PROJECT_NAME}
   )
 
   rcl_add_custom_gtest(test_remap${target_suffix}
     SRCS rcl/test_remap.cpp
-    ENV ${extra_test_env}
+    INCLUDE_DIRS ${osrf_testing_tools_cpp_INCLUDE_DIRS}
+    ENV ${rmw_implementation_env_var}
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    LIBRARIES ${PROJECT_NAME}
   )
 
   rcl_add_custom_gtest(test_remap_integration${target_suffix}
     SRCS rcl/test_remap_integration.cpp
+    INCLUDE_DIRS ${osrf_testing_tools_cpp_INCLUDE_DIRS}
     TIMEOUT 200
-    ENV ${extra_test_env}
+    ENV ${rmw_implementation_env_var}
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    LIBRARIES ${PROJECT_NAME}
     AMENT_DEPENDENCIES "std_msgs" "example_interfaces"
   )
 
   rcl_add_custom_gtest(test_guard_condition${target_suffix}
     SRCS rcl/test_guard_condition.cpp
-    ENV ${extra_test_env}
+    INCLUDE_DIRS ${osrf_testing_tools_cpp_INCLUDE_DIRS}
+    ENV ${rmw_implementation_env_var} ${memory_tools_ld_preload_env_var}
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    LIBRARIES ${PROJECT_NAME} osrf_testing_tools_cpp::memory_tools
     AMENT_DEPENDENCIES ${rmw_implementation}
   )
 
   rcl_add_custom_gtest(test_publisher${target_suffix}
     SRCS rcl/test_publisher.cpp
-    ENV ${extra_test_env}
+    INCLUDE_DIRS ${osrf_testing_tools_cpp_INCLUDE_DIRS}
+    ENV ${rmw_implementation_env_var}
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    LIBRARIES ${PROJECT_NAME}
     AMENT_DEPENDENCIES ${rmw_implementation} "std_msgs"
   )
 
   rcl_add_custom_gtest(test_service${target_suffix}
     SRCS rcl/test_service.cpp
-    ENV ${extra_test_env}
+    INCLUDE_DIRS ${osrf_testing_tools_cpp_INCLUDE_DIRS}
+    ENV ${rmw_implementation_env_var}
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    LIBRARIES ${PROJECT_NAME}
     AMENT_DEPENDENCIES ${rmw_implementation} "example_interfaces"
   )
 
   rcl_add_custom_gtest(test_subscription${target_suffix}
     SRCS rcl/test_subscription.cpp
-    ENV ${extra_test_env}
+    INCLUDE_DIRS ${osrf_testing_tools_cpp_INCLUDE_DIRS}
+    ENV ${rmw_implementation_env_var}
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    LIBRARIES ${PROJECT_NAME}
     AMENT_DEPENDENCIES ${rmw_implementation} "std_msgs"
   )
 
   rcl_add_custom_gtest(test_wait${target_suffix}
     SRCS rcl/test_wait.cpp
-    ENV ${extra_test_env}
+    INCLUDE_DIRS ${osrf_testing_tools_cpp_INCLUDE_DIRS}
+    ENV ${rmw_implementation_env_var}
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    LIBRARIES ${PROJECT_NAME}
     AMENT_DEPENDENCIES ${rmw_implementation}
   )
 
   rcl_add_custom_gtest(test_namespace${target_suffix}
     SRCS test_namespace.cpp
-    ENV ${extra_test_env}
+    INCLUDE_DIRS ${osrf_testing_tools_cpp_INCLUDE_DIRS}
+    ENV ${rmw_implementation_env_var}
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    LIBRARIES ${PROJECT_NAME}
     AMENT_DEPENDENCIES ${rmw_implementation} "example_interfaces"
   )
 
@@ -191,20 +203,22 @@ function(test_target_function)
 
   rcl_add_custom_executable(service_fixture${target_suffix}
     SRCS rcl/service_fixture.cpp
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    INCLUDE_DIRS ${osrf_testing_tools_cpp_INCLUDE_DIRS}
+    LIBRARIES ${PROJECT_NAME}
     AMENT_DEPENDENCIES ${rmw_implementation} "example_interfaces"
   )
 
   rcl_add_custom_executable(client_fixture${target_suffix}
     SRCS rcl/client_fixture.cpp
-    LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+    INCLUDE_DIRS ${osrf_testing_tools_cpp_INCLUDE_DIRS}
+    LIBRARIES ${PROJECT_NAME}
     AMENT_DEPENDENCIES ${rmw_implementation} "example_interfaces"
   )
 
   rcl_add_custom_launch_test(test_services
     service_fixture
     client_fixture
-    ENV ${extra_test_env}
+    ENV ${rmw_implementation_env_var}
     APPEND_LIBRARY_DIRS ${extra_lib_dirs}
     TIMEOUT 15
   )
@@ -249,21 +263,19 @@ call_for_each_rmw_implementation(test_target)
 
 rcl_add_custom_gtest(test_validate_topic_name
   SRCS rcl/test_validate_topic_name.cpp
-  ENV ${extra_test_env}
   APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-  LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+  LIBRARIES ${PROJECT_NAME}
 )
 
 rcl_add_custom_gtest(test_expand_topic_name
   SRCS rcl/test_expand_topic_name.cpp
-  ENV ${extra_test_env}
   APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-  LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+  LIBRARIES ${PROJECT_NAME}
 )
 
 rcl_add_custom_gtest(test_timer${target_suffix}
   SRCS rcl/test_timer.cpp
-  ENV ${extra_test_env}
+  INCLUDE_DIRS ${osrf_testing_tools_cpp_INCLUDE_DIRS}
   APPEND_LIBRARY_DIRS ${extra_lib_dirs}
-  LIBRARIES ${PROJECT_NAME} ${extra_test_libraries}
+  LIBRARIES ${PROJECT_NAME}
 )

rcl/test/memory_tools/CMakeLists.txt

@@ -1,41 +0,0 @@
-ament_find_gtest()  # For GTEST_LIBRARIES
-
-# Create the memory_tools library which is used by the tests. (rmw implementation agnostic)
-add_library(${PROJECT_NAME}_memory_tools SHARED memory_tools.cpp)
-if(APPLE)
-  # Create an OS X specific version of the memory tools that does interposing.
-  # See: http://toves.freeshell.org/interpose/
-  add_library(${PROJECT_NAME}_memory_tools_interpose SHARED memory_tools_osx_interpose.cpp)
-  target_link_libraries(${PROJECT_NAME}_memory_tools_interpose ${GTEST_LIBRARIES})
-  list(APPEND extra_test_libraries ${PROJECT_NAME}_memory_tools_interpose)
-  list(APPEND extra_test_env
-    DYLD_INSERT_LIBRARIES=$<TARGET_FILE:${PROJECT_NAME}_memory_tools_interpose>)
-endif()
-if(UNIX AND NOT APPLE)
-  # On Linux like systems, add dl and use the normal library and DL_PRELOAD.
-  list(APPEND extra_test_libraries dl)
-  list(APPEND extra_test_env DL_PRELOAD=$<TARGET_FILE:${PROJECT_NAME}_memory_tools>)
-endif()
-list(APPEND extra_lib_dirs $<TARGET_FILE_DIR:${PROJECT_NAME}_memory_tools>)
-target_link_libraries(${PROJECT_NAME}_memory_tools ${extra_test_libraries})
-target_compile_definitions(${PROJECT_NAME}_memory_tools
-  PRIVATE "RCL_MEMORY_TOOLS_BUILDING_DLL")
-list(APPEND extra_test_libraries ${PROJECT_NAME}_memory_tools)
-
-# Create tests for the memory tools library.
-set(SKIP_TEST "")
-if(WIN32)  # (memory tools doesn't do anything on Windows)
-  set(SKIP_TEST "SKIP_TEST")
-endif()
-
-include(../cmake/rcl_add_custom_gtest.cmake)
-rcl_add_custom_gtest(test_memory_tools
-  SRCS test_memory_tools.cpp
-  ENV ${extra_test_env}
-  LIBRARIES ${extra_test_libraries}
-  ${SKIP_TEST}
-)
-
-set(extra_test_libraries ${extra_test_libraries} PARENT_SCOPE)
-set(extra_test_env ${extra_test_env} PARENT_SCOPE)
-set(extra_lib_dirs ${extra_lib_dirs} PARENT_SCOPE)

rcl/test/memory_tools/memory_tools.cpp

@@ -1,143 +0,0 @@
-// Copyright 2015 Open Source Robotics Foundation, Inc.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-#if defined(__linux__)
-/******************************************************************************
- * Begin Linux
- *****************************************************************************/
-
-#include <dlfcn.h>
-#include <stdio.h>
-#include <malloc.h>
-
-#include "./memory_tools_common.cpp"
-
-void *
-malloc(size_t size)
-{
-  void * (* libc_malloc)(size_t) = (void *(*)(size_t))dlsym(RTLD_NEXT, "malloc");
-  if (enabled.load()) {
-    return custom_malloc(size);
-  }
-  return libc_malloc(size);
-}
-
-void *
-realloc(void * pointer, size_t size)
-{
-  void * (* libc_realloc)(void *, size_t) = (void *(*)(void *, size_t))dlsym(RTLD_NEXT, "realloc");
-  if (enabled.load()) {
-    return custom_realloc(pointer, size);
-  }
-  return libc_realloc(pointer, size);
-}
-
-void
-free(void * pointer)
-{
-  void (* libc_free)(void *) = (void (*)(void *))dlsym(RTLD_NEXT, "free");
-  if (enabled.load()) {
-    return custom_free(pointer);
-  }
-  return libc_free(pointer);
-}
-
-void start_memory_checking()
-{
-  if (!enabled.exchange(true)) {
-    printf("starting memory checking...\n");
-  }
-}
-
-void stop_memory_checking()
-{
-  if (enabled.exchange(false)) {
-    printf("stopping memory checking...\n");
-  }
-}
-
-/******************************************************************************
- * End Linux
- *****************************************************************************/
-#elif defined(__APPLE__)
-/******************************************************************************
- * Begin Apple
- *****************************************************************************/
-
-// The apple implementation is in a separate shared library, loaded with DYLD_INSERT_LIBRARIES.
-// Therefore we do not include the common cpp file here.
-
-void osx_start_memory_checking();
-void osx_stop_memory_checking();
-
-void start_memory_checking()
-{
-  return osx_start_memory_checking();
-}
-
-void stop_memory_checking()
-{
-  return osx_stop_memory_checking();
-}
-
-/******************************************************************************
- * End Apple
- *****************************************************************************/
-// #elif defined(_WIN32)
-/******************************************************************************
- * Begin Windows
- *****************************************************************************/
-
-// TODO(wjwwood): install custom malloc (and others) for Windows.
-
-/******************************************************************************
- * End Windows
- *****************************************************************************/
-#else
-// Default case: do nothing.
-
-#include "./memory_tools.hpp"
-
-#include <stdio.h>
-
-void start_memory_checking()
-{
-  printf("starting memory checking... not available\n");
-}
-void stop_memory_checking()
-{
-  printf("stopping memory checking... not available\n");
-}
-
-void assert_no_malloc_begin() {}
-
-void assert_no_malloc_end() {}
-
-void set_on_unexpected_malloc_callback(UnexpectedCallbackType callback) {}
-
-void assert_no_realloc_begin() {}
-
-void assert_no_realloc_end() {}
-
-void set_on_unexpected_realloc_callback(UnexpectedCallbackType callback) {}
-
-void assert_no_free_begin() {}
-
-void assert_no_free_end() {}
-
-void set_on_unexpected_free_callback(UnexpectedCallbackType callback) {}
-
-void memory_checking_thread_init() {}
-
-#endif  // if defined(__linux__) elif defined(__APPLE__) elif defined(_WIN32) else ...

rcl/test/memory_tools/memory_tools.hpp

@@ -1,132 +0,0 @@
-// Copyright 2015 Open Source Robotics Foundation, Inc.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-// Code to do replacing of malloc/free/etc... inspired by:
-//   https://dxr.mozilla.org/mozilla-central/rev/
-//    cc9c6cd756cb744596ba039dcc5ad3065a7cc3ea/memory/build/replace_malloc.c
-
-#ifndef MEMORY_TOOLS__MEMORY_TOOLS_HPP_
-#define MEMORY_TOOLS__MEMORY_TOOLS_HPP_
-
-#include <stddef.h>
-
-#include <functional>
-
-// This logic was borrowed (then namespaced) from the examples on the gcc wiki:
-//     https://gcc.gnu.org/wiki/Visibility
-
-#if defined _WIN32 || defined __CYGWIN__
-  #ifdef __GNUC__
-    #define RCL_MEMORY_TOOLS_EXPORT __attribute__ ((dllexport))
-    #define RCL_MEMORY_TOOLS_IMPORT __attribute__ ((dllimport))
-  #else
-    #define RCL_MEMORY_TOOLS_EXPORT __declspec(dllexport)
-    #define RCL_MEMORY_TOOLS_IMPORT __declspec(dllimport)
-  #endif
-  #ifdef RCL_MEMORY_TOOLS_BUILDING_DLL
-    #define RCL_MEMORY_TOOLS_PUBLIC RCL_MEMORY_TOOLS_EXPORT
-  #else
-    #define RCL_MEMORY_TOOLS_PUBLIC RCL_MEMORY_TOOLS_IMPORT
-  #endif
-  #define RCL_MEMORY_TOOLS_PUBLIC_TYPE RCL_MEMORY_TOOLS_PUBLIC
-  #define RCL_MEMORY_TOOLS_LOCAL
-#else
-  #define RCL_MEMORY_TOOLS_EXPORT __attribute__ ((visibility("default")))
-  #define RCL_MEMORY_TOOLS_IMPORT
-  #if __GNUC__ >= 4
-    #define RCL_MEMORY_TOOLS_PUBLIC __attribute__ ((visibility("default")))
-    #define RCL_MEMORY_TOOLS_LOCAL  __attribute__ ((visibility("hidden")))
-  #else
-    #define RCL_MEMORY_TOOLS_PUBLIC
-    #define RCL_MEMORY_TOOLS_LOCAL
-  #endif
-  #define RCL_MEMORY_TOOLS_PUBLIC_TYPE
-#endif
-
-typedef std::function<void ()> UnexpectedCallbackType;
-
-RCL_MEMORY_TOOLS_PUBLIC
-void
-start_memory_checking();
-
-#define ASSERT_NO_MALLOC(statements) \
-  assert_no_malloc_begin(); statements; assert_no_malloc_end();
-RCL_MEMORY_TOOLS_PUBLIC
-void
-assert_no_malloc_begin();
-RCL_MEMORY_TOOLS_PUBLIC
-void
-assert_no_malloc_end();
-RCL_MEMORY_TOOLS_PUBLIC
-void
-set_on_unexpected_malloc_callback(UnexpectedCallbackType callback);
-
-#define ASSERT_NO_REALLOC(statements) \
-  assert_no_realloc_begin(); statements; assert_no_realloc_end();
-RCL_MEMORY_TOOLS_PUBLIC
-void
-assert_no_realloc_begin();
-RCL_MEMORY_TOOLS_PUBLIC
-void
-assert_no_realloc_end();
-RCL_MEMORY_TOOLS_PUBLIC
-void
-set_on_unexpected_realloc_callback(UnexpectedCallbackType callback);
-
-#define ASSERT_NO_FREE(statements) \
-  assert_no_free_begin(); statements; assert_no_free_end();
-RCL_MEMORY_TOOLS_PUBLIC
-void
-assert_no_free_begin();
-RCL_MEMORY_TOOLS_PUBLIC
-void
-assert_no_free_end();
-RCL_MEMORY_TOOLS_PUBLIC
-void
-set_on_unexpected_free_callback(UnexpectedCallbackType callback);
-
-RCL_MEMORY_TOOLS_PUBLIC
-void
-stop_memory_checking();
-
-RCL_MEMORY_TOOLS_PUBLIC
-void
-memory_checking_thread_init();
-
-// What follows is a set of failing allocator functions, used for testing.
-void *
-failing_malloc(size_t size, void * state)
-{
-  (void)size;
-  (void)state;
-  return nullptr;
-}
-
-void *
-failing_realloc(void * pointer, size_t size, void * state)
-{
-  (void)pointer;
-  (void)size;
-  (void)state;
-  return nullptr;
-}
-
-void
-failing_free(void * pointer, void * state)
-{
-  (void)pointer;
-  (void)state;
-}
-
-#endif  // MEMORY_TOOLS__MEMORY_TOOLS_HPP_

rcl/test/memory_tools/memory_tools_common.cpp

@@ -1,166 +0,0 @@
-// Copyright 2015 Open Source Robotics Foundation, Inc.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-#include <inttypes.h>
-
-#include <atomic>
-#include <cstdlib>
-
-#if defined(__APPLE__)
-#include <malloc/malloc.h>
-#define MALLOC_PRINTF malloc_printf
-#else  // defined(__APPLE__)
-#define MALLOC_PRINTF printf
-#endif  // defined(__APPLE__)
-
-#include "./memory_tools.hpp"
-#include "../scope_exit.hpp"
-
-static std::atomic<bool> enabled(false);
-
-static __thread bool malloc_expected = true;
-static __thread UnexpectedCallbackType * unexpected_malloc_callback = nullptr;
-void set_on_unexpected_malloc_callback(UnexpectedCallbackType callback)
-{
-  if (unexpected_malloc_callback) {
-    unexpected_malloc_callback->~UnexpectedCallbackType();
-    free(unexpected_malloc_callback);
-    unexpected_malloc_callback = nullptr;
-  }
-  if (!callback) {
-    return;
-  }
-  if (!unexpected_malloc_callback) {
-    unexpected_malloc_callback =
-      reinterpret_cast<UnexpectedCallbackType *>(malloc(sizeof(UnexpectedCallbackType)));
-    if (!unexpected_malloc_callback) {
-      throw std::bad_alloc();
-    }
-    new (unexpected_malloc_callback) UnexpectedCallbackType();
-  }
-  *unexpected_malloc_callback = callback;
-}
-
-void *
-custom_malloc(size_t size)
-{
-  if (!enabled.load()) {return malloc(size);}
-  auto foo = SCOPE_EXIT(enabled.store(true););
-  enabled.store(false);
-  if (!malloc_expected) {
-    if (unexpected_malloc_callback) {
-      (*unexpected_malloc_callback)();
-    }
-  }
-  void * memory = malloc(size);
-  uint64_t fw_size = size;
-  if (!malloc_expected) {
-    MALLOC_PRINTF(
-      " malloc (%s) %p %" PRIu64 "\n",
-      malloc_expected ? "    expected" : "not expected", memory, fw_size);
-  }
-  return memory;
-}
-
-static __thread bool realloc_expected = true;
-static __thread UnexpectedCallbackType * unexpected_realloc_callback = nullptr;
-void set_on_unexpected_realloc_callback(UnexpectedCallbackType callback)
-{
-  if (unexpected_realloc_callback) {
-    unexpected_realloc_callback->~UnexpectedCallbackType();
-    free(unexpected_realloc_callback);
-    unexpected_realloc_callback = nullptr;
-  }
-  if (!callback) {
-    return;
-  }
-  if (!unexpected_realloc_callback) {
-    unexpected_realloc_callback =
-      reinterpret_cast<UnexpectedCallbackType *>(malloc(sizeof(UnexpectedCallbackType)));
-    if (!unexpected_realloc_callback) {
-      throw std::bad_alloc();
-    }
-    new (unexpected_realloc_callback) UnexpectedCallbackType();
-  }
-  *unexpected_realloc_callback = callback;
-}
-
-void *
-custom_realloc(void * memory_in, size_t size)
-{
-  if (!enabled.load()) {return realloc(memory_in, size);}
-  auto foo = SCOPE_EXIT(enabled.store(true););
-  enabled.store(false);
-  if (!realloc_expected) {
-    if (unexpected_realloc_callback) {
-      (*unexpected_realloc_callback)();
-    }
-  }
-  void * memory = realloc(memory_in, size);
-  uint64_t fw_size = size;
-  if (!realloc_expected) {
-    MALLOC_PRINTF(
-      "realloc (%s) %p %p %" PRIu64 "\n",
-      realloc_expected ? "    expected" : "not expected", memory_in, memory, fw_size);
-  }
-  return memory;
-}
-
-static __thread bool free_expected = true;
-static __thread UnexpectedCallbackType * unexpected_free_callback = nullptr;
-void set_on_unexpected_free_callback(UnexpectedCallbackType callback)
-{
-  if (unexpected_free_callback) {
-    unexpected_free_callback->~UnexpectedCallbackType();
-    free(unexpected_free_callback);
-    unexpected_free_callback = nullptr;
-  }
-  if (!callback) {
-    return;
-  }
-  if (!unexpected_free_callback) {
-    unexpected_free_callback =
-      reinterpret_cast<UnexpectedCallbackType *>(malloc(sizeof(UnexpectedCallbackType)));
-    if (!unexpected_free_callback) {
-      throw std::bad_alloc();
-    }
-    new (unexpected_free_callback) UnexpectedCallbackType();
-  }
-  *unexpected_free_callback = callback;
-}
-
-void
-custom_free(void * memory)
-{
-  if (!enabled.load()) {return free(memory);}
-  auto foo = SCOPE_EXIT(enabled.store(true););
-  enabled.store(false);
-  if (!free_expected) {
-    if (unexpected_free_callback) {
-      (*unexpected_free_callback)();
-    }
-  }
-  if (!free_expected) {
-    MALLOC_PRINTF(
-      "   free (%s) %p\n", free_expected ? "    expected" : "not expected", memory);
-  }
-  free(memory);
-}
-
-void assert_no_malloc_begin() {malloc_expected = false;}
-void assert_no_malloc_end() {malloc_expected = true;}
-void assert_no_realloc_begin() {realloc_expected = false;}
-void assert_no_realloc_end() {realloc_expected = true;}
-void assert_no_free_begin() {free_expected = false;}
-void assert_no_free_end() {free_expected = true;}

rcl/test/memory_tools/memory_tools_osx_interpose.cpp

@@ -1,57 +0,0 @@
-// Copyright 2015 Open Source Robotics Foundation, Inc.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-// Pulled from:
-//  https://github.com/emeryberger/Heap-Layers/blob/
-//    076e9e7ef53b66380b159e40473b930f25cc353b/wrappers/macinterpose.h
-
-// The interposition data structure (just pairs of function pointers),
-// used an interposition table like the following:
-//
-
-typedef struct interpose_s
-{
-  void * new_func;
-  void * orig_func;
-} interpose_t;
-
-#define OSX_INTERPOSE(newf, oldf) \
-  __attribute__((used)) static const interpose_t \
-  macinterpose ## newf ## oldf __attribute__ ((section("__DATA, __interpose"))) = { \
-    reinterpret_cast<void *>(newf), \
-    reinterpret_cast<void *>(oldf), \
-  }
-
-// End Interpose.
-
-#include "./memory_tools_common.cpp"
-
-void osx_start_memory_checking()
-{
-  // No loading required, it is handled by DYLD_INSERT_LIBRARIES and dynamic library interposing.
-  if (!enabled.exchange(true)) {
-    MALLOC_PRINTF("starting memory checking...\n");
-  }
-}
-
-void osx_stop_memory_checking()
-{
-  if (enabled.exchange(false)) {
-    MALLOC_PRINTF("stopping memory checking...\n");
-  }
-}
-
-OSX_INTERPOSE(custom_malloc, malloc);
-OSX_INTERPOSE(custom_realloc, realloc);
-OSX_INTERPOSE(custom_free, free);

rcl/test/memory_tools/test_memory_tools.cpp

@@ -1,136 +0,0 @@
-// Copyright 2015 Open Source Robotics Foundation, Inc.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-#include <gtest/gtest.h>
-
-#include "./memory_tools.hpp"
-
-/* Tests the allocatation checking tools.
- */
-TEST(TestMemoryTools, test_allocation_checking_tools) {
-  size_t unexpected_mallocs = 0;
-  auto on_unexpected_malloc =
-    [&unexpected_mallocs]() {
-      unexpected_mallocs++;
-    };
-  set_on_unexpected_malloc_callback(on_unexpected_malloc);
-  size_t unexpected_reallocs = 0;
-  auto on_unexpected_realloc =
-    [&unexpected_reallocs]() {
-      unexpected_reallocs++;
-    };
-  set_on_unexpected_realloc_callback(on_unexpected_realloc);
-  size_t unexpected_frees = 0;
-  auto on_unexpected_free =
-    [&unexpected_frees]() {
-      unexpected_frees++;
-    };
-  set_on_unexpected_free_callback(on_unexpected_free);
-  void * mem = nullptr;
-  void * remem = nullptr;
-  // First try before enabling, should have no effect.
-  mem = malloc(1024);
-  ASSERT_NE(mem, nullptr);
-  remem = realloc(mem, 2048);
-  ASSERT_NE(remem, nullptr);
-  if (!remem) {free(mem);}
-  free(remem);
-  EXPECT_EQ(unexpected_mallocs, 0u);
-  EXPECT_EQ(unexpected_reallocs, 0u);
-  EXPECT_EQ(unexpected_frees, 0u);
-  // Enable checking, but no assert, should have no effect.
-  start_memory_checking();
-  mem = malloc(1024);
-  ASSERT_NE(mem, nullptr);
-  remem = realloc(mem, 2048);
-  ASSERT_NE(remem, nullptr);
-  if (!remem) {free(mem);}
-  free(remem);
-  EXPECT_EQ(unexpected_mallocs, 0u);
-  EXPECT_EQ(unexpected_reallocs, 0u);
-  EXPECT_EQ(unexpected_frees, 0u);
-  // Enable no_* asserts, should increment all once.
-  assert_no_malloc_begin();
-  assert_no_realloc_begin();
-  assert_no_free_begin();
-  mem = malloc(1024);
-  assert_no_malloc_end();
-  ASSERT_NE(mem, nullptr);
-  remem = realloc(mem, 2048);
-  assert_no_realloc_end();
-  ASSERT_NE(remem, nullptr);
-  if (!remem) {free(mem);}
-  free(remem);
-  assert_no_free_end();
-  EXPECT_EQ(unexpected_mallocs, 1u);
-  EXPECT_EQ(unexpected_reallocs, 1u);
-  EXPECT_EQ(unexpected_frees, 1u);
-  // Enable on malloc assert, only malloc should increment.
-  assert_no_malloc_begin();
-  mem = malloc(1024);
-  assert_no_malloc_end();
-  ASSERT_NE(mem, nullptr);
-  remem = realloc(mem, 2048);
-  ASSERT_NE(remem, nullptr);
-  if (!remem) {free(mem);}
-  free(remem);
-  EXPECT_EQ(unexpected_mallocs, 2u);
-  EXPECT_EQ(unexpected_reallocs, 1u);
-  EXPECT_EQ(unexpected_frees, 1u);
-  // Enable on realloc assert, only realloc should increment.
-  assert_no_realloc_begin();
-  mem = malloc(1024);
-  ASSERT_NE(mem, nullptr);
-  remem = realloc(mem, 2048);
-  assert_no_realloc_end();
-  ASSERT_NE(remem, nullptr);
-  if (!remem) {free(mem);}
-  free(remem);
-  EXPECT_EQ(unexpected_mallocs, 2u);
-  EXPECT_EQ(unexpected_reallocs, 2u);
-  EXPECT_EQ(unexpected_frees, 1u);
-  // Enable on free assert, only free should increment.
-  assert_no_free_begin();
-  mem = malloc(1024);
-  ASSERT_NE(mem, nullptr);
-  remem = realloc(mem, 2048);
-  ASSERT_NE(remem, nullptr);
-  if (!remem) {free(mem);}
-  free(remem);
-  assert_no_free_end();
-  EXPECT_EQ(unexpected_mallocs, 2u);
-  EXPECT_EQ(unexpected_reallocs, 2u);
-  EXPECT_EQ(unexpected_frees, 2u);
-  // Go again, after disabling asserts, should have no effect.
-  mem = malloc(1024);
-  ASSERT_NE(mem, nullptr);
-  remem = realloc(mem, 2048);
-  ASSERT_NE(remem, nullptr);
-  if (!remem) {free(mem);}
-  free(remem);
-  EXPECT_EQ(unexpected_mallocs, 2u);
-  EXPECT_EQ(unexpected_reallocs, 2u);
-  EXPECT_EQ(unexpected_frees, 2u);
-  // Go once more after disabling everything, should have no effect.
-  stop_memory_checking();
-  mem = malloc(1024);
-  ASSERT_NE(mem, nullptr);
-  remem = realloc(mem, 2048);
-  ASSERT_NE(remem, nullptr);
-  if (!remem) {free(mem);}
-  free(remem);
-  EXPECT_EQ(unexpected_mallocs, 2u);
-  EXPECT_EQ(unexpected_reallocs, 2u);
-  EXPECT_EQ(unexpected_frees, 2u);
-}

rcl/test/rcl/arg_macros.hpp

@@ -19,7 +19,7 @@
 #include "rcl/rcl.h"
 #include "rcutils/strdup.h"
 
-#include "../scope_exit.hpp"
+#include "osrf_testing_tools_cpp/scope_exit.hpp"
 
 /// Helper to get around non-const args passed to rcl_init().
 char **
@@ -52,8 +52,7 @@ destroy_args(int argc, char ** args)
     rcl_ret_t ret = rcl_init(argc, argv, rcl_get_default_allocator()); \
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe(); \
   } \
-  auto __scope_global_args_exit = make_scope_exit( \
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({ \
-    [argc, argv] { \
     destroy_args(argc, argv); \
     rcl_ret_t ret = rcl_shutdown(); \
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe(); \
@@ -68,8 +67,7 @@ destroy_args(int argc, char ** args)
       local_argc, local_argv, rcl_get_default_allocator(), &local_arguments); \
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe(); \
   } \
-  auto __scope_ ## local_arguments ## _exit = make_scope_exit( \
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({ \
-    [&local_arguments] { \
     ASSERT_EQ(RCL_RET_OK, rcl_arguments_fini(&local_arguments)); \
   })
 

rcl/test/rcl/client_fixture.cpp

@@ -23,8 +23,7 @@
 
 #include "example_interfaces/srv/add_two_ints.h"
 
-#include "../memory_tools/memory_tools.hpp"
+#include "osrf_testing_tools_cpp/scope_exit.hpp"
-#include "../scope_exit.hpp"
 #include "rcl/error_handling.h"
 #include "rcl/graph.h"
 
@@ -68,8 +67,7 @@ wait_for_client_to_be_ready(
       ROS_PACKAGE_NAME, "Error in wait set init: %s", rcl_get_error_string_safe())
     return false;
   }
-  auto wait_set_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&wait_set]() {
     if (rcl_wait_set_fini(&wait_set) != RCL_RET_OK) {
       RCUTILS_LOG_ERROR_NAMED(
         ROS_PACKAGE_NAME, "Error in wait set fini: %s", rcl_get_error_string_safe())
@@ -123,8 +121,7 @@ int main(int argc, char ** argv)
         ROS_PACKAGE_NAME, "Error in node init: %s", rcl_get_error_string_safe())
       return -1;
     }
-    auto node_exit = make_scope_exit(
+    OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-      [&main_ret, &node]() {
       if (rcl_node_fini(&node) != RCL_RET_OK) {
         RCUTILS_LOG_ERROR_NAMED(
           ROS_PACKAGE_NAME, "Error in node fini: %s", rcl_get_error_string_safe())
@@ -145,8 +142,7 @@ int main(int argc, char ** argv)
       return -1;
     }
 
-    auto client_exit = make_scope_exit(
+    OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-      [&client, &main_ret, &node]() {
       if (rcl_client_fini(&client, &node)) {
         RCUTILS_LOG_ERROR_NAMED(
           ROS_PACKAGE_NAME, "Error in client fini: %s", rcl_get_error_string_safe())

rcl/test/rcl/failing_allocator_functions.hpp

@@ -0,0 +1,54 @@
+// Copyright 2016 Open Source Robotics Foundation, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef RCL__FAILING_ALLOCATOR_FUNCTIONS_HPP_
+#define RCL__FAILING_ALLOCATOR_FUNCTIONS_HPP_
+
+#include <cstdlib>
+
+extern "C"
+{
+inline
+void *
+failing_malloc(size_t size, void * state)
+{
+  (void)size;
+  (void)state;
+  return nullptr;
+}
+
+inline
+void *
+failing_realloc(void * memory_in, size_t size, void * state)
+{
+  (void)memory_in;
+  (void)size;
+  (void)state;
+  // this is the right fail case, i.e. if failed, the memory_in is not free'd
+  // see reallocf() for this behavior fix
+  return nullptr;
+}
+
+inline
+void *
+failing_calloc(size_t count, size_t size, void * state)
+{
+  (void)count;
+  (void)size;
+  (void)state;
+  return nullptr;
+}
+}  // extern "C"
+
+#endif  // RCL__FAILING_ALLOCATOR_FUNCTIONS_HPP_

rcl/test/rcl/service_fixture.cpp

@@ -24,8 +24,7 @@
 
 #include "example_interfaces/srv/add_two_ints.h"
 
-#include "../memory_tools/memory_tools.hpp"
+#include "osrf_testing_tools_cpp/scope_exit.hpp"
-#include "../scope_exit.hpp"
 #include "rcl/error_handling.h"
 
 bool
@@ -41,8 +40,7 @@ wait_for_service_to_be_ready(
       ROS_PACKAGE_NAME, "Error in wait set init: %s", rcl_get_error_string_safe())
     return false;
   }
-  auto wait_set_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&wait_set]() {
     if (rcl_wait_set_fini(&wait_set) != RCL_RET_OK) {
       RCUTILS_LOG_ERROR_NAMED(
         ROS_PACKAGE_NAME, "Error in wait set fini: %s", rcl_get_error_string_safe())
@@ -96,8 +94,7 @@ int main(int argc, char ** argv)
         ROS_PACKAGE_NAME, "Error in node init: %s", rcl_get_error_string_safe())
       return -1;
     }
-    auto node_exit = make_scope_exit(
+    OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-      [&main_ret, &node]() {
       if (rcl_node_fini(&node) != RCL_RET_OK) {
         RCUTILS_LOG_ERROR_NAMED(
           ROS_PACKAGE_NAME, "Error in node fini: %s", rcl_get_error_string_safe())
@@ -118,8 +115,7 @@ int main(int argc, char ** argv)
       return -1;
     }
 
-    auto service_exit = make_scope_exit(
+    OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-      [&main_ret, &service, &node]() {
       if (rcl_service_fini(&service, &node)) {
         RCUTILS_LOG_ERROR_NAMED(
           ROS_PACKAGE_NAME, "Error in service fini: %s", rcl_get_error_string_safe())
@@ -130,8 +126,7 @@ int main(int argc, char ** argv)
     // Initialize a response.
     example_interfaces__srv__AddTwoInts_Response service_response;
     example_interfaces__srv__AddTwoInts_Response__init(&service_response);
-    auto response_exit = make_scope_exit(
+    OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-      [&service_response]() {
       example_interfaces__srv__AddTwoInts_Response__fini(&service_response);
     });
 
@@ -145,8 +140,7 @@ int main(int argc, char ** argv)
     // Take the pending request.
     example_interfaces__srv__AddTwoInts_Request service_request;
     example_interfaces__srv__AddTwoInts_Request__init(&service_request);
-    auto request_exit = make_scope_exit(
+    OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-      [&service_request]() {
       example_interfaces__srv__AddTwoInts_Request__fini(&service_request);
     });
     rmw_request_id_t header;

rcl/test/rcl/test_client.cpp

@@ -21,8 +21,8 @@
 #include "example_interfaces/srv/add_two_ints.h"
 #include "rosidl_generator_c/string_functions.h"
 
-#include "../memory_tools/memory_tools.hpp"
+#include "./failing_allocator_functions.hpp"
-#include "../scope_exit.hpp"
+#include "osrf_testing_tools_cpp/scope_exit.hpp"
 #include "rcl/error_handling.h"
 
 class TestClientFixture : public ::testing::Test
@@ -31,7 +31,6 @@ public:
   rcl_node_t * node_ptr;
   void SetUp()
   {
-    stop_memory_checking();
     rcl_ret_t ret;
     ret = rcl_init(0, nullptr, rcl_get_default_allocator());
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
@@ -41,21 +40,10 @@ public:
     rcl_node_options_t node_options = rcl_node_get_default_options();
     ret = rcl_node_init(this->node_ptr, name, "", &node_options);
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-    set_on_unexpected_malloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED MALLOC";});
-    set_on_unexpected_realloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED REALLOC";});
-    set_on_unexpected_free_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED FREE";});
-    start_memory_checking();
   }
 
   void TearDown()
   {
-    assert_no_malloc_end();
-    assert_no_realloc_end();
-    assert_no_free_end();
-    stop_memory_checking();
-    set_on_unexpected_malloc_callback(nullptr);
-    set_on_unexpected_realloc_callback(nullptr);
-    set_on_unexpected_free_callback(nullptr);
     rcl_ret_t ret = rcl_node_fini(this->node_ptr);
     delete this->node_ptr;
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
@@ -67,7 +55,6 @@ public:
 /* Basic nominal test of a client.
  */
 TEST_F(TestClientFixture, test_client_nominal) {
-  stop_memory_checking();
   rcl_ret_t ret;
   rcl_client_t client = rcl_get_zero_initialized_client();
 
@@ -84,9 +71,7 @@ TEST_F(TestClientFixture, test_client_nominal) {
   ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   EXPECT_EQ(strcmp(rcl_client_get_service_name(&client), expected_topic_name), 0);
 
-  auto client_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&client, this]() {
-      stop_memory_checking();
     rcl_ret_t ret = rcl_client_fini(&client, this->node_ptr);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   });
@@ -108,7 +93,6 @@ TEST_F(TestClientFixture, test_client_nominal) {
 /* Testing the client init and fini functions.
  */
 TEST_F(TestClientFixture, test_client_init_fini) {
-  stop_memory_checking();
   rcl_ret_t ret;
   // Setup valid inputs.
   rcl_client_t client;
@@ -197,7 +181,6 @@ TEST_F(TestClientFixture, test_client_init_fini) {
   rcl_client_options_t client_options_with_failing_allocator;
   client_options_with_failing_allocator = rcl_client_get_default_options();
   client_options_with_failing_allocator.allocator.allocate = failing_malloc;
-  client_options_with_failing_allocator.allocator.deallocate = failing_free;
   client_options_with_failing_allocator.allocator.reallocate = failing_realloc;
   ret = rcl_client_init(
     &client, this->node_ptr, ts, topic_name, &client_options_with_failing_allocator);

rcl/test/rcl/test_get_node_names.cpp

@@ -25,7 +25,6 @@
 #include "rcl/rcl.h"
 #include "rmw/rmw.h"
 
-#include "../memory_tools/memory_tools.hpp"
 #include "rcl/error_handling.h"
 
 #ifdef RMW_IMPLEMENTATION
@@ -41,23 +40,10 @@ class CLASSNAME (TestGetNodeNames, RMW_IMPLEMENTATION) : public ::testing::Test
 {
 public:
   void SetUp()
-  {
+  {}
-    set_on_unexpected_malloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED MALLOC";});
-    set_on_unexpected_realloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED REALLOC";});
-    set_on_unexpected_free_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED FREE";});
-    start_memory_checking();
-  }
 
   void TearDown()
-  {
+  {}
-    assert_no_malloc_end();
-    assert_no_realloc_end();
-    assert_no_free_end();
-    stop_memory_checking();
-    set_on_unexpected_malloc_callback(nullptr);
-    set_on_unexpected_realloc_callback(nullptr);
-    set_on_unexpected_free_callback(nullptr);
-  }
 };
 
 TEST_F(CLASSNAME(TestGetNodeNames, RMW_IMPLEMENTATION), test_rcl_get_node_names) {

rcl/test/rcl/test_graph.cpp

@@ -35,8 +35,7 @@
 #include "std_msgs/msg/string.h"
 #include "example_interfaces/srv/add_two_ints.h"
 
-#include "../memory_tools/memory_tools.hpp"
+#include "osrf_testing_tools_cpp/scope_exit.hpp"
-#include "../scope_exit.hpp"
 #include "rcl/error_handling.h"
 
 #ifdef RMW_IMPLEMENTATION
@@ -57,7 +56,6 @@ public:
   rcl_wait_set_t * wait_set_ptr;
   void SetUp()
   {
-    stop_memory_checking();
     rcl_ret_t ret;
     ret = rcl_init(0, nullptr, rcl_get_default_allocator());
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
@@ -81,22 +79,10 @@ public:
     this->wait_set_ptr = new rcl_wait_set_t;
     *this->wait_set_ptr = rcl_get_zero_initialized_wait_set();
     ret = rcl_wait_set_init(this->wait_set_ptr, 0, 1, 0, 0, 0, rcl_get_default_allocator());
-
-    set_on_unexpected_malloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED MALLOC";});
-    set_on_unexpected_realloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED REALLOC";});
-    set_on_unexpected_free_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED FREE";});
-    start_memory_checking();
   }
 
   void TearDown()
   {
-    assert_no_malloc_end();
-    assert_no_realloc_end();
-    assert_no_free_end();
-    stop_memory_checking();
-    set_on_unexpected_malloc_callback(nullptr);
-    set_on_unexpected_realloc_callback(nullptr);
-    set_on_unexpected_free_callback(nullptr);
     rcl_ret_t ret;
     ret = rcl_node_fini(this->old_node_ptr);
     delete this->old_node_ptr;
@@ -123,7 +109,6 @@ TEST_F(
   CLASSNAME(TestGraphFixture, RMW_IMPLEMENTATION),
   test_rcl_get_and_destroy_topic_names_and_types
 ) {
-  stop_memory_checking();
   rcl_ret_t ret;
   rcl_allocator_t allocator = rcl_get_default_allocator();
   rcl_names_and_types_t tnat {};
@@ -165,7 +150,6 @@ TEST_F(
   CLASSNAME(TestGraphFixture, RMW_IMPLEMENTATION),
   test_rcl_count_publishers
 ) {
-  stop_memory_checking();
   rcl_ret_t ret;
   rcl_node_t zero_node = rcl_get_zero_initialized_node();
   const char * topic_name = "/topic_test_rcl_count_publishers";
@@ -203,7 +187,6 @@ TEST_F(
   CLASSNAME(TestGraphFixture, RMW_IMPLEMENTATION),
   test_rcl_count_subscribers
 ) {
-  stop_memory_checking();
   rcl_ret_t ret;
   rcl_node_t zero_node = rcl_get_zero_initialized_node();
   const char * topic_name = "/topic_test_rcl_count_subscribers";
@@ -330,7 +313,6 @@ check_graph_state(
 /* Test graph queries with a hand crafted graph.
  */
 TEST_F(CLASSNAME(TestGraphFixture, RMW_IMPLEMENTATION), test_graph_query_functions) {
-  stop_memory_checking();
   std::string topic_name("/test_graph_query_functions__");
   std::chrono::nanoseconds now = std::chrono::system_clock::now().time_since_epoch();
   topic_name += std::to_string(now.count());
@@ -416,7 +398,6 @@ TEST_F(CLASSNAME(TestGraphFixture, RMW_IMPLEMENTATION), test_graph_query_functio
  * Note: this test could be impacted by other communications on the same ROS Domain.
  */
 TEST_F(CLASSNAME(TestGraphFixture, RMW_IMPLEMENTATION), test_graph_guard_condition_topics) {
-  stop_memory_checking();
   rcl_ret_t ret;
   // Create a thread to sleep for a time, then create a publisher, sleep more, then a subscriber,
   // sleep more, destroy the subscriber, sleep more, and then destroy the publisher.
@@ -485,7 +466,6 @@ TEST_F(CLASSNAME(TestGraphFixture, RMW_IMPLEMENTATION), test_graph_guard_conditi
 /* Test the rcl_service_server_is_available function.
  */
 TEST_F(CLASSNAME(TestGraphFixture, RMW_IMPLEMENTATION), test_rcl_service_server_is_available) {
-  stop_memory_checking();
   rcl_ret_t ret;
   // First create a client which will be used to call the function.
   rcl_client_t client = rcl_get_zero_initialized_client();
@@ -494,9 +474,7 @@ TEST_F(CLASSNAME(TestGraphFixture, RMW_IMPLEMENTATION), test_rcl_service_server_
   rcl_client_options_t client_options = rcl_client_get_default_options();
   ret = rcl_client_init(&client, this->node_ptr, ts, service_name, &client_options);
   ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-  auto client_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&client, this]() {
-      stop_memory_checking();
     rcl_ret_t ret = rcl_client_fini(&client, this->node_ptr);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   });
@@ -563,9 +541,7 @@ TEST_F(CLASSNAME(TestGraphFixture, RMW_IMPLEMENTATION), test_rcl_service_server_
     rcl_service_options_t service_options = rcl_service_get_default_options();
     ret = rcl_service_init(&service, this->node_ptr, ts, service_name, &service_options);
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-    auto service_exit = make_scope_exit(
+    OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-      [&service, this]() {
-        stop_memory_checking();
       rcl_ret_t ret = rcl_service_fini(&service, this->node_ptr);
       EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
     });

rcl/test/rcl/test_guard_condition.cpp

@@ -19,8 +19,9 @@
 #include "rcl/rcl.h"
 #include "rcl/guard_condition.h"
 
-#include "../memory_tools/memory_tools.hpp"
+#include "./failing_allocator_functions.hpp"
-#include "../scope_exit.hpp"
+#include "osrf_testing_tools_cpp/memory_tools/memory_tools.hpp"
+#include "osrf_testing_tools_cpp/scope_exit.hpp"
 #include "rcl/error_handling.h"
 
 #ifdef RMW_IMPLEMENTATION
@@ -30,26 +31,26 @@
 # define CLASSNAME(NAME, SUFFIX) NAME
 #endif
 
+using osrf_testing_tools_cpp::memory_tools::on_unexpected_malloc;
+using osrf_testing_tools_cpp::memory_tools::on_unexpected_realloc;
+using osrf_testing_tools_cpp::memory_tools::on_unexpected_calloc;
+using osrf_testing_tools_cpp::memory_tools::on_unexpected_free;
+
 class CLASSNAME (TestGuardConditionFixture, RMW_IMPLEMENTATION) : public ::testing::Test
 {
 public:
   void SetUp()
   {
-    set_on_unexpected_malloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED MALLOC";});
+    osrf_testing_tools_cpp::memory_tools::initialize();
-    set_on_unexpected_realloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED REALLOC";});
+    on_unexpected_malloc([]() {ASSERT_FALSE(true) << "UNEXPECTED MALLOC";});
-    set_on_unexpected_free_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED FREE";});
+    on_unexpected_realloc([]() {ASSERT_FALSE(true) << "UNEXPECTED REALLOC";});
-    start_memory_checking();
+    on_unexpected_calloc([]() {ASSERT_FALSE(true) << "UNEXPECTED CALLOC";});
+    on_unexpected_free([]() {ASSERT_FALSE(true) << "UNEXPECTED FREE";});
   }
 
   void TearDown()
   {
-    assert_no_malloc_end();
+    osrf_testing_tools_cpp::memory_tools::uninitialize();
-    assert_no_realloc_end();
-    assert_no_free_end();
-    stop_memory_checking();
-    set_on_unexpected_malloc_callback(nullptr);
-    set_on_unexpected_realloc_callback(nullptr);
-    set_on_unexpected_free_callback(nullptr);
   }
 };
 
@@ -57,16 +58,16 @@ public:
  */
 TEST_F(
   CLASSNAME(TestGuardConditionFixture, RMW_IMPLEMENTATION), test_rcl_guard_condition_accessors) {
-  stop_memory_checking();
+  osrf_testing_tools_cpp::memory_tools::enable_monitoring_in_all_threads();
+
   rcl_ret_t ret;
 
   // Initialize rcl with rcl_init().
   ret = rcl_init(0, nullptr, rcl_get_default_allocator());
   ASSERT_EQ(RCL_RET_OK, ret);
   // Setup automatic rcl_shutdown()
-  auto rcl_shutdown_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    []() {
+    osrf_testing_tools_cpp::memory_tools::disable_monitoring_in_all_threads();
-      stop_memory_checking();
     rcl_ret_t ret = rcl_shutdown();
     ASSERT_EQ(RCL_RET_OK, ret);
   });
@@ -80,9 +81,8 @@ TEST_F(
   ret = rcl_guard_condition_init(&guard_condition, default_options);
   ASSERT_EQ(RCL_RET_OK, ret);
   // Setup automatic finalization of guard condition.
-  auto rcl_guard_condition_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&guard_condition]() {
+    osrf_testing_tools_cpp::memory_tools::disable_monitoring_in_all_threads();
-      stop_memory_checking();
     rcl_ret_t ret = rcl_guard_condition_fini(&guard_condition);
     EXPECT_EQ(RCL_RET_OK, ret);
   });
@@ -95,15 +95,9 @@ TEST_F(
   actual_options = rcl_guard_condition_get_options(&zero_guard_condition);
   EXPECT_EQ(nullptr, actual_options);
   rcl_reset_error();
-  start_memory_checking();
+  EXPECT_NO_MEMORY_OPERATIONS({
-  assert_no_malloc_begin();
-  assert_no_realloc_begin();
-  assert_no_free_begin();
     actual_options = rcl_guard_condition_get_options(&guard_condition);
-  assert_no_malloc_end();
+  });
-  assert_no_realloc_end();
-  assert_no_free_end();
-  stop_memory_checking();
   EXPECT_NE(nullptr, actual_options);
   if (actual_options) {
     EXPECT_EQ(default_options.allocator.allocate, actual_options->allocator.allocate);
@@ -116,15 +110,9 @@ TEST_F(
   gc_handle = rcl_guard_condition_get_rmw_handle(&zero_guard_condition);
   EXPECT_EQ(nullptr, gc_handle);
   rcl_reset_error();
-  start_memory_checking();
+  EXPECT_NO_MEMORY_OPERATIONS({
-  assert_no_malloc_begin();
-  assert_no_realloc_begin();
-  assert_no_free_begin();
     gc_handle = rcl_guard_condition_get_rmw_handle(&guard_condition);
-  assert_no_malloc_end();
+  });
-  assert_no_realloc_end();
-  assert_no_free_end();
-  stop_memory_checking();
   EXPECT_NE(nullptr, gc_handle);
 }
 
@@ -132,7 +120,6 @@ TEST_F(
  */
 TEST_F(
   CLASSNAME(TestGuardConditionFixture, RMW_IMPLEMENTATION), test_rcl_guard_condition_life_cycle) {
-  stop_memory_checking();
   rcl_ret_t ret;
   rcl_guard_condition_t guard_condition = rcl_get_zero_initialized_guard_condition();
   rcl_guard_condition_options_t default_options = rcl_guard_condition_get_default_options();
@@ -144,8 +131,7 @@ TEST_F(
   // Initialize rcl with rcl_init().
   ret = rcl_init(0, nullptr, rcl_get_default_allocator());
   ASSERT_EQ(RCL_RET_OK, ret);
-  auto rcl_shutdown_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    []() {
     rcl_ret_t ret = rcl_shutdown();
     ASSERT_EQ(RCL_RET_OK, ret);
   });
@@ -168,8 +154,8 @@ TEST_F(
   rcl_guard_condition_options_t options_with_failing_allocator =
     rcl_guard_condition_get_default_options();
   options_with_failing_allocator.allocator.allocate = failing_malloc;
-  options_with_failing_allocator.allocator.deallocate = failing_free;
   options_with_failing_allocator.allocator.reallocate = failing_realloc;
+  options_with_failing_allocator.allocator.zero_allocate = failing_calloc;
   ret = rcl_guard_condition_init(&guard_condition, options_with_failing_allocator);
   ASSERT_EQ(RCL_RET_BAD_ALLOC, ret) << "Expected RCL_RET_BAD_ALLOC";
   // The error will not be set because the allocator will not work.

rcl/test/rcl/test_lexer_lookahead.cpp

@@ -16,7 +16,7 @@
 
 #include <string>
 
-#include "../scope_exit.hpp"
+#include "osrf_testing_tools_cpp/scope_exit.hpp"
 
 #include "rcl/error_handling.h"
 #include "rcl/lexer_lookahead.h"
@@ -46,7 +46,7 @@ public:
     rcl_ret_t ret = rcl_lexer_lookahead2_init(&name, text, rcl_get_default_allocator()); \
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe(); \
   } \
-  auto __scope_lookahead2_ ## name = make_scope_exit( \
+  auto __scope_lookahead2_ ## name = osrf_testing_tools_cpp::make_scope_exit( \
     [&name]() { \
       rcl_ret_t ret = rcl_lexer_lookahead2_fini(&buffer); \
       ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe(); \

rcl/test/rcl/test_node.cpp

@@ -14,14 +14,16 @@
 
 #include <gtest/gtest.h>
 
+#include <regex>
 #include <string>
 
 #include "rcl/rcl.h"
 #include "rcl/node.h"
 #include "rmw/rmw.h"  // For rmw_get_implementation_identifier.
 
-#include "../memory_tools/memory_tools.hpp"
+#include "./failing_allocator_functions.hpp"
-#include "../scope_exit.hpp"
+#include "osrf_testing_tools_cpp/memory_tools/memory_tools.hpp"
+#include "osrf_testing_tools_cpp/scope_exit.hpp"
 #include "rcl/error_handling.h"
 
 #ifdef RMW_IMPLEMENTATION
@@ -31,26 +33,42 @@
 # define CLASSNAME(NAME, SUFFIX) NAME
 #endif
 
+using osrf_testing_tools_cpp::memory_tools::on_unexpected_malloc;
+using osrf_testing_tools_cpp::memory_tools::on_unexpected_realloc;
+using osrf_testing_tools_cpp::memory_tools::on_unexpected_calloc;
+using osrf_testing_tools_cpp::memory_tools::on_unexpected_free;
+
 class CLASSNAME (TestNodeFixture, RMW_IMPLEMENTATION) : public ::testing::Test
 {
 public:
   void SetUp()
   {
-    set_on_unexpected_malloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED MALLOC";});
+    auto common =
-    set_on_unexpected_realloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED REALLOC";});
+      [](auto service, const char * name) {
-    set_on_unexpected_free_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED FREE";});
+        // only fail if call originated in our library, librcl.<something>
-    start_memory_checking();
+        std::regex pattern("/?librcl\\.");
+        auto st = service.get_stack_trace();  // nullptr if stack trace not available
+        if (st && st->matches_any_object_filename(pattern)) {
+          // Implicitly this means if one of the rmw implementations uses threads
+          // and does memory allocations in them, but the calls didn't originate
+          // from an rcl call, we will ignore it.
+          // The goal here is ensure that no rcl function or thread is using memory.
+          // Separate tests will be needed to ensure the rmw implementation does
+          // not allocate memory or cause it to be allocated.
+          service.print_backtrace();
+          ADD_FAILURE() << "Unexpected call to " << name << " originating from within librcl.";
+        }
+      };
+    osrf_testing_tools_cpp::memory_tools::initialize();
+    on_unexpected_malloc([common](auto service) {common(service, "malloc");});
+    on_unexpected_realloc([common](auto service) {common(service, "realloc");});
+    on_unexpected_calloc([common](auto service) {common(service, "calloc");});
+    on_unexpected_free([common](auto service) {common(service, "free");});
   }
 
   void TearDown()
   {
-    assert_no_malloc_end();
+    osrf_testing_tools_cpp::memory_tools::uninitialize();
-    assert_no_realloc_end();
-    assert_no_free_end();
-    stop_memory_checking();
-    set_on_unexpected_malloc_callback(nullptr);
-    set_on_unexpected_realloc_callback(nullptr);
-    set_on_unexpected_free_callback(nullptr);
   }
 };
 
@@ -65,7 +83,7 @@ bool is_windows = false;
 /* Tests the node accessors, i.e. rcl_node_get_* functions.
  */
 TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_accessors) {
-  stop_memory_checking();
+  osrf_testing_tools_cpp::memory_tools::enable_monitoring_in_all_threads();
   rcl_ret_t ret;
   // Initialize rcl with rcl_init().
   ret = rcl_init(0, nullptr, rcl_get_default_allocator());
@@ -88,9 +106,8 @@ TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_accessors)
     // This is the normal check (not windows and windows if not opensplice)
     ASSERT_EQ(RCL_RET_OK, ret);
   }
-  auto rcl_invalid_node_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&invalid_node]() {
+    osrf_testing_tools_cpp::memory_tools::disable_monitoring_in_all_threads();
-      stop_memory_checking();
     rcl_ret_t ret = rcl_node_fini(&invalid_node);
     EXPECT_EQ(RCL_RET_OK, ret);
   });
@@ -98,9 +115,8 @@ TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_accessors)
   ASSERT_EQ(RCL_RET_OK, ret);
   ret = rcl_init(0, nullptr, rcl_get_default_allocator());
   ASSERT_EQ(RCL_RET_OK, ret);
-  auto rcl_shutdown_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    []() {
+    osrf_testing_tools_cpp::memory_tools::disable_monitoring_in_all_threads();
-      stop_memory_checking();
     rcl_ret_t ret = rcl_shutdown();
     ASSERT_EQ(RCL_RET_OK, ret);
   });
@@ -110,9 +126,8 @@ TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_accessors)
   rcl_node_t node = rcl_get_zero_initialized_node();
   ret = rcl_node_init(&node, name, namespace_, &default_options);
   ASSERT_EQ(RCL_RET_OK, ret);
-  auto rcl_node_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&node]() {
+    osrf_testing_tools_cpp::memory_tools::disable_monitoring_in_all_threads();
-      stop_memory_checking();
     rcl_ret_t ret = rcl_node_fini(&node);
     EXPECT_EQ(RCL_RET_OK, ret);
   });
@@ -141,15 +156,9 @@ TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_accessors)
   actual_node_name = rcl_node_get_name(&invalid_node);
   EXPECT_EQ(nullptr, actual_node_name);
   rcl_reset_error();
-  start_memory_checking();
+  EXPECT_NO_MEMORY_OPERATIONS({
-  assert_no_malloc_begin();
-  assert_no_realloc_begin();
-  assert_no_free_begin();
     actual_node_name = rcl_node_get_name(&node);
-  assert_no_malloc_end();
+  });
-  assert_no_realloc_end();
-  assert_no_free_end();
-  stop_memory_checking();
   EXPECT_TRUE(actual_node_name ? true : false);
   if (actual_node_name) {
     EXPECT_EQ(std::string(name), std::string(actual_node_name));
@@ -165,15 +174,9 @@ TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_accessors)
   actual_node_namespace = rcl_node_get_namespace(&invalid_node);
   EXPECT_EQ(nullptr, actual_node_namespace);
   rcl_reset_error();
-  start_memory_checking();
+  EXPECT_NO_MEMORY_OPERATIONS({
-  assert_no_malloc_begin();
-  assert_no_realloc_begin();
-  assert_no_free_begin();
     actual_node_namespace = rcl_node_get_namespace(&node);
-  assert_no_malloc_end();
+  });
-  assert_no_realloc_end();
-  assert_no_free_end();
-  stop_memory_checking();
   EXPECT_TRUE(actual_node_namespace ? true : false);
   if (actual_node_namespace) {
     EXPECT_EQ(std::string(namespace_), std::string(actual_node_namespace));
@@ -189,15 +192,9 @@ TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_accessors)
   actual_node_logger_name = rcl_node_get_logger_name(&invalid_node);
   EXPECT_EQ(nullptr, actual_node_logger_name);
   rcl_reset_error();
-  start_memory_checking();
+  EXPECT_NO_MEMORY_OPERATIONS({
-  assert_no_malloc_begin();
-  assert_no_realloc_begin();
-  assert_no_free_begin();
     actual_node_logger_name = rcl_node_get_logger_name(&node);
-  assert_no_malloc_end();
+  });
-  assert_no_realloc_end();
-  assert_no_free_end();
-  stop_memory_checking();
   EXPECT_TRUE(actual_node_logger_name ? true : false);
   if (actual_node_logger_name) {
     EXPECT_EQ("ns." + std::string(name), std::string(actual_node_logger_name));
@@ -213,15 +210,9 @@ TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_accessors)
   actual_options = rcl_node_get_options(&invalid_node);
   EXPECT_EQ(nullptr, actual_options);
   rcl_reset_error();
-  start_memory_checking();
+  EXPECT_NO_MEMORY_OPERATIONS({
-  assert_no_malloc_begin();
-  assert_no_realloc_begin();
-  assert_no_free_begin();
     actual_options = rcl_node_get_options(&node);
-  assert_no_malloc_end();
+  });
-  assert_no_realloc_end();
-  assert_no_free_end();
-  stop_memory_checking();
   EXPECT_NE(nullptr, actual_options);
   if (actual_options) {
     EXPECT_EQ(default_options.allocator.allocate, actual_options->allocator.allocate);
@@ -241,15 +232,9 @@ TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_accessors)
   EXPECT_EQ(RCL_RET_NODE_INVALID, ret);
   ASSERT_TRUE(rcl_error_is_set());
   rcl_reset_error();
-  start_memory_checking();
+  EXPECT_NO_MEMORY_OPERATIONS({
-  assert_no_malloc_begin();
-  assert_no_realloc_begin();
-  assert_no_free_begin();
     ret = rcl_node_get_domain_id(&node, &actual_domain_id);
-  assert_no_malloc_end();
+  });
-  assert_no_realloc_end();
-  assert_no_free_end();
-  stop_memory_checking();
   EXPECT_EQ(RCL_RET_OK, ret);
   if (RCL_RET_OK == ret && (!is_windows || !is_opensplice)) {
     // Can only expect the domain id to be 42 if not windows or not opensplice.
@@ -266,15 +251,9 @@ TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_accessors)
   node_handle = rcl_node_get_rmw_handle(&invalid_node);
   EXPECT_EQ(nullptr, node_handle);
   rcl_reset_error();
-  start_memory_checking();
+  EXPECT_NO_MEMORY_OPERATIONS({
-  assert_no_malloc_begin();
-  assert_no_realloc_begin();
-  assert_no_free_begin();
     node_handle = rcl_node_get_rmw_handle(&node);
-  assert_no_malloc_end();
+  });
-  assert_no_realloc_end();
-  assert_no_free_end();
-  stop_memory_checking();
   EXPECT_NE(nullptr, node_handle);
   // Test rcl_node_get_rcl_instance_id().
   uint64_t instance_id;
@@ -288,15 +267,9 @@ TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_accessors)
   EXPECT_NE(0u, instance_id);
   EXPECT_NE(42u, instance_id);
   rcl_reset_error();
-  start_memory_checking();
+  EXPECT_NO_MEMORY_OPERATIONS({
-  assert_no_malloc_begin();
-  assert_no_realloc_begin();
-  assert_no_free_begin();
     instance_id = rcl_node_get_rcl_instance_id(&node);
-  assert_no_malloc_end();
+  });
-  assert_no_realloc_end();
-  assert_no_free_end();
-  stop_memory_checking();
   EXPECT_NE(0u, instance_id);
   // Test rcl_node_get_graph_guard_condition
   const rcl_guard_condition_t * graph_guard_condition = nullptr;
@@ -309,22 +282,15 @@ TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_accessors)
   graph_guard_condition = rcl_node_get_graph_guard_condition(&invalid_node);
   EXPECT_EQ(nullptr, graph_guard_condition);
   rcl_reset_error();
-  start_memory_checking();
+  EXPECT_NO_MEMORY_OPERATIONS({
-  assert_no_malloc_begin();
-  assert_no_realloc_begin();
-  assert_no_free_begin();
     graph_guard_condition = rcl_node_get_graph_guard_condition(&node);
-  assert_no_malloc_end();
+  });
-  assert_no_realloc_end();
-  assert_no_free_end();
-  stop_memory_checking();
   EXPECT_NE(nullptr, graph_guard_condition);
 }
 
 /* Tests the node life cycle, including rcl_node_init() and rcl_node_fini().
  */
 TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_life_cycle) {
-  stop_memory_checking();
   rcl_ret_t ret;
   rcl_node_t node = rcl_get_zero_initialized_node();
   const char * name = "test_rcl_node_life_cycle_node";
@@ -338,8 +304,7 @@ TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_life_cycle)
   // Initialize rcl with rcl_init().
   ret = rcl_init(0, nullptr, rcl_get_default_allocator());
   ASSERT_EQ(RCL_RET_OK, ret);
-  auto rcl_shutdown_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    []() {
     rcl_ret_t ret = rcl_shutdown();
     ASSERT_EQ(RCL_RET_OK, ret);
   });
@@ -372,7 +337,6 @@ TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_life_cycle)
   // Try with failing allocator.
   rcl_node_options_t options_with_failing_allocator = rcl_node_get_default_options();
   options_with_failing_allocator.allocator.allocate = failing_malloc;
-  options_with_failing_allocator.allocator.deallocate = failing_free;
   options_with_failing_allocator.allocator.reallocate = failing_realloc;
   ret = rcl_node_init(&node, name, namespace_, &options_with_failing_allocator);
   EXPECT_EQ(RCL_RET_BAD_ALLOC, ret) << "Expected RCL_RET_BAD_ALLOC";
@@ -423,14 +387,12 @@ TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_life_cycle)
 /* Tests the node name restrictions enforcement.
  */
 TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_name_restrictions) {
-  stop_memory_checking();
   rcl_ret_t ret;
 
   // Initialize rcl with rcl_init().
   ret = rcl_init(0, nullptr, rcl_get_default_allocator());
   ASSERT_EQ(RCL_RET_OK, ret);
-  auto rcl_shutdown_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    []() {
     rcl_ret_t ret = rcl_shutdown();
     ASSERT_EQ(RCL_RET_OK, ret);
   });
@@ -484,14 +446,12 @@ TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_name_restri
 /* Tests the node namespace restrictions enforcement.
  */
 TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_namespace_restrictions) {
-  stop_memory_checking();
   rcl_ret_t ret;
 
   // Initialize rcl with rcl_init().
   ret = rcl_init(0, nullptr, rcl_get_default_allocator());
   ASSERT_EQ(RCL_RET_OK, ret);
-  auto rcl_shutdown_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    []() {
     rcl_ret_t ret = rcl_shutdown();
     ASSERT_EQ(RCL_RET_OK, ret);
   });
@@ -583,14 +543,12 @@ TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_namespace_r
 /* Tests the logger name associated with the node.
  */
 TEST_F(CLASSNAME(TestNodeFixture, RMW_IMPLEMENTATION), test_rcl_node_logger_name) {
-  stop_memory_checking();
   rcl_ret_t ret;
 
   // Initialize rcl with rcl_init().
   ret = rcl_init(0, nullptr, rcl_get_default_allocator());
   ASSERT_EQ(RCL_RET_OK, ret);
-  auto rcl_shutdown_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    []() {
     rcl_ret_t ret = rcl_shutdown();
     ASSERT_EQ(RCL_RET_OK, ret);
   });

rcl/test/rcl/test_publisher.cpp

@@ -21,8 +21,8 @@
 #include "std_msgs/msg/string.h"
 #include "rosidl_generator_c/string_functions.h"
 
-#include "../memory_tools/memory_tools.hpp"
+#include "./failing_allocator_functions.hpp"
-#include "../scope_exit.hpp"
+#include "osrf_testing_tools_cpp/scope_exit.hpp"
 #include "rcl/error_handling.h"
 
 #ifdef RMW_IMPLEMENTATION
@@ -38,7 +38,6 @@ public:
   rcl_node_t * node_ptr;
   void SetUp()
   {
-    stop_memory_checking();
     rcl_ret_t ret;
     ret = rcl_init(0, nullptr, rcl_get_default_allocator());
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
@@ -48,21 +47,10 @@ public:
     rcl_node_options_t node_options = rcl_node_get_default_options();
     ret = rcl_node_init(this->node_ptr, name, "", &node_options);
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-    set_on_unexpected_malloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED MALLOC";});
-    set_on_unexpected_realloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED REALLOC";});
-    set_on_unexpected_free_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED FREE";});
-    start_memory_checking();
   }
 
   void TearDown()
   {
-    assert_no_malloc_end();
-    assert_no_realloc_end();
-    assert_no_free_end();
-    stop_memory_checking();
-    set_on_unexpected_malloc_callback(nullptr);
-    set_on_unexpected_realloc_callback(nullptr);
-    set_on_unexpected_free_callback(nullptr);
     rcl_ret_t ret = rcl_node_fini(this->node_ptr);
     delete this->node_ptr;
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
@@ -74,7 +62,6 @@ public:
 /* Basic nominal test of a publisher.
  */
 TEST_F(CLASSNAME(TestPublisherFixture, RMW_IMPLEMENTATION), test_publisher_nominal) {
-  stop_memory_checking();
   rcl_ret_t ret;
   rcl_publisher_t publisher = rcl_get_zero_initialized_publisher();
   const rosidl_message_type_support_t * ts = ROSIDL_GET_MSG_TYPE_SUPPORT(std_msgs, msg, Int64);
@@ -93,9 +80,7 @@ TEST_F(CLASSNAME(TestPublisherFixture, RMW_IMPLEMENTATION), test_publisher_nomin
   rcl_publisher_options_t publisher_options = rcl_publisher_get_default_options();
   ret = rcl_publisher_init(&publisher, this->node_ptr, ts, topic_name, &publisher_options);
   ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-  auto publisher_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&publisher, this]() {
-      stop_memory_checking();
     rcl_ret_t ret = rcl_publisher_fini(&publisher, this->node_ptr);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   });
@@ -111,7 +96,6 @@ TEST_F(CLASSNAME(TestPublisherFixture, RMW_IMPLEMENTATION), test_publisher_nomin
 /* Basic nominal test of a publisher with a string.
  */
 TEST_F(CLASSNAME(TestPublisherFixture, RMW_IMPLEMENTATION), test_publisher_nominal_string) {
-  stop_memory_checking();
   rcl_ret_t ret;
   rcl_publisher_t publisher = rcl_get_zero_initialized_publisher();
   const rosidl_message_type_support_t * ts = ROSIDL_GET_MSG_TYPE_SUPPORT(std_msgs, msg, String);
@@ -119,9 +103,7 @@ TEST_F(CLASSNAME(TestPublisherFixture, RMW_IMPLEMENTATION), test_publisher_nomin
   rcl_publisher_options_t publisher_options = rcl_publisher_get_default_options();
   ret = rcl_publisher_init(&publisher, this->node_ptr, ts, topic_name, &publisher_options);
   ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-  auto publisher_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&publisher, this]() {
-      stop_memory_checking();
     rcl_ret_t ret = rcl_publisher_fini(&publisher, this->node_ptr);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   });
@@ -136,7 +118,6 @@ TEST_F(CLASSNAME(TestPublisherFixture, RMW_IMPLEMENTATION), test_publisher_nomin
 /* Testing the publisher init and fini functions.
  */
 TEST_F(CLASSNAME(TestPublisherFixture, RMW_IMPLEMENTATION), test_publisher_init_fini) {
-  stop_memory_checking();
   rcl_ret_t ret;
   // Setup valid inputs.
   rcl_publisher_t publisher;
@@ -146,6 +127,7 @@ TEST_F(CLASSNAME(TestPublisherFixture, RMW_IMPLEMENTATION), test_publisher_init_
 
   // Check if null publisher is valid
   EXPECT_FALSE(rcl_publisher_is_valid(nullptr, nullptr));
+  rcl_reset_error();
 
   // Check if zero initialized node is valid
   publisher = rcl_get_zero_initialized_publisher();
@@ -222,8 +204,8 @@ TEST_F(CLASSNAME(TestPublisherFixture, RMW_IMPLEMENTATION), test_publisher_init_
   rcl_publisher_options_t publisher_options_with_failing_allocator;
   publisher_options_with_failing_allocator = rcl_publisher_get_default_options();
   publisher_options_with_failing_allocator.allocator.allocate = failing_malloc;
-  publisher_options_with_failing_allocator.allocator.deallocate = failing_free;
   publisher_options_with_failing_allocator.allocator.reallocate = failing_realloc;
+  publisher_options_with_failing_allocator.allocator.zero_allocate = failing_calloc;
   ret = rcl_publisher_init(
     &publisher, this->node_ptr, ts, topic_name, &publisher_options_with_failing_allocator);
   EXPECT_EQ(RCL_RET_BAD_ALLOC, ret) << rcl_get_error_string_safe();

rcl/test/rcl/test_rcl.cpp

@@ -16,7 +16,8 @@
 
 #include "rcl/rcl.h"
 
-#include "../memory_tools/memory_tools.hpp"
+#include "./failing_allocator_functions.hpp"
+#include "osrf_testing_tools_cpp/memory_tools/memory_tools.hpp"
 #include "rcl/error_handling.h"
 #include "rcutils/snprintf.h"
 
@@ -27,26 +28,25 @@
 # define CLASSNAME(NAME, SUFFIX) NAME
 #endif
 
+using osrf_testing_tools_cpp::memory_tools::on_unexpected_malloc;
+using osrf_testing_tools_cpp::memory_tools::on_unexpected_realloc;
+using osrf_testing_tools_cpp::memory_tools::on_unexpected_calloc;
+using osrf_testing_tools_cpp::memory_tools::on_unexpected_free;
+
 class CLASSNAME (TestRCLFixture, RMW_IMPLEMENTATION) : public ::testing::Test
 {
 public:
   void SetUp()
   {
-    set_on_unexpected_malloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED MALLOC";});
+    osrf_testing_tools_cpp::memory_tools::initialize();
-    set_on_unexpected_realloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED REALLOC";});
+    on_unexpected_malloc([]() {ADD_FAILURE() << "UNEXPECTED MALLOC";});
-    set_on_unexpected_free_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED FREE";});
+    on_unexpected_realloc([]() {ADD_FAILURE() << "UNEXPECTED REALLOC";});
-    start_memory_checking();
+    on_unexpected_free([]() {ADD_FAILURE() << "UNEXPECTED FREE";});
   }
 
   void TearDown()
   {
-    assert_no_malloc_end();
+    osrf_testing_tools_cpp::memory_tools::uninitialize();
-    assert_no_realloc_end();
-    assert_no_free_end();
-    stop_memory_checking();
-    set_on_unexpected_malloc_callback(nullptr);
-    set_on_unexpected_realloc_callback(nullptr);
-    set_on_unexpected_free_callback(nullptr);
   }
 };
 
@@ -117,9 +117,9 @@ TEST_F(CLASSNAME(TestRCLFixture, RMW_IMPLEMENTATION), test_rcl_init_and_ok_and_s
   {
     FakeTestArgv test_args;
     rcl_allocator_t failing_allocator = rcl_get_default_allocator();
-    failing_allocator.allocate = &failing_malloc;
+    failing_allocator.allocate = failing_malloc;
-    failing_allocator.deallocate = failing_free;
     failing_allocator.reallocate = failing_realloc;
+    failing_allocator.zero_allocate = failing_calloc;
     ret = rcl_init(test_args.argc, test_args.argv, failing_allocator);
     EXPECT_EQ(RCL_RET_BAD_ALLOC, ret);
     rcl_reset_error();
@@ -187,13 +187,9 @@ TEST_F(CLASSNAME(TestRCLFixture, RMW_IMPLEMENTATION), test_rcl_get_instance_id_a
   }
   // And it should be allocation free.
   uint64_t first_instance_id;
-  assert_no_malloc_begin();
+  EXPECT_NO_MEMORY_OPERATIONS({
-  assert_no_realloc_begin();
-  assert_no_free_begin();
     first_instance_id = rcl_get_instance_id();
-  assert_no_malloc_end();
+  });
-  assert_no_realloc_end();
-  assert_no_free_end();
   EXPECT_NE(0u, first_instance_id);
   EXPECT_EQ(first_instance_id, rcl_get_instance_id());  // Repeat calls should return the same.
   EXPECT_EQ(true, rcl_ok());

rcl/test/rcl/test_service.cpp

@@ -24,8 +24,7 @@
 
 #include "example_interfaces/srv/add_two_ints.h"
 
-#include "../memory_tools/memory_tools.hpp"
+#include "osrf_testing_tools_cpp/scope_exit.hpp"
-#include "../scope_exit.hpp"
 #include "rcl/error_handling.h"
 
 #ifdef RMW_IMPLEMENTATION
@@ -41,7 +40,6 @@ public:
   rcl_node_t * node_ptr;
   void SetUp()
   {
-    stop_memory_checking();
     rcl_ret_t ret;
     ret = rcl_init(0, nullptr, rcl_get_default_allocator());
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
@@ -51,21 +49,10 @@ public:
     rcl_node_options_t node_options = rcl_node_get_default_options();
     ret = rcl_node_init(this->node_ptr, name, "", &node_options);
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-    set_on_unexpected_malloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED MALLOC";});
-    set_on_unexpected_realloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED REALLOC";});
-    set_on_unexpected_free_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED FREE";});
-    start_memory_checking();
   }
 
   void TearDown()
   {
-    assert_no_malloc_end();
-    assert_no_realloc_end();
-    assert_no_free_end();
-    stop_memory_checking();
-    set_on_unexpected_malloc_callback(nullptr);
-    set_on_unexpected_realloc_callback(nullptr);
-    set_on_unexpected_free_callback(nullptr);
     rcl_ret_t ret = rcl_node_fini(this->node_ptr);
     delete this->node_ptr;
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
@@ -84,9 +71,7 @@ wait_for_service_to_be_ready(
   rcl_wait_set_t wait_set = rcl_get_zero_initialized_wait_set();
   rcl_ret_t ret = rcl_wait_set_init(&wait_set, 0, 0, 0, 0, 1, rcl_get_default_allocator());
   ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-  auto wait_set_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&wait_set]() {
-      stop_memory_checking();
     rcl_ret_t ret = rcl_wait_set_fini(&wait_set);
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   });
@@ -115,7 +100,6 @@ wait_for_service_to_be_ready(
 /* Basic nominal test of a service.
  */
 TEST_F(CLASSNAME(TestServiceFixture, RMW_IMPLEMENTATION), test_service_nominal) {
-  stop_memory_checking();
   rcl_ret_t ret;
   const rosidl_service_type_support_t * ts = ROSIDL_GET_SRV_TYPE_SUPPORT(
     example_interfaces, AddTwoInts);
@@ -145,9 +129,7 @@ TEST_F(CLASSNAME(TestServiceFixture, RMW_IMPLEMENTATION), test_service_nominal)
 
   // Check that the service name matches what we assigned.
   EXPECT_EQ(strcmp(rcl_service_get_service_name(&service), expected_topic), 0);
-  auto service_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&service, this]() {
-      stop_memory_checking();
     rcl_ret_t ret = rcl_service_fini(&service, this->node_ptr);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   });
@@ -156,9 +138,7 @@ TEST_F(CLASSNAME(TestServiceFixture, RMW_IMPLEMENTATION), test_service_nominal)
   rcl_client_options_t client_options = rcl_client_get_default_options();
   ret = rcl_client_init(&client, this->node_ptr, ts, topic, &client_options);
   ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-  auto client_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&client, this]() {
-      stop_memory_checking();
     rcl_ret_t ret = rcl_client_fini(&client, this->node_ptr);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   });
@@ -189,9 +169,7 @@ TEST_F(CLASSNAME(TestServiceFixture, RMW_IMPLEMENTATION), test_service_nominal)
     // Initialize a response.
     example_interfaces__srv__AddTwoInts_Response service_response;
     example_interfaces__srv__AddTwoInts_Response__init(&service_response);
-    auto msg_exit = make_scope_exit(
+    OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-      [&service_response]() {
-        stop_memory_checking();
       example_interfaces__srv__AddTwoInts_Response__fini(&service_response);
     });
 

rcl/test/rcl/test_subscription.cpp

@@ -25,8 +25,7 @@
 #include "std_msgs/msg/string.h"
 #include "rosidl_generator_c/string_functions.h"
 
-#include "../memory_tools/memory_tools.hpp"
+#include "osrf_testing_tools_cpp/scope_exit.hpp"
-#include "../scope_exit.hpp"
 #include "rcl/error_handling.h"
 
 #ifdef RMW_IMPLEMENTATION
@@ -42,7 +41,6 @@ public:
   rcl_node_t * node_ptr;
   void SetUp()
   {
-    stop_memory_checking();
     rcl_ret_t ret;
     ret = rcl_init(0, nullptr, rcl_get_default_allocator());
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
@@ -52,21 +50,10 @@ public:
     rcl_node_options_t node_options = rcl_node_get_default_options();
     ret = rcl_node_init(this->node_ptr, name, "", &node_options);
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-    set_on_unexpected_malloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED MALLOC";});
-    set_on_unexpected_realloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED REALLOC";});
-    set_on_unexpected_free_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED FREE";});
-    start_memory_checking();
   }
 
   void TearDown()
   {
-    assert_no_malloc_end();
-    assert_no_realloc_end();
-    assert_no_free_end();
-    stop_memory_checking();
-    set_on_unexpected_malloc_callback(nullptr);
-    set_on_unexpected_realloc_callback(nullptr);
-    set_on_unexpected_free_callback(nullptr);
     rcl_ret_t ret = rcl_node_fini(this->node_ptr);
     delete this->node_ptr;
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
@@ -85,9 +72,7 @@ wait_for_subscription_to_be_ready(
   rcl_wait_set_t wait_set = rcl_get_zero_initialized_wait_set();
   rcl_ret_t ret = rcl_wait_set_init(&wait_set, 1, 0, 0, 0, 0, rcl_get_default_allocator());
   ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-  auto wait_set_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&wait_set]() {
-      stop_memory_checking();
     rcl_ret_t ret = rcl_wait_set_fini(&wait_set);
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   });
@@ -116,7 +101,6 @@ wait_for_subscription_to_be_ready(
 /* Basic nominal test of a subscription.
  */
 TEST_F(CLASSNAME(TestSubscriptionFixture, RMW_IMPLEMENTATION), test_subscription_nominal) {
-  stop_memory_checking();
   rcl_ret_t ret;
   rcl_publisher_t publisher = rcl_get_zero_initialized_publisher();
   const rosidl_message_type_support_t * ts = ROSIDL_GET_MSG_TYPE_SUPPORT(std_msgs, msg, Int64);
@@ -135,9 +119,7 @@ TEST_F(CLASSNAME(TestSubscriptionFixture, RMW_IMPLEMENTATION), test_subscription
   rcl_publisher_options_t publisher_options = rcl_publisher_get_default_options();
   ret = rcl_publisher_init(&publisher, this->node_ptr, ts, topic, &publisher_options);
   ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-  auto publisher_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&publisher, this]() {
-      stop_memory_checking();
     rcl_ret_t ret = rcl_publisher_fini(&publisher, this->node_ptr);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   });
@@ -145,9 +127,7 @@ TEST_F(CLASSNAME(TestSubscriptionFixture, RMW_IMPLEMENTATION), test_subscription
   rcl_subscription_options_t subscription_options = rcl_subscription_get_default_options();
   ret = rcl_subscription_init(&subscription, this->node_ptr, ts, topic, &subscription_options);
   ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-  auto subscription_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&subscription, this]() {
-      stop_memory_checking();
     rcl_ret_t ret = rcl_subscription_fini(&subscription, this->node_ptr);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   });
@@ -187,9 +167,7 @@ TEST_F(CLASSNAME(TestSubscriptionFixture, RMW_IMPLEMENTATION), test_subscription
   {
     std_msgs__msg__Int64 msg;
     std_msgs__msg__Int64__init(&msg);
-    auto msg_exit = make_scope_exit(
+    OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-      [&msg]() {
-        stop_memory_checking();
       std_msgs__msg__Int64__fini(&msg);
     });
     ret = rcl_take(&subscription, &msg, nullptr);
@@ -201,7 +179,6 @@ TEST_F(CLASSNAME(TestSubscriptionFixture, RMW_IMPLEMENTATION), test_subscription
 /* Basic nominal test of a publisher with a string.
  */
 TEST_F(CLASSNAME(TestSubscriptionFixture, RMW_IMPLEMENTATION), test_subscription_nominal_string) {
-  stop_memory_checking();
   rcl_ret_t ret;
   rcl_publisher_t publisher = rcl_get_zero_initialized_publisher();
   const rosidl_message_type_support_t * ts = ROSIDL_GET_MSG_TYPE_SUPPORT(std_msgs, msg, String);
@@ -209,9 +186,7 @@ TEST_F(CLASSNAME(TestSubscriptionFixture, RMW_IMPLEMENTATION), test_subscription
   rcl_publisher_options_t publisher_options = rcl_publisher_get_default_options();
   ret = rcl_publisher_init(&publisher, this->node_ptr, ts, topic, &publisher_options);
   ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-  auto publisher_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&publisher, this]() {
-      stop_memory_checking();
     rcl_ret_t ret = rcl_publisher_fini(&publisher, this->node_ptr);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   });
@@ -219,9 +194,7 @@ TEST_F(CLASSNAME(TestSubscriptionFixture, RMW_IMPLEMENTATION), test_subscription
   rcl_subscription_options_t subscription_options = rcl_subscription_get_default_options();
   ret = rcl_subscription_init(&subscription, this->node_ptr, ts, topic, &subscription_options);
   ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-  auto subscription_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&subscription, this]() {
-      stop_memory_checking();
     rcl_ret_t ret = rcl_subscription_fini(&subscription, this->node_ptr);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   });
@@ -244,9 +217,7 @@ TEST_F(CLASSNAME(TestSubscriptionFixture, RMW_IMPLEMENTATION), test_subscription
   {
     std_msgs__msg__String msg;
     std_msgs__msg__String__init(&msg);
-    auto msg_exit = make_scope_exit(
+    OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-      [&msg]() {
-        stop_memory_checking();
       std_msgs__msg__String__fini(&msg);
     });
     ret = rcl_take(&subscription, &msg, nullptr);

rcl/test/rcl/test_time.cpp

@@ -19,11 +19,10 @@
 #include <chrono>
 #include <thread>
 
+#include "osrf_testing_tools_cpp/memory_tools/memory_tools.hpp"
 #include "rcl/error_handling.h"
 #include "rcl/time.h"
 
-#include "../memory_tools/memory_tools.hpp"
-
 #ifdef RMW_IMPLEMENTATION
 # define CLASSNAME_(NAME, SUFFIX) NAME ## __ ## SUFFIX
 # define CLASSNAME(NAME, SUFFIX) CLASSNAME_(NAME, SUFFIX)
@@ -31,37 +30,37 @@
 # define CLASSNAME(NAME, SUFFIX) NAME
 #endif
 
+using osrf_testing_tools_cpp::memory_tools::on_unexpected_malloc;
+using osrf_testing_tools_cpp::memory_tools::on_unexpected_realloc;
+using osrf_testing_tools_cpp::memory_tools::on_unexpected_calloc;
+using osrf_testing_tools_cpp::memory_tools::on_unexpected_free;
+
 class CLASSNAME (TestTimeFixture, RMW_IMPLEMENTATION) : public ::testing::Test
 {
 public:
   void SetUp()
   {
-    set_on_unexpected_malloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED MALLOC";});
+    osrf_testing_tools_cpp::memory_tools::initialize();
-    set_on_unexpected_realloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED REALLOC";});
+    on_unexpected_malloc([]() {ADD_FAILURE() << "UNEXPECTED MALLOC";});
-    set_on_unexpected_free_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED FREE";});
+    on_unexpected_realloc([]() {ADD_FAILURE() << "UNEXPECTED REALLOC";});
-    start_memory_checking();
+    on_unexpected_calloc([]() {ADD_FAILURE() << "UNEXPECTED CALLOC";});
+    on_unexpected_free([]() {ADD_FAILURE() << "UNEXPECTED FREE";});
   }
 
   void TearDown()
   {
-    assert_no_malloc_end();
+    osrf_testing_tools_cpp::memory_tools::uninitialize();
-    assert_no_realloc_end();
-    assert_no_free_end();
-    stop_memory_checking();
-    set_on_unexpected_malloc_callback(nullptr);
-    set_on_unexpected_realloc_callback(nullptr);
-    set_on_unexpected_free_callback(nullptr);
   }
 };
 
 // Tests the rcl_set_ros_time_override() function.
 TEST_F(CLASSNAME(TestTimeFixture, RMW_IMPLEMENTATION), test_rcl_ros_time_set_override) {
+  osrf_testing_tools_cpp::memory_tools::enable_monitoring_in_all_threads();
   rcl_clock_t ros_clock;
   rcl_allocator_t allocator = rcl_get_default_allocator();
   rcl_ret_t retval = rcl_ros_clock_init(&ros_clock, &allocator);
   EXPECT_EQ(retval, RCL_RET_OK) << rcl_get_error_string_safe();
 
-  assert_no_realloc_begin();
   rcl_ret_t ret;
   // Check for invalid argument error condition (allowed to alloc).
   ret = rcl_set_ros_time_override(nullptr, 0);
@@ -82,14 +81,10 @@ TEST_F(CLASSNAME(TestTimeFixture, RMW_IMPLEMENTATION), test_rcl_ros_time_set_ove
   ret = rcl_is_enabled_ros_time_override(&ros_clock, &is_enabled);
   EXPECT_EQ(ret, RCL_RET_OK) << rcl_get_error_string_safe();
   EXPECT_EQ(is_enabled, false);
-  assert_no_malloc_begin();
+  EXPECT_NO_MEMORY_OPERATIONS({
-  assert_no_free_begin();
     // Check for normal operation (not allowed to alloc).
     ret = rcl_clock_get_now(&ros_clock, &query_now);
-  assert_no_malloc_end();
+  });
-  assert_no_realloc_end();
-  assert_no_free_end();
-  stop_memory_checking();
   EXPECT_EQ(ret, RCL_RET_OK) << rcl_get_error_string_safe();
   EXPECT_NE(query_now.nanoseconds, 0u);
   // Compare to std::chrono::system_clock time (within a second).

rcl/test/rcl/test_timer.cpp

@@ -18,18 +18,15 @@
 
 #include "rcl/rcl.h"
 
-#include "../memory_tools/memory_tools.hpp"
+#include "osrf_testing_tools_cpp/scope_exit.hpp"
-#include "../scope_exit.hpp"
 #include "rcl/error_handling.h"
 
-
 class TestTimerFixture : public ::testing::Test
 {
 public:
   rcl_node_t * node_ptr;
   void SetUp()
   {
-    stop_memory_checking();
     rcl_ret_t ret;
     ret = rcl_init(0, nullptr, rcl_get_default_allocator());
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
@@ -39,21 +36,10 @@ public:
     rcl_node_options_t node_options = rcl_node_get_default_options();
     ret = rcl_node_init(this->node_ptr, name, "", &node_options);
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-    set_on_unexpected_malloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED MALLOC";});
-    set_on_unexpected_realloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED REALLOC";});
-    set_on_unexpected_free_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED FREE";});
-    start_memory_checking();
   }
 
   void TearDown()
   {
-    assert_no_malloc_end();
-    assert_no_realloc_end();
-    assert_no_free_end();
-    stop_memory_checking();
-    set_on_unexpected_malloc_callback(nullptr);
-    set_on_unexpected_realloc_callback(nullptr);
-    set_on_unexpected_free_callback(nullptr);
     rcl_ret_t ret = rcl_node_fini(this->node_ptr);
     delete this->node_ptr;
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
@@ -63,7 +49,6 @@ public:
 };
 
 TEST_F(TestTimerFixture, test_two_timers) {
-  stop_memory_checking();
   rcl_ret_t ret;
   rcl_timer_t timer = rcl_get_zero_initialized_timer();
   rcl_timer_t timer2 = rcl_get_zero_initialized_timer();
@@ -82,8 +67,7 @@ TEST_F(TestTimerFixture, test_two_timers) {
   EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   ret = rcl_wait_set_add_timer(&wait_set, &timer2);
   EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-  auto timer_exit = make_scope_exit([&timer, &timer2, &wait_set]() {
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-        stop_memory_checking();
     rcl_ret_t ret = rcl_timer_fini(&timer);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
     ret = rcl_timer_fini(&timer2);
@@ -110,7 +94,6 @@ TEST_F(TestTimerFixture, test_two_timers) {
 }
 
 TEST_F(TestTimerFixture, test_two_timers_ready_before_timeout) {
-  stop_memory_checking();
   rcl_ret_t ret;
   rcl_timer_t timer = rcl_get_zero_initialized_timer();
   rcl_timer_t timer2 = rcl_get_zero_initialized_timer();
@@ -129,8 +112,7 @@ TEST_F(TestTimerFixture, test_two_timers_ready_before_timeout) {
   EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   ret = rcl_wait_set_add_timer(&wait_set, &timer2);
   EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-  auto timer_exit = make_scope_exit([&timer, &timer2, &wait_set]() {
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-        stop_memory_checking();
     rcl_ret_t ret = rcl_timer_fini(&timer);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
     ret = rcl_timer_fini(&timer2);
@@ -157,7 +139,6 @@ TEST_F(TestTimerFixture, test_two_timers_ready_before_timeout) {
 }
 
 TEST_F(TestTimerFixture, test_timer_not_ready) {
-  stop_memory_checking();
   rcl_ret_t ret;
   rcl_timer_t timer = rcl_get_zero_initialized_timer();
 
@@ -171,8 +152,7 @@ TEST_F(TestTimerFixture, test_timer_not_ready) {
   ret = rcl_wait_set_add_timer(&wait_set, &timer);
   EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
 
-  auto timer_exit = make_scope_exit([&timer, &wait_set]() {
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-        stop_memory_checking();
     rcl_ret_t ret = rcl_timer_fini(&timer);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
     ret = rcl_wait_set_fini(&wait_set);
@@ -194,7 +174,6 @@ TEST_F(TestTimerFixture, test_timer_not_ready) {
 }
 
 TEST_F(TestTimerFixture, test_canceled_timer) {
-  stop_memory_checking();
   rcl_ret_t ret;
   rcl_timer_t timer = rcl_get_zero_initialized_timer();
 
@@ -211,8 +190,7 @@ TEST_F(TestTimerFixture, test_canceled_timer) {
   ret = rcl_wait_set_add_timer(&wait_set, &timer);
   EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
 
-  auto timer_exit = make_scope_exit([&timer, &wait_set]() {
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-        stop_memory_checking();
     rcl_ret_t ret = rcl_timer_fini(&timer);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
     ret = rcl_wait_set_fini(&wait_set);

rcl/test/rcl/test_wait.cpp

@@ -22,9 +22,9 @@
 
 #include "gtest/gtest.h"
 
-#include "../scope_exit.hpp"
+#include "osrf_testing_tools_cpp/scope_exit.hpp"
-#include "rcl/rcl.h"
 #include "rcl/error_handling.h"
+#include "rcl/rcl.h"
 #include "rcl/wait.h"
 
 #include "rcutils/logging_macros.h"
@@ -109,8 +109,7 @@ TEST_F(CLASSNAME(WaitSetTestFixture, RMW_IMPLEMENTATION), negative_timeout) {
   ret = rcl_wait_set_add_timer(&wait_set, &timer);
   EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
 
-  auto scope_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&guard_cond, &wait_set, &timer]() {
     rcl_ret_t ret = rcl_guard_condition_fini(&guard_cond);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
     ret = rcl_wait_set_fini(&wait_set);
@@ -143,8 +142,7 @@ TEST_F(CLASSNAME(WaitSetTestFixture, RMW_IMPLEMENTATION), zero_timeout) {
   ret = rcl_wait_set_add_guard_condition(&wait_set, &guard_cond);
   EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
 
-  auto scope_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&guard_cond, &wait_set]() {
     rcl_ret_t ret = rcl_guard_condition_fini(&guard_cond);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
     ret = rcl_wait_set_fini(&wait_set);
@@ -176,15 +174,14 @@ TEST_F(CLASSNAME(WaitSetTestFixture, RMW_IMPLEMENTATION), zero_timeout_triggered
   ret = rcl_trigger_guard_condition(&guard_cond);
   EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
 
-  auto scope_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&guard_cond, &wait_set]() {
     rcl_ret_t ret = rcl_guard_condition_fini(&guard_cond);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
     ret = rcl_wait_set_fini(&wait_set);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   });
 
-  // Time spent during wait should be negligible.
+// Time spent during wait should be negligible.
   int64_t timeout = 0;
   std::chrono::steady_clock::time_point before_sc = std::chrono::steady_clock::now();
   ret = rcl_wait(&wait_set, timeout);
@@ -216,8 +213,7 @@ TEST_F(CLASSNAME(WaitSetTestFixture, RMW_IMPLEMENTATION), canceled_timer) {
   ret = rcl_wait_set_add_timer(&wait_set, &canceled_timer);
   EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
 
-  auto scope_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&guard_cond, &wait_set, &canceled_timer]() {
     rcl_ret_t ret = rcl_guard_condition_fini(&guard_cond);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
     ret = rcl_wait_set_fini(&wait_set);
@@ -265,11 +261,12 @@ TEST_F(CLASSNAME(WaitSetTestFixture, RMW_IMPLEMENTATION), multi_wait_set_threade
     size_t thread_id;
   };
   std::vector<TestSet> test_sets(number_of_threads);
+  // *INDENT-OFF* (prevent uncrustify from making unnecessary whitespace around [=])
   // Setup common function for waiting on the triggered guard conditions.
   auto wait_func_factory =
-    [count_target, retry_limit, wait_period](TestSet & test_set) {
+    [=](TestSet & test_set) {
       return
-        [&test_set, count_target, retry_limit, wait_period]() {
+        [=, &test_set]() {
           while (test_set.wake_count < count_target) {
             bool change_detected = false;
             size_t wake_try_count = 0;
@@ -309,6 +306,7 @@ TEST_F(CLASSNAME(WaitSetTestFixture, RMW_IMPLEMENTATION), multi_wait_set_threade
           }
         };
     };
+  // *INDENT-ON*
   // Setup each test set.
   for (auto & test_set : test_sets) {
     rcl_ret_t ret;
@@ -328,8 +326,7 @@ TEST_F(CLASSNAME(WaitSetTestFixture, RMW_IMPLEMENTATION), multi_wait_set_threade
     test_set.thread_id = 0;
   }
   // Setup safe tear-down.
-  auto scope_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&test_sets]() {
     for (auto & test_set : test_sets) {
       rcl_ret_t ret = rcl_guard_condition_fini(&test_set.guard_condition);
       EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
@@ -345,8 +342,9 @@ TEST_F(CLASSNAME(WaitSetTestFixture, RMW_IMPLEMENTATION), multi_wait_set_threade
     test_set.thread = std::thread(wait_func_factory(test_set));
   }
   // Loop, triggering every trigger_period until the threads are done.
+  // *INDENT-OFF* (prevent uncrustify from making unnecessary whitespace around [=])
   auto loop_test =
-    [&test_sets, count_target]() -> bool {
+    [=, &test_sets]() -> bool {
       for (const auto & test_set : test_sets) {
         if (test_set.wake_count.load() < count_target) {
           return true;
@@ -354,6 +352,7 @@ TEST_F(CLASSNAME(WaitSetTestFixture, RMW_IMPLEMENTATION), multi_wait_set_threade
       }
       return false;
     };
+  // *INDENT-ON*
   size_t loop_count = 0;
   while (loop_test()) {
     loop_count++;
@@ -385,8 +384,7 @@ TEST_F(CLASSNAME(WaitSetTestFixture, RMW_IMPLEMENTATION), guard_condition) {
   ret = rcl_wait_set_add_guard_condition(&wait_set, &guard_cond);
   EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
 
-  auto scope_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&wait_set, &guard_cond]() {
     rcl_ret_t ret = rcl_wait_set_fini(&wait_set);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
     ret = rcl_guard_condition_fini(&guard_cond);

rcl/test/scope_exit.hpp

@@ -1,40 +0,0 @@
-// Copyright 2015 Open Source Robotics Foundation, Inc.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-#ifndef SCOPE_EXIT_HPP_
-#define SCOPE_EXIT_HPP_
-
-#include <functional>
-
-template<typename Callable>
-struct ScopeExit
-{
-  explicit ScopeExit(Callable callable)
-  : callable_(callable) {}
-  ~ScopeExit() {callable_();}
-
-private:
-  Callable callable_;
-};
-
-template<typename Callable>
-ScopeExit<Callable>
-make_scope_exit(Callable callable)
-{
-  return ScopeExit<Callable>(callable);
-}
-
-#define SCOPE_EXIT(code) make_scope_exit([&]() {code;})
-
-#endif  // SCOPE_EXIT_HPP_

rcl/test/test_namespace.cpp

@@ -25,8 +25,7 @@
 #include "example_interfaces/srv/add_two_ints.h"
 #include "rosidl_generator_c/string_functions.h"
 
-#include "./memory_tools/memory_tools.hpp"
+#include "osrf_testing_tools_cpp/scope_exit.hpp"
-#include "./scope_exit.hpp"
 #include "rcl/error_handling.h"
 
 using namespace std::chrono_literals;
@@ -37,7 +36,6 @@ public:
   rcl_node_t * node_ptr;
   void SetUp()
   {
-    stop_memory_checking();
     rcl_ret_t ret;
     ret = rcl_init(0, nullptr, rcl_get_default_allocator());
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
@@ -47,21 +45,10 @@ public:
     rcl_node_options_t node_options = rcl_node_get_default_options();
     ret = rcl_node_init(this->node_ptr, name, "", &node_options);
     ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-    set_on_unexpected_malloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED MALLOC";});
-    set_on_unexpected_realloc_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED REALLOC";});
-    set_on_unexpected_free_callback([]() {ASSERT_FALSE(true) << "UNEXPECTED FREE";});
-    start_memory_checking();
   }
 
   void TearDown()
   {
-    assert_no_malloc_end();
-    assert_no_realloc_end();
-    assert_no_free_end();
-    stop_memory_checking();
-    set_on_unexpected_malloc_callback(nullptr);
-    set_on_unexpected_realloc_callback(nullptr);
-    set_on_unexpected_free_callback(nullptr);
     rcl_ret_t ret = rcl_node_fini(this->node_ptr);
     delete this->node_ptr;
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
@@ -73,8 +60,6 @@ public:
 /* Basic nominal test of a client.
  */
 TEST_F(TestNamespaceFixture, test_client_server) {
-  stop_memory_checking();
-
   rcl_ret_t ret;
   auto ts = ROSIDL_GET_SRV_TYPE_SUPPORT(example_interfaces, AddTwoInts);
   const char * service_name = "/my/namespace/test_namespace_client_server";
@@ -86,9 +71,7 @@ TEST_F(TestNamespaceFixture, test_client_server) {
   rcl_service_options_t service_options = rcl_service_get_default_options();
   ret = rcl_service_init(&service, this->node_ptr, ts, service_name, &service_options);
   ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-  auto service_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&service, this]() {
-      stop_memory_checking();
     rcl_ret_t ret = rcl_service_fini(&service, this->node_ptr);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   });
@@ -98,9 +81,7 @@ TEST_F(TestNamespaceFixture, test_client_server) {
   ret = rcl_client_init(
     &unmatched_client, this->node_ptr, ts, unmatched_client_name, &unmatched_client_options);
   ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-  auto unmatched_client_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&unmatched_client, this]() {
-      stop_memory_checking();
     rcl_ret_t ret = rcl_client_fini(&unmatched_client, this->node_ptr);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   });
@@ -121,9 +102,7 @@ TEST_F(TestNamespaceFixture, test_client_server) {
   ret = rcl_client_init(
     &matched_client, this->node_ptr, ts, matched_client_name, &matched_client_options);
   ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
-  auto matched_client_exit = make_scope_exit(
+  OSRF_TESTING_TOOLS_CPP_SCOPE_EXIT({
-    [&matched_client, this]() {
-      stop_memory_checking();
     rcl_ret_t ret = rcl_client_fini(&matched_client, this->node_ptr);
     EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
   });