niklas/rcl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

triggering a guard condition is not const (#89)

Browse source 
* triggering a guard condition is not const

* missed a const
This commit is contained in:
William Woodall 2016-12-09 17:10:16 -08:00 • committed by GitHub
parent e93544861c
commit 6bc013dd28
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
rcl/include/rcl/guard_condition.h
View file

@ -139,7 +139,7 @@ rcl_guard_condition_options_t
rcl_guard_condition_get_default_options(void); rcl_guard_condition_get_default_options(void);
/// Trigger a rcl guard condition. /// Trigger a rcl guard condition.
/* This function can fail, and therefore return NULL, if the: /* This function can fail, and return RCL_RET_INVALID_ARGUMENT, if the:
* - guard condition is NULL * - guard condition is NULL
* - guard condition is invalid (never called init or called fini) * - guard condition is invalid (never called init or called fini)
* *
@ -158,7 +158,7 @@ rcl_guard_condition_get_default_options(void);
RCL_PUBLIC RCL_PUBLIC
RCL_WARN_UNUSED RCL_WARN_UNUSED
rcl_ret_t rcl_ret_t
rcl_trigger_guard_condition(const rcl_guard_condition_t * guard_condition); rcl_trigger_guard_condition(rcl_guard_condition_t * guard_condition);
/// Return the rmw guard condition handle. /// Return the rmw guard condition handle.
/* The handle returned is a pointer to the internally held rmw handle. /* The handle returned is a pointer to the internally held rmw handle.

2
rcl/src/rcl/guard_condition.c
View file

@ -133,7 +133,7 @@ rcl_guard_condition_get_default_options()
} }
rcl_ret_t rcl_ret_t
rcl_trigger_guard_condition(const rcl_guard_condition_t * guard_condition) rcl_trigger_guard_condition(rcl_guard_condition_t * guard_condition)
{ {
// Perform argument validation. // Perform argument validation.
RCL_CHECK_ARGUMENT_FOR_NULL(guard_condition, RCL_RET_INVALID_ARGUMENT); RCL_CHECK_ARGUMENT_FOR_NULL(guard_condition, RCL_RET_INVALID_ARGUMENT);

2
rcl/test/rcl/test_wait.cpp
View file

@ -260,7 +260,7 @@ TEST(CLASSNAME(WaitSetTestFixture, RMW_IMPLEMENTATION), multi_wait_set_threaded)
size_t loop_count = 0; size_t loop_count = 0;
while (loop_test()) { while (loop_test()) {
loop_count++; loop_count++;
for (const auto & test_set : test_sets) { for (auto & test_set : test_sets) {
ret = rcl_trigger_guard_condition(&test_set.guard_condition); ret = rcl_trigger_guard_condition(&test_set.guard_condition);
EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe(); EXPECT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
} }