niklas/cyclonedds
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Properly pair entity_pin/mutex_lock

Browse source 
Coverity has difficulty observering that dds_entity_pin /
ddsrt_mutex_lock / dds_entity_unlock is correct.  It is perhaps a bit
confusing, so change it.

Signed-off-by: Erik Boasson <eb@ilities.com>
This commit is contained in:
Erik Boasson 2020-05-06 21:31:58 +02:00 • committed by eboasson
parent 06a0ba26c9
commit bf25c6ec80
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/core/ddsc/src/dds_topic.c
View file

@ -359,7 +359,8 @@ dds_entity_t dds_create_topic_impl (dds_entity_t participant, struct ddsi_sertop
hdl = create_topic_pp_locked (pp, ktp, (sertopic_registered->ops == &ddsi_sertopic_ops_builtintopic), sertopic_registered, listener, sedp_plist); hdl = create_topic_pp_locked (pp, ktp, (sertopic_registered->ops == &ddsi_sertopic_ops_builtintopic), sertopic_registered, listener, sedp_plist);
ddsi_sertopic_unref (*sertopic); ddsi_sertopic_unref (*sertopic);
*sertopic = sertopic_registered; *sertopic = sertopic_registered;
dds_participant_unlock (pp); ddsrt_mutex_unlock (&pp->m_entity.m_mutex);
dds_entity_unpin (&pp->m_entity);
GVTRACE ("dds_create_topic_generic: new topic %"PRId32"\n", hdl); GVTRACE ("dds_create_topic_generic: new topic %"PRId32"\n", hdl);
return hdl; return hdl;