From bf25c6ec807c1b33b23e5369d3715cce8b2fc7f0 Mon Sep 17 00:00:00 2001 From: Erik Boasson Date: Wed, 6 May 2020 21:31:58 +0200 Subject: [PATCH] Properly pair entity_pin/mutex_lock Coverity has difficulty observering that dds_entity_pin / ddsrt_mutex_lock / dds_entity_unlock is correct. It is perhaps a bit confusing, so change it. Signed-off-by: Erik Boasson --- src/core/ddsc/src/dds_topic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/core/ddsc/src/dds_topic.c b/src/core/ddsc/src/dds_topic.c index a07b4e3..0f48cbd 100644 --- a/src/core/ddsc/src/dds_topic.c +++ b/src/core/ddsc/src/dds_topic.c @@ -359,7 +359,8 @@ dds_entity_t dds_create_topic_impl (dds_entity_t participant, struct ddsi_sertop hdl = create_topic_pp_locked (pp, ktp, (sertopic_registered->ops == &ddsi_sertopic_ops_builtintopic), sertopic_registered, listener, sedp_plist); ddsi_sertopic_unref (*sertopic); *sertopic = sertopic_registered; - dds_participant_unlock (pp); + ddsrt_mutex_unlock (&pp->m_entity.m_mutex); + dds_entity_unpin (&pp->m_entity); GVTRACE ("dds_create_topic_generic: new topic %"PRId32"\n", hdl); return hdl;